[Lldb-commits] [lldb] r262156 - Revert "Fix bug with register values byte order in expression evaluation."

2016-02-27 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Sat Feb 27 16:48:50 2016 New Revision: 262156 URL: http://llvm.org/viewvc/llvm-project?rev=262156&view=rev Log: Revert "Fix bug with register values byte order in expression evaluation." This reverts commit r262041, which caused asserts starting yesterday on the OS X testbot

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

2016-02-27 Thread Todd Fiala via lldb-commits
Hi all, The new assert was failing on the OS X testbot here: http://lab.llvm.org:8080/green/job/lldb_build_test/ The nag mail didn't make it to you since we have it only fire on the transition from good build to bad build, and Tamas had the privilege of earning that with a minor Xcode breakage ju

Re: [Lldb-commits] [PATCH] D17425: Use shallow clones in build-llvm.py.

2016-02-27 Thread Todd Fiala via lldb-commits
Nah - please go ahead and submit it. I'll just make sure I add the ability to specify arbitrary git flags for the git part so you can have this when I put the new change in. On Mon, Feb 22, 2016 at 7:23 PM, Stephane Sezer via lldb-commits < lldb-commits@lists.llvm.org> wrote: > sas added a subsc

Re: [Lldb-commits] [PATCH] D17425: Use shallow clones in build-llvm.py.

2016-02-27 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D17425#363665, @tfiala wrote: > Nah - please go ahead and submit it. I'll just make sure I add the ability > to specify arbitrary git flags for the git part so you

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

2016-02-27 Thread Chaoren Lin via lldb-commits
I thought I fixed it with http://reviews.llvm.org/D17658. Did you revert that as well? On Sat, Feb 27, 2016 at 3:14 PM, Todd Fiala wrote: > Hi all, > > The new assert was failing on the OS X testbot here: > http://lab.llvm.org:8080/green/job/lldb_build_test/ > > The nag mail didn't make it to yo

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

2016-02-27 Thread Todd Fiala via lldb-commits
I brought the state of the lines changed there to what they were prior to the change. If you adjusted those same lines, then yes that got undone. We were failing different tests in those files. Your change may have fixed the new issues on Linux, but did not address the new failures on OS X. Th