[Lldb-commits] [lldb] r262450 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

Author: eugenezelenko Date: Tue Mar 1 20:18:18 2016 New Revision: 262450 URL: http://llvm.org/viewvc/llvm-project?rev=262450=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/source/Core/DataExtractor.cpp

[Lldb-commits] [lldb] r262441 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes.

Author: eugenezelenko Date: Tue Mar 1 19:09:03 2016 New Revision: 262441 URL: http://llvm.org/viewvc/llvm-project?rev=262441=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core; other minor fixes. Modified: lldb/trunk/include/lldb/Core/Broadcaster.h

[Lldb-commits] [lldb] r262407 - Fix bug with function resolution when using IR Interpreter

Author: ted Date: Tue Mar 1 15:53:26 2016 New Revision: 262407 URL: http://llvm.org/viewvc/llvm-project?rev=262407=rev Log: Fix bug with function resolution when using IR Interpreter Summary: Recent changes to the expression parser broke function name resolution when using the IR interpreter

Re: [Lldb-commits] [PATCH] D17745: Fix bug with function resolution when using IR Interpreter

ted updated this revision to Diff 49542. ted added a comment. Updated to address Sean's comments http://reviews.llvm.org/D17745 Files: include/lldb/Expression/IRInterpreter.h source/Expression/IRExecutionUnit.cpp source/Expression/IRInterpreter.cpp

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

You could add a test to that grabs functions bounds, once you implement functions, and then lookup each address inside of a function and make sure each one has a file and line. This might fall down for complex examples, but we also ran into the Swift compiler saying a function went from

Re: [Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

ldrumm updated this revision to Diff 49531. ldrumm added a comment. Updated diff to show full context http://reviews.llvm.org/D17719 Files: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h Index:

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

Regarding the refactoring of ResolveSymbolContext to a lower level. It seems like a worthwhile refactor but probably one that should be done as an independent CL. It seems like it has potential to open up a bit of a rats nest so to speak, and if something ends up breaking as a result, we can

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

You don't add plug-in specify unique_ptr and shared_ptr definitions. You would put these in SymbolFilePDB.h only. > On Mar 1, 2016, at 10:51 AM, Jim Ingham wrote: > > There's an lldb-private-forward.h that you can use for this purpose if you > wish. > > Jim > >> On Mar

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

On Tue, Mar 1, 2016 at 10:10 AM Greg Clayton wrote: > clayborg requested changes to this revision. > clayborg added a comment. > This revision now requires changes to proceed. > > One general comment is the use of "auto". Although it makes the code > shorter, it does make it

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. One general comment is the use of "auto". Although it makes the code shorter, it does make it quite a bit less readable. I will leave the decision to you since this is your

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

I think there's a lot of value in having lldb's help output and cl syntax match all of the other llvm tools that people are already familiar with. Simplicity through consistency. So lgtm On Tue, Mar 1, 2016 at 4:22 AM Pavel Labath wrote: > labath added a comment. > > In

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

zturner added a comment. I think there's a lot of value in having lldb's help output and cl syntax match all of the other llvm tools that people are already familiar with. Simplicity through consistency. So lgtm http://reviews.llvm.org/D17724 ___

[Lldb-commits] [lldb] r262339 - DWARFExpression: Don't resolve load address in DW_OP_plus

Author: tberghammer Date: Tue Mar 1 09:01:05 2016 New Revision: 262339 URL: http://llvm.org/viewvc/llvm-project?rev=262339=rev Log: DWARFExpression: Don't resolve load address in DW_OP_plus If we have a TargetLoadAddress on the top of the DWARF stack then a DW_OP_plus or a DW_OP_plus_ucons

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

labath added a comment. In http://reviews.llvm.org/D17724#364450, @clayborg wrote: > As long as both long and short options are still supported? Can you still > type any of: > > - --arch=x86_64 > - --arch x86_64 > - -arch=x86_64 > - -arch x86_64 > - -ax86_64 > - -a x86_64 All the variants

[Lldb-commits] [lldb] r262322 - Fix warning in NSDictionary.cpp

Author: labath Date: Tue Mar 1 05:40:47 2016 New Revision: 262322 URL: http://llvm.org/viewvc/llvm-project?rev=262322=rev Log: Fix warning in NSDictionary.cpp Modified: lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.cpp Modified:

Re: [Lldb-commits] [PATCH] D17750: arm ios doesn't have elf.h, sys/procfs.h, need to avoid including them on apple systems

jasonmolenda added a comment. Good point. Let me play with the xcode project file (which I was using to do the build) tomorrow; your solution may be the correct one, we might have some files being built unnecessarily. Repository: rL LLVM http://reviews.llvm.org/D17750

Re: [Lldb-commits] [PATCH] D17750: arm ios doesn't have elf.h, sys/procfs.h, need to avoid including them on apple systems

labath added a subscriber: labath. labath requested changes to this revision. labath added a reviewer: labath. labath added a comment. This revision now requires changes to proceed. The actual changes aren't too bad, but I wonder why you need to add them at all. These files all assume they will