chying added a comment.
Yes, it is fixed now. Thank you!
http://reviews.llvm.org/D17363
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
In http://reviews.llvm.org/D17724#366479, @clayborg wrote:
> Our current consistent way of parsing options is to use getopt_long()
> everywhere.
Actually with usage of `getopt_long_only()` which is unportable.
http://reviews.llvm.org/D17724
___
clayborg added a subscriber: clayborg.
clayborg added a comment.
This is already fixed. Update your sources and let us know if things are
working.
http://reviews.llvm.org/D17363
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
This is already fixed. Update your sources and let us know if things are
working.
> On Mar 2, 2016, at 5:10 PM, Ying Chen wrote:
>
> chying added a subscriber: chying.
> chying added a comment.
>
> Seems this patch breaks OSX build. I guess the new files were not added to
> xcode project file
Fixed with r262543
Jim
> On Mar 2, 2016, at 5:10 PM, Ying Chen via lldb-commits
> wrote:
>
> chying added a subscriber: chying.
> chying added a comment.
>
> Seems this patch breaks OSX build. I guess the new files were not added to
> xcode project file.
> Could you please take a look?
> htt
jingham added a subscriber: jingham.
jingham added a comment.
Fixed with r262543
Jim
http://reviews.llvm.org/D17363
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chying added a subscriber: chying.
chying added a comment.
Seems this patch breaks OSX build. I guess the new files were not added to
xcode project file.
Could you please take a look?
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/8892/steps/ninja%20build%20local/logs/stdio
ht
LGTM!
-Todd
> On Mar 2, 2016, at 2:49 AM, Pavel Labath wrote:
>
> labath created this revision.
> labath added a reviewer: tfiala.
> labath added a subscriber: lldb-commits.
>
> this enables download of remote log files for llgs and debugserver tests
> (previously we were just
> passing the h
tfiala added a subscriber: tfiala.
tfiala added a comment.
LGTM!
-Todd
http://reviews.llvm.org/D17798
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: eugenezelenko
Date: Wed Mar 2 18:51:40 2016
New Revision: 262570
URL: http://llvm.org/viewvc/llvm-project?rev=262570&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Core;
other minor fixes.
Modified:
lldb/trunk/source/Core/DataBufferHeap.cpp
l
Author: jmolenda
Date: Wed Mar 2 18:21:32 2016
New Revision: 262566
URL: http://llvm.org/viewvc/llvm-project?rev=262566&view=rev
Log:
Don't build source/Plugins/Process/Linux in the Xcode project file.
These files won't build for ios etc arm builds of lldb and aren't
used for macosx native lldb's
Author: jmolenda
Date: Wed Mar 2 17:39:59 2016
New Revision: 262543
URL: http://llvm.org/viewvc/llvm-project?rev=262543&view=rev
Log:
Add SymbolFilePDB to xcode project file to keep it
up to date after 4262528.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xc
Author: zturner
Date: Wed Mar 2 16:05:52 2016
New Revision: 262528
URL: http://llvm.org/viewvc/llvm-project?rev=262528&view=rev
Log:
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to c
clayborg added a comment.
The empty line signifies that the previous entry was a termination entry.
http://reviews.llvm.org/D17363
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I guess you already tackled the termination entry! That is exactly what I
wanted to see... Sounds like line tables are done!
http://reviews.llvm.org/D17363
zturner added a comment.
Is this what I should be seeing?
(lldb) target create
D:\src\llvm\tools\lldb\unittests\SymbolFile\PDB\Inputs\test-pdb.exe
Current executable set to
'D:\src\llvm\tools\lldb\unittests\SymbolFile\PDB\Inputs\test-pdb.exe' (i686).
(lldb) target modules dump line-table
zturner added a comment.
That should be easy enough. If we make the simplifying assumption "all
functions are represented contiguously in memory with no gaps", then I can just
create a termination entry at `start_of_function + num_bytes_in_function`.
Obviously this is a wrong assumption in the
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
As long as you don't mind your last line entry potentially being really large
because it isn't terminated?
(lldb) target create
D:\src\llvm\tools\lldb\unittests\SymbolFile\PDB
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262513: Use shallow clones in build-llvm.py. (authored by
sas).
Changed prior to commit:
http://reviews.llvm.org/D17425?vs=48427&id=49663#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17425
File
Author: sas
Date: Wed Mar 2 14:53:19 2016
New Revision: 262513
URL: http://llvm.org/viewvc/llvm-project?rev=262513&view=rev
Log:
Use shallow clones in build-llvm.py.
Summary:
This makes cloning (and therefore the whole build) faster.
The checkout step goes from ~4m to ~30s on my host.
Reviewers
zturner added a comment.
fwiw, here's my current output showing that things behave correctly for the
test case I've created.
(lldb) target create
D:\src\llvm\tools\lldb\unittests\SymbolFile\PDB\Inputs\test-pdb.exe
Current executable set to
'D:\src\llvm\tools\lldb\unittests\SymbolFile\PDB\I
zturner added a comment.
I looked into this a little bit, it's going to be a couple days of work for me
to get termination entries set correctly. Can I go in as-is? I know you
already Accepted the revision, just want to double check.
I need to go make some changes to `llvm-pdbdump` on the LLV
zturner added a comment.
In http://reviews.llvm.org/D17363#366522, @clayborg wrote:
> You are right. I am slowly seeing that PDB was designed well to be consumed
> as a user would want to, not compressed to the point of obfuscation and very
> difficult to extract data from like DWARF.
>
> So th
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
You are right. I am slowly seeing that PDB was designed well to be consumed as
a user would want to, not compressed to the point of obfuscation and very
difficult to extract data from like
zturner added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:291-292
@@ +290,4 @@
+// , either directly or indirectly.
+auto compilands =
+m_session_up->findCompilandsForSourceFile(file_spec.GetPath(),
llvm::PDB_NameSearch
clayborg added a comment.
Our current consistent way of parsing options is to use getopt_long()
everywhere.
http://reviews.llvm.org/D17724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So this is nice that you cleaned up this one place where we can use LLVM's
option parsing stuff, but it now makes the driver inconsistent with the rest of
LLDB. It also makes it
jingham added a comment.
IIUC, we can't get out of the business of supporting the HostGetOpt on freebsd
& windows since we can't use the llvm version for the command line. So I don't
see that it much eases the support burden. The differences in the help output
don't seem significant, which do
Author: tberghammer
Date: Wed Mar 2 06:42:43 2016
New Revision: 262482
URL: http://llvm.org/viewvc/llvm-project?rev=262482&view=rev
Log:
Upgrade the arm/thumb architecture used by the disassembler
Previously we were using thumbv7 and armv8.1a what ended up showing a
few undefined instruction whe
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
this enables download of remote log files for llgs and debugserver tests
(previously we were just
passing the host file name which obviously did not work). Note this also
changes the debugserv
labath added a subscriber: jingham.
labath added a comment.
Greg, Jim,
any objections?
http://reviews.llvm.org/D17724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
31 matches
Mail list logo
