Re: [Lldb-commits] [PATCH] D18017: Eliminate the TestStarted-XXX and TestFinished-XXX files from the test traces

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. I'm fine with nuking them. Prior to the parallel test runner, they were probably the most reliable way to tell if a test crashed in the middle of a run, and to figure out what it was. (Maybe

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

But it also has a project() and a cmake_required_version() statement, so if that is what is causing the policy to be reset in LLDBStandalone, the same would be true in that case too. Also clang CMakeLists.txt has it as the top, and it's basically the same as LLDB On Wed, Mar 9, 2016 at 5:22 PM Eu

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

Eugene.Zelenko added a comment. Probably not since in case of non-standalone build LLVM make file should be enough and LLDBStandalone.cmake will be not executed. Repository: rL LLVM http://reviews.llvm.org/D18018 ___ lldb-commits mailing list ll

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

Ahh that would make sense. I guess it needs to be set in both places in that case? On Wed, Mar 9, 2016 at 5:19 PM Eugene Zelenko wrote: > Eugene.Zelenko added a comment. > > My guess is that project() or cmake_minimum_required() resets policy value > set in upper level make file. > > > Reposito

[Lldb-commits] [lldb] r263085 - [DWARFASTParserClang] Start with member offset of 0 for members of union types.

Author: sivachandra Date: Wed Mar 9 19:15:17 2016 New Revision: 263085 URL: http://llvm.org/viewvc/llvm-project?rev=263085&view=rev Log: [DWARFASTParserClang] Start with member offset of 0 for members of union types. Summary: GCC does not emit DW_AT_data_member_location for members of a union. S

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

Eugene.Zelenko added a comment. My guess is that project() or cmake_minimum_required() resets policy value set in upper level make file. Repository: rL LLVM http://reviews.llvm.org/D18018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

But in LLVM and clang as well, it's always set in top-level CMakeLists.txt file, right? But you're saying for some reason that doesn't work in LLDB? On Wed, Mar 9, 2016 at 5:12 PM Eugene Zelenko wrote: > Eugene.Zelenko added a comment. > > I didn't work in main CMakeLists.txt. > > From other si

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

Eugene.Zelenko added a comment. I didn't work in main CMakeLists.txt. From other side, policy is not set only in standalone build, so place seems logical for me. Repository: rL LLVM http://reviews.llvm.org/D18018 ___ lldb-commits mailing list l

Re: [Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

zturner added a comment. I think this should be in `lldb/CMakeLists.txt`, not in `LLDBStandalone.cmake`. What do you think? Repository: rL LLVM http://reviews.llvm.org/D18018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

[Lldb-commits] [PATCH] D18018: [LLDB] Fix standalone build with CMake 2.8.12.2, broken after adding SymbolFile PDB plugin

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: zturner. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. LLVM and Clang CMakeLists.txt set this policy explicitly. Repository: rL LLVM http://reviews.llvm.org

[Lldb-commits] [lldb] r263079 - Certain hardware architectures have registers of 256 bits in size

Author: enrico Date: Wed Mar 9 18:14:29 2016 New Revision: 263079 URL: http://llvm.org/viewvc/llvm-project?rev=263079&view=rev Log: Certain hardware architectures have registers of 256 bits in size This patch extends Scalar such that it can support data living in such registers (e.g. float valu

[Lldb-commits] [lldb] r263078 - Fix SymbolFilePDB for discontiguous functions.

Author: zturner Date: Wed Mar 9 18:06:26 2016 New Revision: 263078 URL: http://llvm.org/viewvc/llvm-project?rev=263078&view=rev Log: Fix SymbolFilePDB for discontiguous functions. Previously line table parsing code assumed that the only gaps would occur at the end of functions. In practice this

Re: [Lldb-commits] [PATCH] D18017: Eliminate the TestStarted-XXX and TestFinished-XXX files from the test traces

zturner added a comment. Here's the commit that added this functionality: D:\src\llvm\tools\lldb\test>git show a73ad66a commit a73ad66a4ee96ccc8e6be4a645cd6b9180a72e4b Author: Johnny Chen Date: Thu Aug 16 19:15:21 2012 + Catch timestamps for the beginning and end of the te

Re: [Lldb-commits] [PATCH] D18017: Eliminate the TestStarted-XXX and TestFinished-XXX files from the test traces

zturner added a reviewer: labath. zturner added a comment. lgtm, Pavel does Android build infrastructure need these files for some reason? http://reviews.llvm.org/D18017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org

[Lldb-commits] [PATCH] D18017: Eliminate the TestStarted-XXX and TestFinished-XXX files from the test traces

amccarth created this revision. amccarth added reviewers: tfiala, zturner. amccarth added a subscriber: lldb-commits. Nobody seems to know what purpose these files serve, yet they were accumulating by the thousands in the test traces directory. I'm proposing we delete them. Creating these files

Re: [Lldb-commits] Improving the documentation

The relation between section offsets and files is stronger than you are stating here. You say: +/// Represents an address. An address may refer to code or data from an +/// existing module, or it may refer to something on the stack or heap. +/// That part is good, but you should use that in th

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

zturner added a comment. Sounds good. I will test this out once that patch goes in. And yea, I would prefer to remove the codepage stuff for now, and we can re-consider adding it back if/when someone actually needs it. Then we can discuss some other options like a preprocessor define that enabl

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

Sounds good. I will test this out once that patch goes in. And yea, I would prefer to remove the codepage stuff for now, and we can re-consider adding it back if/when someone actually needs it. Then we can discuss some other options like a preprocessor define that enables setting the codepage, o

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

cameron314 added a comment. Yes, if lldb.exe crashes or otherwise exits without returning to main, then the codepage will stay set in the current console. The latter can be fixed with a static object destructor, but not the former. I don't think this would be a practical problem, since very few

Re: [Lldb-commits] Improving the documentation

Here is a refinement of SBAddress. The patch also includes updates to classes referenced by SBAddress. Does this read better? Thanks, John On Wed, Mar 9, 2016 at 11:56 AM, Jim Ingham wrote: > In the case of something like SBAddress, I think it would be better to > have a class header that exp

Re: [Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

zturner added a comment. I'm waiting for the LLVM side change to go in and this patch rebased on top of that before I test it out. In the meantime, one thing I'm concerned about is setting the codepage of the console. You determined earlier that it affects the state of the console even after

[Lldb-commits] [lldb] r263066 - Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

Author: ted Date: Wed Mar 9 16:05:17 2016 New Revision: 263066 URL: http://llvm.org/viewvc/llvm-project?rev=263066&view=rev Log: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp Summary: From Adrian McCarthy: "Running ninja check-lldb now has one crash in a Python process, due to deferencin

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

mamai added a comment. Thanks! Could someone commit it for me? I don't have commit access. Repository: rL LLVM http://reviews.llvm.org/D18005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine to me. Repository: rL LLVM http://reviews.llvm.org/D18005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

mamai updated this revision to Diff 50192. mamai added a comment. Replaced the test by a new case in lang/c/anonymous test, as suggested by Jim. Is this correct? Repository: rL LLVM http://reviews.llvm.org/D18005 Files: packages/Python/lldbsuite/test/lang/c/anonymous/TestAnonymous.py so

Re: [Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

jingham added a comment. That seems fine to me. Thanks for putting up with the niggling... http://reviews.llvm.org/D17860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

ted updated this revision to Diff 50189. ted added a comment. Updated to address Jim's comments. http://reviews.llvm.org/D17860 Files: source/Expression/IRExecutionUnit.cpp Index: source/Expression/IRExecutionUnit.cpp === --- so

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: packages/Python/lldbsuite/test/functionalities/expression_path/TestExpressionPath.py:44-46 @@ +43,4 @@ +

Re: [Lldb-commits] [PATCH] D18008: [DWARFASTParserClang] Start with member offset of 0 for members of union types.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D18008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

ldrumm added a subscriber: ldrumm. ldrumm added a comment. Hi all This differential may also be somewhat relevant / of interest, although it deals only with typedefs of untagged struct types. Best Luke Repository: rL LLVM http://reviews.llvm.org/D18005

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

jingham added a comment. The part of frame variable you are testing here - namely the parsing of these "frame variable" paths, can also be directly accessed with SBValue::GetValueForExpressionPath (aargh, shouldn't have called that "expression" should we? Too late to change now.) Anyway, you

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

jingham added a comment. There's actually already a test for handling C anonymous unions in lang/c/anonymous. That tests the expression parser and some direct SBValue queries at present. It would be appropriate to add your test as another test case in here. Repository: rL LLVM http://rev

[Lldb-commits] [PATCH] D18008: [DWARFASTParserClang] Start with member offset of 0 for members of union types.

sivachandra created this revision. sivachandra added a reviewer: clayborg. sivachandra added a subscriber: lldb-commits. GCC does not emit DW_AT_data_member_location for members of a union. Starting with a 0 value for member locations helps is reading union types in such cases. http://reviews.llv

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

mamai added a comment. Sure. Would you have a suggestion of how to call it? Maybe something like variable_flat since it is the command used? Also, is it the right place to add it in functionalities or should it be elsewhere? Repository: rL LLVM http://reviews.llvm.org/D18005

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

jingham added a subscriber: jingham. jingham added a comment. The source change looks fine, but Greg's the owner of this code so I'll let him say yes for sure. But don't call the test case "ExpressionPath". The expression parser is different from frame variable. I understand that your intent

Re: [Lldb-commits] Improving the documentation

In the case of something like SBAddress, I think it would be better to have a class header that explains file/load addresses and section offset addresses. Then you can just use the terms in the function documentation, and they can be shorter and more explicit. Trying to define terms inline like

Re: [Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

mamai updated this revision to Diff 50172. mamai added a comment. Fixed test header, removed useless include. Repository: rL LLVM http://reviews.llvm.org/D18005 Files: packages/Python/lldbsuite/test/functionalities/expression_path/Makefile packages/Python/lldbsuite/test/functionalities/

[Lldb-commits] Improving the documentation

Having completed my C++ app on top of lldb, I would like to improve the function-level documentation so others don't have to blunder around in the dark the way I did :) Here is a patch for SBAddress.h If this is the right direction, I will work my way through the rest of the SB*.h files. Thanks!

[Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

mamai created this revision. mamai added a reviewer: clayborg. mamai added a subscriber: lldb-commits. mamai set the repository for this revision to rL LLVM. When the parent of an expression is anonymous, skip adding '.' or '->' before the expression name. Repository: rL LLVM http://reviews.l

Re: [Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

Right. If we have both, the symbol should be faster and won't potentially drag in more debug info, so we should use it. If the two have different addresses that's a more fundamental problem we shouldn't try to patch over here. We should only use the function if it's all we have. Note also, i

Re: [Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

So you'd like to see this function get the address of a function that it finds in either symbols or debug info? Which should it prioritize when we have both? Ted -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collabora

[Lldb-commits] [lldb] r263049 - Add an "offset" option to "break set -n" and "break set -f -l".

Author: jingham Date: Wed Mar 9 12:59:13 2016 New Revision: 263049 URL: http://llvm.org/viewvc/llvm-project?rev=263049&view=rev Log: Add an "offset" option to "break set -n" and "break set -f -l". That way you can set offset breakpoints that will move as the function they are contained in move

Re: [Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

ldrumm added a comment. Hi all I'm still keen to have someone more familiar with this code to let me know if anything's amiss, but I'll probably move ahead and commit this tomorrow if I don't hear anything. Let me know if you'd like any changes made - or the patch is simply rotten to the core