Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-05 Thread Zachary Turner via lldb-commits
Afaik there's no way to do from future imports with the c api, and executing the statement with RunOneLine doesn't do it either, it has to be in the script because it's treated specially by the interpreter. There might be a way to do it with some tricks that I didn't figure out last time. If its

[Lldb-commits] [lldb] r265498 - make TestRegisterVariables slightly more resilient

2016-04-05 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Tue Apr 5 20:14:37 2016 New Revision: 265498 URL: http://llvm.org/viewvc/llvm-project?rev=265498&view=rev Log: make TestRegisterVariables slightly more resilient This test sets the compiler optimization level to -O1 and makes some assumptions about how local frame vars will

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-05 Thread Jim Ingham via lldb-commits
Will this be necessary for everybody who uses "command script import" with Python 3? If so, it would be really nice to do this work in "command script import" if possible. Otherwise everybody will have to put this goo at the top of every .py file they write for formatters & breakpoint commands

[Lldb-commits] [lldb] r265495 - If the fixed expression doesn't parse, don't tell the user about it.

2016-04-05 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Apr 5 19:25:04 2016 New Revision: 265495 URL: http://llvm.org/viewvc/llvm-project?rev=265495&view=rev Log: If the fixed expression doesn't parse, don't tell the user about it. Modified: lldb/trunk/source/Expression/UserExpression.cpp Modified: lldb/trunk/source/Exp

[Lldb-commits] [lldb] r265496 - The FixItList typedef should have been inside "class ClangDiagnostic".

2016-04-05 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Apr 5 19:25:44 2016 New Revision: 265496 URL: http://llvm.org/viewvc/llvm-project?rev=265496&view=rev Log: The FixItList typedef should have been inside "class ClangDiagnostic". Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h Modified:

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-05 Thread Zachary Turner via lldb-commits
Yea I wasn't sure if the . would be necessary or not. If you write "from __future__ import absolute_import" at the top of each of these python files (foo.py and foo2.py or whatever they're called) then this should guarantee that the behavior is the same in both Python 2 and Python 3 On Tue, Apr 5

[Lldb-commits] [lldb] r265494 - Don't write "using $_lldb_local_vars" statements for variables with

2016-04-05 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Apr 5 19:24:17 2016 New Revision: 265494 URL: http://llvm.org/viewvc/llvm-project?rev=265494&view=rev Log: Don't write "using $_lldb_local_vars" statements for variables with no name. These were showing up with a recent clang, I haven't tracked down why yet, but adding

Re: [Lldb-commits] [PATCH] D18807: Add missing qRegisterInfo option to gdbremote testcase

2016-04-05 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Yes, good idea to add that. ProcessGDBRemote will need to accept "gcc" for at least a few years while old debugservers etc are floating around. http://reviews.llvm.org/D18807 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D18807: Add missing qRegisterInfo option to gdbremote testcase

2016-04-05 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: jasonmolenda, tfiala, clayborg. fjricci added subscribers: sas, lldb-commits. "gcc" is equivalent to "ehframe" in ProcessGDBRemote, but only "ehframe" was a valid response in the test suite. I know that "gcc" was replaced by "ehframe" in the

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-05 Thread Adrian McCarthy via lldb-commits
"error: module importing failed: Parent module '' not loaded, cannot perform relative import" If you omit the dot (i.e., `from foo import foo2`), it appears to work, but I'm not sure that does the right thing. I'll keep investigating. On Tue, Apr 5, 2016 at 3:40 PM, Zachary Turner wrote: > Wit

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-05 Thread Zachary Turner via lldb-commits
Without the modification to sys.path On Tue, Apr 5, 2016 at 3:39 PM Zachary Turner wrote: > Can you try to change "import foo2" to "from .foo import foo2" > On Tue, Apr 5, 2016 at 2:52 PM Adrian McCarthy > wrote: > >> I've drilled down into the Python import statement. It's >> in ScriptInterpre

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-05 Thread Zachary Turner via lldb-commits
Can you try to change "import foo2" to "from .foo import foo2" On Tue, Apr 5, 2016 at 2:52 PM Adrian McCarthy wrote: > I've drilled down into the Python import statement. It's > in ScriptInterpreterPython::LoadScriptingModule. The function inserts the > diretory into sys.path and then issues a

[Lldb-commits] [lldb] r265476 - Revert "XFail TestImport.py on Windows because Python 3 import rules don't work that way."

2016-04-05 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Tue Apr 5 16:49:41 2016 New Revision: 265476 URL: http://llvm.org/viewvc/llvm-project?rev=265476&view=rev Log: Revert "XFail TestImport.py on Windows because Python 3 import rules don't work that way." This reverts commit e5f0ba4fcf977ad6baaaca700d3646675cdac19b. Modifie

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-05 Thread Adrian McCarthy via lldb-commits
I've drilled down into the Python import statement. It's in ScriptInterpreterPython::LoadScriptingModule. The function inserts the diretory into sys.path and then issues a vanilla Python import statement. I spoke with one of our local Python experts who said that this technique to specify the di

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-05 Thread Zachary Turner via lldb-commits
I think we need some more information before we xfail this. It would help to drill down to either the python import statement or the PyImport_ImportModule C api call that actually does the import. If you can get that, i can help come up with a fix. Just need to step through the execution of the co

[Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

2016-04-05 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Tue Apr 5 15:49:09 2016 New Revision: 265461 URL: http://llvm.org/viewvc/llvm-project?rev=265461&view=rev Log: XFail TestImport.py on Windows because Python 3 import rules don't work that way. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/comman

[Lldb-commits] [lldb] r265443 - Fix a crasher that could happen if ClangASTSource::CompleteType() found a type whose name matched, but came from a different language. We need to verify that any types

2016-04-05 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Apr 5 14:29:05 2016 New Revision: 265443 URL: http://llvm.org/viewvc/llvm-project?rev=265443&view=rev Log: Fix a crasher that could happen if ClangASTSource::CompleteType() found a type whose name matched, but came from a different language. We need to verify that any

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-04-05 Thread Eran Ifrah via lldb-commits
eran.ifrah added inline comments. Comment at: CMakeLists.txt:3-5 @@ -2,1 +2,5 @@ +if(MINGW_DEBUG) + # force debugging info into lldb sources + message("-- Building LLDB in Debug mode") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O0") Adding ` -mbig-obj` for

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-04-05 Thread Eran Ifrah via lldb-commits
eran.ifrah updated this revision to Diff 52715. eran.ifrah marked an inline comment as done. eran.ifrah added a comment. Moved `dbghelp` to system_lib http://reviews.llvm.org/D18519 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake include/lldb/Host/window

Re: [Lldb-commits] [PATCH] D18779: Fix dotest.py '-p' option for multi-process mode

2016-04-05 Thread Stephane Sezer via lldb-commits
sas closed this revision. sas added a comment. Committed as r265422. http://reviews.llvm.org/D18779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r265422 - Fix dotest.py '-p' option for multi-process mode

2016-04-05 Thread Stephane Sezer via lldb-commits
Author: sas Date: Tue Apr 5 12:34:38 2016 New Revision: 265422 URL: http://llvm.org/viewvc/llvm-project?rev=265422&view=rev Log: Fix dotest.py '-p' option for multi-process mode Summary: The '-p' option for dotest.py was ignored in multiprocess mode, as the -p argument to the inferior would over

Re: [Lldb-commits] [PATCH] D18660: Update watchpoint help to use new -s flag

2016-04-05 Thread Stephane Sezer via lldb-commits
sas closed this revision. sas added a comment. Committed as r265421. http://reviews.llvm.org/D18660 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18620: Print environment when dumping arch triple

2016-04-05 Thread Stephane Sezer via lldb-commits
sas closed this revision. sas added a comment. Committed as r265420. http://reviews.llvm.org/D18620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r265421 - Update watchpoint help to use new -s flag

2016-04-05 Thread Stephane Sezer via lldb-commits
Author: sas Date: Tue Apr 5 12:30:31 2016 New Revision: 265421 URL: http://llvm.org/viewvc/llvm-project?rev=265421&view=rev Log: Update watchpoint help to use new -s flag Summary: Flag updated in D233237 Reviewers: spyffe, jingham, Eugene.Zelenko Subscribers: lldb-commits, sas Differential Re

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

2016-04-05 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a reviewer: jingham. jingham added a comment. Yes, that sounds right. http://reviews.llvm.org/D18692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D18631: Make sure to update Target arch if environment changed

2016-04-05 Thread Stephane Sezer via lldb-commits
sas closed this revision. sas added a comment. Committed as r265419. http://reviews.llvm.org/D18631 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r265420 - Print environment when dumping arch triple

2016-04-05 Thread Stephane Sezer via lldb-commits
Author: sas Date: Tue Apr 5 12:29:19 2016 New Revision: 265420 URL: http://llvm.org/viewvc/llvm-project?rev=265420&view=rev Log: Print environment when dumping arch triple Summary: Print environment from triple if it exists. Reviewers: tfiala, clayborg Subscribers: lldb-commits, sas Different

[Lldb-commits] [lldb] r265419 - Make sure to update Target arch if environment changed

2016-04-05 Thread Stephane Sezer via lldb-commits
Author: sas Date: Tue Apr 5 12:27:52 2016 New Revision: 265419 URL: http://llvm.org/viewvc/llvm-project?rev=265419&view=rev Log: Make sure to update Target arch if environment changed Summary: Fixes "target list" for non-android linux platforms (ie gnu, gnueabi) Reviewers: jasonmolenda, tfiala,

Re: [Lldb-commits] [PATCH] D18531: Allow gdbremote process to read modules from memory

2016-04-05 Thread Stephane Sezer via lldb-commits
sas closed this revision. sas added a comment. Committed as r265418. http://reviews.llvm.org/D18531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r265418 - Allow gdbremote process to read modules from memory

2016-04-05 Thread Stephane Sezer via lldb-commits
Author: sas Date: Tue Apr 5 12:25:32 2016 New Revision: 265418 URL: http://llvm.org/viewvc/llvm-project?rev=265418&view=rev Log: Allow gdbremote process to read modules from memory Summary: The logic to read modules from memory was added to LoadModuleAtAddress in the dynamic loader, but not in p

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

2016-04-05 Thread Pavel Labath via lldb-commits
labath added a comment. In http://reviews.llvm.org/D18692#389529, @clayborg wrote: > Looks fine. We should probably put the code that checks for a breakpoint at > the thread PC into a function since it is done about 5 times in this function. I'll prepare a follow-up to deduplicate the code her

[Lldb-commits] [lldb] r265406 - Reverting r265401 ("Enabling AddressSanitizer tests, they should work now.")

2016-04-05 Thread Kuba Brecka via lldb-commits
Author: kuba.brecka Date: Tue Apr 5 10:22:00 2016 New Revision: 265406 URL: http://llvm.org/viewvc/llvm-project?rev=265406&view=rev Log: Reverting r265401 ("Enabling AddressSanitizer tests, they should work now.") Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/Tes

[Lldb-commits] [lldb] r265398 - [NFC] Cleanup the code used to run shell commands from tests

2016-04-05 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Apr 5 09:08:18 2016 New Revision: 265398 URL: http://llvm.org/viewvc/llvm-project?rev=265398&view=rev Log: [NFC] Cleanup the code used to run shell commands from tests Previously we had 3 different method to run shell commands on the target and 4 copy of code waitin

Re: [Lldb-commits] [PATCH] D18789: [NFC] Cleanup the code used to run shell commands from tests

2016-04-05 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. A very nice cleanup. Comment at: packages/Python/lldbsuite/test/lldbutil.py:1040 @@ +1039,3 @@ +# Exponential backoff! +time.sleep(pow(2, i) * 0.25) +

[Lldb-commits] [lldb] r265400 - Fixing AddressSanitizer tests (update expectations for current ASan, make it work on OS X 10.10 and older).

2016-04-05 Thread Kuba Brecka via lldb-commits
Author: kuba.brecka Date: Tue Apr 5 09:13:22 2016 New Revision: 265400 URL: http://llvm.org/viewvc/llvm-project?rev=265400&view=rev Log: Fixing AddressSanitizer tests (update expectations for current ASan, make it work on OS X 10.10 and older). Modified: lldb/trunk/packages/Python/lldbsui

[Lldb-commits] [lldb] r265401 - Enabling AddressSanitizer tests, they should work now.

2016-04-05 Thread Kuba Brecka via lldb-commits
Author: kuba.brecka Date: Tue Apr 5 09:14:07 2016 New Revision: 265401 URL: http://llvm.org/viewvc/llvm-project?rev=265401&view=rev Log: Enabling AddressSanitizer tests, they should work now. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py

Re: [Lldb-commits] [PATCH] D18789: [NFC] Cleanup the code used to run shell commands from tests

2016-04-05 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: packages/Python/lldbsuite/test/lldbutil.py:1040 @@ +1039,3 @@ +# Exponential backoff! +time.sleep(pow(2, i) * 0.25) +else: labath wrote: > Please put 0.30 here. I remember needing to increa

Re: [Lldb-commits] [PATCH] D18789: [NFC] Cleanup the code used to run shell commands from tests

2016-04-05 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265398: [NFC] Cleanup the code used to run shell commands from tests (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D18789?vs=52681&id=52685#toc Repository: rL LLVM http

[Lldb-commits] [lldb] r265396 - Enabling TSan tests, they should work now.

2016-04-05 Thread Kuba Brecka via lldb-commits
Author: kuba.brecka Date: Tue Apr 5 08:59:45 2016 New Revision: 265396 URL: http://llvm.org/viewvc/llvm-project?rev=265396&view=rev Log: Enabling TSan tests, they should work now. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBasic.py lldb/trun

[Lldb-commits] [lldb] r265395 - Fix ThreadSanitizer test cases to work on OS X 10.10 and older.

2016-04-05 Thread Kuba Brecka via lldb-commits
Author: kuba.brecka Date: Tue Apr 5 08:57:42 2016 New Revision: 265395 URL: http://llvm.org/viewvc/llvm-project?rev=265395&view=rev Log: Fix ThreadSanitizer test cases to work on OS X 10.10 and older. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBa

[Lldb-commits] [PATCH] D18789: [NFC] Cleanup the code used to run shell commands from tests

2016-04-05 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added a reviewer: labath. tberghammer added a subscriber: lldb-commits. [NFC] Cleanup the code used to run shell commands from tests Previously we had 3 different method to run shell commands on the target and 4 copy of code waiting until a given fil

[Lldb-commits] [lldb] r265392 - Fix TestPlatformProcessConnect after rL265357

2016-04-05 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Apr 5 08:18:08 2016 New Revision: 265392 URL: http://llvm.org/viewvc/llvm-project?rev=265392&view=rev Log: Fix TestPlatformProcessConnect after rL265357 Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/platform-process-connect/TestPlatformP

Re: [Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

2016-04-05 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265391: Fix a bug in linux core file handling (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18697?vs=52572&id=52679#toc Repository: rL LLVM http://reviews.llvm.org/D18697

[Lldb-commits] [lldb] r265391 - Fix a bug in linux core file handling

2016-04-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Apr 5 08:07:16 2016 New Revision: 265391 URL: http://llvm.org/viewvc/llvm-project?rev=265391&view=rev Log: Fix a bug in linux core file handling Summary: There was a bug in linux core file handling, where if there was a running process with the same process id as the id