Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

Great, thanks. I'll rerun in the morning. I realized I also left the pthread linker option on in the test. Sent from my Windows Phone From: Zachary Turner Sent: ‎4/‎7/‎2016 6:21 PM To: Jackson Davis;

[Lldb-commits] [PATCH] D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received

ovyalov created this revision. ovyalov added a reviewer: clayborg. ovyalov added a subscriber: lldb-commits. Reset continue_after_async only if neither SIGINIT nor SIGSTOP received - otherwise it leads to stopped inferior when setting breakpoint (when m_interrupt_sent == true and signal is SIGST

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

zturner added a comment. We have an lldb style file in llvm/tools/lldb, it should be picked up automatically if you run it from the lldb directory. I'm not sure though if it's based on the folder you're in when you run clang-format or by searching up the tree from the target file until it finds a

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

We have an lldb style file in llvm/tools/lldb, it should be picked up automatically if you run it from the lldb directory. I'm not sure though if it's based on the folder you're in when you run clang-format or by searching up the tree from the target file until it finds a rule file On Thu, Apr 7, 2

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

jacdavis updated this revision to Diff 52991. jacdavis added a comment. Updated to use C++ 11 threads. Clang-format tried to format the diff in the llvm style. Since this is all lldb code, is that actually what is expected? None of the braces matched etc http://reviews.llvm.org/D18880 Fil

[Lldb-commits] [PATCH] Updated documentation for SBAddress

The patch is based off the latest code in the github mirror. It includes some documentation changes for other classes, but the primary change is for SBAddress. I intend to fill out the other classes in separate patches. I do not have committer access. Can somebody please merge this in? Thanks,

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

zturner added a subscriber: zturner. zturner added a comment. Hi Jackson, Two suggestions: 1. Please clang-format the patch. Let me know if you need help getting this working. 2. use C++11 threads instead of pthreads. This makes the tests portable to Windows. Even if the test still fails on

[Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

jacdavis created this revision. jacdavis added reviewers: lldb-commits, abidh. -thread-info in lldbmi does not conform to protocol. Should end with current thread id as described here: https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Thread-Commands.html#GDB_002fMI-Thread-Commands When pri

[Lldb-commits] [lldb] r265738 - Fix TestImport for Windows by ensuring backslashes in the directory paths are properly escaped in Python.

Author: amccarth Date: Thu Apr 7 17:52:12 2016 New Revision: 265738 URL: http://llvm.org/viewvc/llvm-project?rev=265738&view=rev Log: Fix TestImport for Windows by ensuring backslashes in the directory paths are properly escaped in Python. The Python import works by ensuring the directory of th

[Lldb-commits] [lldb] r265732 - In GDBRemoteCommunicationClient::GetHostInfo, don't set the

Author: jmolenda Date: Thu Apr 7 17:00:55 2016 New Revision: 265732 URL: http://llvm.org/viewvc/llvm-project?rev=265732&view=rev Log: In GDBRemoteCommunicationClient::GetHostInfo, don't set the os to "ios" or "macosx" if it is unspecified. For environments where there genuinely is no os, we don'

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

zturner added a comment. In http://reviews.llvm.org/D18848#394756, @clayborg wrote: > > One oddity of PDB is that the debug info does not maintain enough > > information to accurately reconstruct the DeclContext hierarchy. If you > > have this: > > > > > > namespace Foo > > > { > > >

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

clayborg added a comment. > One oddity of PDB is that the debug info does not maintain enough information > to accurately reconstruct the DeclContext hierarchy. If you have this: > > namespace Foo > { > class Bar > { > class Baz > { > }; >

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

clayborg added a comment. See inlined comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:154-156 @@ +153,5 @@ + +CompilerType clang_type = +m_ast.CreateRecordType(tu_decl_ctx, access, udt->getName().c_str(), TranslateUdtKind(udt_kind), +

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

zturner added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:154-156 @@ +153,5 @@ + +CompilerType clang_type = +m_ast.CreateRecordType(tu_decl_ctx, access, udt->getName().c_str(), TranslateUdtKind(udt_kind), +

Re: [Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

ovyalov accepted this revision. ovyalov added a comment. lgtm Repository: rL LLVM http://reviews.llvm.org/D18858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A few minor changes, but you are on the right track. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:75-121 @@ +74,49 @@ +{ +switch (type.getBuilt

Re: [Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1625-1626 @@ -1624,4 +1624,4 @@ if (arch_spec.GetMachine() == llvm::Triple::mips

[Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The ArchSpec::m_flags will be set based on ELF flag ABI. Repository

[Lldb-commits] [lldb] r265656 - Enabling AddressSanitizer tests, they should pass now (and this time I mean it).

Author: kuba.brecka Date: Thu Apr 7 06:01:05 2016 New Revision: 265656 URL: http://llvm.org/viewvc/llvm-project?rev=265656&view=rev Log: Enabling AddressSanitizer tests, they should pass now (and this time I mean it). Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan

[Lldb-commits] [lldb] r265652 - Simplify the ASan expression (follow-up for the previous commit, r265651).

Author: kuba.brecka Date: Thu Apr 7 05:07:45 2016 New Revision: 265652 URL: http://llvm.org/viewvc/llvm-project?rev=265652&view=rev Log: Simplify the ASan expression (follow-up for the previous commit, r265651). Modified: lldb/trunk/source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp M

[Lldb-commits] [lldb] r265651 - Tentative fix (add `extern "C"` declarations to expression prefix) and printing evaluation errors for AddressSanitizer (both MemoryHistoryASan.cpp and AddressSanitizerR

Author: kuba.brecka Date: Thu Apr 7 05:02:43 2016 New Revision: 265651 URL: http://llvm.org/viewvc/llvm-project?rev=265651&view=rev Log: Tentative fix (add `extern "C"` declarations to expression prefix) and printing evaluation errors for AddressSanitizer (both MemoryHistoryASan.cpp and Address

[Lldb-commits] [lldb] r265650 - Enable TestDebugBreak on x86_64 as well

Author: labath Date: Thu Apr 7 04:25:04 2016 New Revision: 265650 URL: http://llvm.org/viewvc/llvm-project?rev=265650&view=rev Log: Enable TestDebugBreak on x86_64 as well Test passes there, and this would have helped me catch the snafu in the previous commit. Modified: lldb/trunk/package

Re: [Lldb-commits] [PATCH] D18853: [LLDB][MIPS] Fix Floating point Registers Encoding

sagar accepted this revision. sagar added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D18853 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] r265647 - Revert "Reduce code duplication in ProcessGDBRemote"

Author: labath Date: Thu Apr 7 03:16:10 2016 New Revision: 265647 URL: http://llvm.org/viewvc/llvm-project?rev=265647&view=rev Log: Revert "Reduce code duplication in ProcessGDBRemote" In turns out this does make a functional change, in case when the inferior hits an int3 that was not placed by

[Lldb-commits] [PATCH] D18853: [LLDB][MIPS] Fix Floating point Registers Encoding

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, sagar. nitesh.jain added subscribers: jaydeep, bhushan, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. Herald added a subscriber: sdardis. Currently floating point regsiters has "eE