Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

2016-05-04 Thread Renato Golin via lldb-commits
rengolin added a comment. In http://reviews.llvm.org/D19604#420681, @jasonmolenda wrote: > fwiw, there are ARM cores that only support thumb - the Cortex M series. And they're still "armv7". :) Remember, "armv7" is *not* the same as ARMv7A+NEON. If the only thing you have is "armv7" or even "

[Lldb-commits] [PATCH] D19916: Fix EOF handling in AdbClient (take 2)

2016-05-04 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: ovyalov. labath added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. AdbClient would spin in a loop in ReadAllBytes in case the remote end was closed before reading the requested number of bytes. Make sure we re

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

2016-05-04 Thread Muhammad Omair Javaid via lldb-commits
omjavaid added a comment. In case of ELF .arm attributes contains tags providing information on underlying CPU specification used. Thats only for the inferior being debugged but actually knowing which target we are running on, like for example if we want to figure out if we are running on a arm

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

2016-05-04 Thread Renato Golin via lldb-commits
rengolin added a comment. In http://reviews.llvm.org/D19604#421086, @omjavaid wrote: > Right now we can distingusih between hard and soft float based on ABI > information in elf. But cant really tell if hard float is legacy VFP or neon. If the object has build attributes, it could help. But yo

Re: [Lldb-commits] [PATCH] D19916: Fix EOF handling in AdbClient (take 2)

2016-05-04 Thread Oleksiy Vyalov via lldb-commits
ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D19916 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D19927: Fix DW_AT_specification handling in DWO files

2016-05-04 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, tberghammer. labath added subscribers: ovyalov, lldb-commits. We were trying to get a DWARFDIE from a CompileUnit belonging to a DWO file. However, this function does not understand the die encoding used by the DWO files. Instead us

Re: [Lldb-commits] [PATCH] D19927: Fix DW_AT_specification handling in DWO files

2016-05-04 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. LGTM http://reviews.llvm.org/D19927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r268545 - Update for llvm change to add pdb namespace.

2016-05-04 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed May 4 15:33:53 2016 New Revision: 268545 URL: http://llvm.org/viewvc/llvm-project?rev=268545&view=rev Log: Update for llvm change to add pdb namespace. r268544 moves all PDB reading code into a pdb namespace, so LLDB needs to be updated to take this into account. Modif

Re: [Lldb-commits] [PATCH] D19751: Fix TestEnumTypes.py for 32 bit platforms.

2016-05-04 Thread Adrian McCarthy via lldb-commits
amccarth added a subscriber: amccarth. amccarth added a comment. Chaoren: Did this completely fix the test for you? It's still failing for me on Windows, but for a reason not addressed here. Repository: rL LLVM http://reviews.llvm.org/D19751 _

[Lldb-commits] [lldb] r268559 - Intentionally leak the ASTSourceMap instead of destroying it when LLDB quits.

2016-05-04 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed May 4 16:42:55 2016 New Revision: 268559 URL: http://llvm.org/viewvc/llvm-project?rev=268559&view=rev Log: Intentionally leak the ASTSourceMap instead of destroying it when LLDB quits. Modified: lldb/trunk/source/Symbol/ClangExternalASTSourceCommon.cpp Modified: l

Re: [Lldb-commits] [PATCH] D19751: Fix TestEnumTypes.py for 32 bit platforms.

2016-05-04 Thread Chaoren Lin via lldb-commits
chaoren added a subscriber: chaoren. chaoren added a comment. We don't test host-only Windows. It's passing Windows to Android though. What's the reason that it fails on Windows? Repository: rL LLVM http://reviews.llvm.org/D19751 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D19751: Fix TestEnumTypes.py for 32 bit platforms.

2016-05-04 Thread Chaoren Lin via lldb-commits
We don't test host-only Windows. It's passing Windows to Android though. What's the reason that it fails on Windows? On Wed, May 4, 2016 at 2:31 PM, Adrian McCarthy wrote: > amccarth added a subscriber: amccarth. > amccarth added a comment. > > Chaoren: Did this completely fix the test for you?

Re: [Lldb-commits] [PATCH] D19751: Fix TestEnumTypes.py for 32 bit platforms.

2016-05-04 Thread Adrian McCarthy via lldb-commits
amccarth added a comment. The test expects `expr *f.op` to fail because f is a null pointer, but on Windows it yields `(ops) $2 = 0`. I suspect this is a latent expression evaluation bug exposed by the new test, as it also happens for other types of pointers and not just pointers to enums. R

[Lldb-commits] [lldb] r268562 - Fixed a missing break and fixed spacing.

2016-05-04 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed May 4 17:14:55 2016 New Revision: 268562 URL: http://llvm.org/viewvc/llvm-project?rev=268562&view=rev Log: Fixed a missing break and fixed spacing. Modified: lldb/trunk/source/Core/Scalar.cpp Modified: lldb/trunk/source/Core/Scalar.cpp URL: http://llvm.org/viewv

[Lldb-commits] [lldb] r268563 - Don't let two threads call Debugger::Clear simultaneously.

2016-05-04 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed May 4 17:26:42 2016 New Revision: 268563 URL: http://llvm.org/viewvc/llvm-project?rev=268563&view=rev Log: Don't let two threads call Debugger::Clear simultaneously. We don't want a mutex in debugger as it will cause A/B locking issues with the lldb_private::Target's

[Lldb-commits] [lldb] r268566 - Unblock the windows buildbot.

2016-05-04 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed May 4 17:41:32 2016 New Revision: 268566 URL: http://llvm.org/viewvc/llvm-project?rev=268566&view=rev Log: Unblock the windows buildbot. Modified: lldb/trunk/include/lldb/Core/Debugger.h Modified: lldb/trunk/include/lldb/Core/Debugger.h URL: http://llvm.org/view

[Lldb-commits] [lldb] r268520 - Fix a SIGSEGV caused by dereferencing a pointer without a null check

2016-05-04 Thread Bryan Chan via lldb-commits
Author: bryanpkc Date: Wed May 4 12:24:31 2016 New Revision: 268520 URL: http://llvm.org/viewvc/llvm-project?rev=268520&view=rev Log: Fix a SIGSEGV caused by dereferencing a pointer without a null check Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp Modified: lldb

[Lldb-commits] [PATCH] D19943: XFail TestEnumTypes.py on Windows

2016-05-04 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Dereferencing a null pointer in an `expr` "works" on Windows. I believe that's a long-standing problem that's just been exposed by the reworking of this test last week. The rest of th

[Lldb-commits] [lldb] r268573 - XFail TestLambdas.py on Windows after fixing some of the problems

2016-05-04 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Wed May 4 18:32:35 2016 New Revision: 268573 URL: http://llvm.org/viewvc/llvm-project?rev=268573&view=rev Log: XFail TestLambdas.py on Windows after fixing some of the problems 1. Fixed semicolon placement in the lambda in the test itself. 2. Fixed lldbinline tests in gen

Re: [Lldb-commits] [PATCH] D19606: XFail TestLambdas.py on Windows after fixing some of the problems

2016-05-04 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL268573: XFail TestLambdas.py on Windows after fixing some of the problems (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19606?vs=55263&id=56221#toc Repository: rL LLVM ht

[Lldb-commits] [lldb] r268574 - XFail TestEnumTypes.py on Windows

2016-05-04 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Wed May 4 18:33:19 2016 New Revision: 268574 URL: http://llvm.org/viewvc/llvm-project?rev=268574&view=rev Log: XFail TestEnumTypes.py on Windows Differential Revision: http://reviews.llvm.org/D19943 Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/enum_types

Re: [Lldb-commits] [PATCH] D19943: XFail TestEnumTypes.py on Windows

2016-05-04 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL268574: XFail TestEnumTypes.py on Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19943?vs=56216&id=56222#toc Repository: rL LLVM http://reviews.llvm.org/D19943 Fi

[Lldb-commits] [lldb] r268587 - Make the functions that fetch data from the ObjC runtime choose whether or not to log depending on whether the types log is enabled

2016-05-04 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed May 4 20:15:57 2016 New Revision: 268587 URL: http://llvm.org/viewvc/llvm-project?rev=268587&view=rev Log: Make the functions that fetch data from the ObjC runtime choose whether or not to log depending on whether the types log is enabled This can prove helpful in debug

[Lldb-commits] [lldb] r268591 - Allow LanguageRuntimes to return an error if they fail in the course of dynamic type discovery

2016-05-04 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed May 4 20:47:44 2016 New Revision: 268591 URL: http://llvm.org/viewvc/llvm-project?rev=268591&view=rev Log: Allow LanguageRuntimes to return an error if they fail in the course of dynamic type discovery This is not meant to report that a value doesn't have a dynamic type