emaste added inline comments.
Comment at: include/lldb/Host/Editline.h:33
@@ -31,3 +32,3 @@
// components needed to handle wide characters ( , codecvt_utf8,
libedit built with '--enable-widec' )
-// are not consistenly available on non-OSX platforms. The wchar_t versions
of li
tfiala created this revision.
tfiala added reviewers: labath, zturner.
tfiala added subscribers: lldb-commits, zturner.
This change enhances the LLDB test infrastructure to convert
load-time exceptions in a given Python test module into errors.
Before this change, specifying a non-existent test de
krytarowski created this revision.
krytarowski added reviewers: emaste, clayborg.
krytarowski added subscribers: lldb-commits, joerg.
krytarowski set the repository for this revision to rL LLVM.
The editline(3) library in NetBSD is by default internally wide.
Repository:
rL LLVM
http://reviews
Author: ted
Date: Wed May 11 17:46:53 2016
New Revision: 269250
URL: http://llvm.org/viewvc/llvm-project?rev=269250&view=rev
Log:
Keep original source path and mapped path in LineEntry
Summary:
The "file" variable in a LineEntry was mapped using target.source-map, except
when stepping through in
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15067#427834, @krytarowski wrote:
> In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote:
>
> > I would like to see implemented my comment about LLVM_CONFIG and
> > find_program().
>
>
> Could you first push this to clang? I
krytarowski added a comment.
In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote:
> I would like to see implemented my comment about LLVM_CONFIG and
> find_program().
Could you first push this to clang? I don't want to drift from clang myself.
Repository:
rL LLVM
http://review
Eugene.Zelenko added a comment.
I would like to see implemented my comment about LLVM_CONFIG and find_program().
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
krytarowski added a comment.
Updated. Can I commit it this way as it is?
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski retitled this revision from "Design building out of sources" to
"Add CMake bits necessary for standalone build".
krytarowski updated this revision to Diff 56970.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
Files:
cmake/modules/LLDBStandalone.cmake
scripts/CMakeLists.txt
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks good to me.
http://reviews.llvm.org/D20135
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
ted updated this revision to Diff 56967.
ted marked an inline comment as done.
ted added a comment.
Addressed Jim's comments.
Make BreakpointResolver check both original and mapped files.
Changed ThreadPlanStepOverRange line 235 to use original_file.
Changed "struct SourceInfo" operators in Comma
tfiala added a comment.
Oh right, I recall there was an action item on me.
I'll catch up with you on that in a bit.
http://reviews.llvm.org/D19998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
aprantl added a comment.
I still need some expertise on how to disable the configuration on platforms
with older versions of clang (or different compilers like gcc).
http://reviews.llvm.org/D19998
___
lldb-commits mailing list
lldb-commits@lists.ll
tfiala added a comment.
Hi Adrian,
I think this has stalled. What do we need to resolve now?
http://reviews.llvm.org/D19998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269205: Generalize child process monitoring functions
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D20106?vs=56903&id=56932#toc
Repository:
rL LLVM
http://reviews.llvm.org/
Author: labath
Date: Wed May 11 11:59:04 2016
New Revision: 269205
URL: http://llvm.org/viewvc/llvm-project?rev=269205&view=rev
Log:
Generalize child process monitoring functions
Summary:
This replaces the C-style "void *" baton of the child process monitoring
functions with a more
C++-like API
krytarowski added a comment.
In http://reviews.llvm.org/D15067#419964, @labath wrote:
> Good question. I don't really have an opinion on that... Is it just that
> single line? (this would be simpler if you uploaded the final version :) ).
> If it just that single line, then I think it's fine. I
krytarowski added a comment.
I'm going to test NetBSD.
http://reviews.llvm.org/D20106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Hmm.. So you actually needed to insert the additional "continue"
command. That is not good. I was hoping it would be enough to just
remove the strict check for the location numbers.
Working around it this way is quite ugly. Let's try something else.
Would getting rid of the do{}while loop in the m
On 11 May 2016 at 10:10, Pavel Labath wrote:
> Hi,
>
> so I think this is our old "compiler generates unpredictable number of
> source locations for a line" friend again, which got triggered by a
> random code reshuffle. Assuming the test still passes for you after
> that, can you prepare a change
Hi,
so I think this is our old "compiler generates unpredictable number of
source locations for a line" friend again, which got triggered by a
random code reshuffle. Assuming the test still passes for you after
that, can you prepare a change to remove the "num_expected_locations =
1" from the rele
Author: omjavaid
Date: Wed May 11 08:57:20 2016
New Revision: 269187
URL: http://llvm.org/viewvc/llvm-project?rev=269187&view=rev
Log:
Xfail failing watchpoint tests on aarch64-linux
Some watchpoint tests fail on aarch64-linux as it lacks support for intalling
watchpoints which are not alligned
labath updated this revision to Diff 56903.
labath marked 3 inline comments as done.
labath added a comment.
Herald added a subscriber: emaste.
Remove the typedef and add changes to windows, osx, and freebsd-specific code.
I didn't
try building NetBSD, but given that there is no Plugins/Process/N
labath added a comment.
In http://reviews.llvm.org/D20106#426224, @zturner wrote:
> It's too bad llvm doesn't have an equivalent of boost::any, because that
> would be perfect here :-/
I actually think that a `std::function` is better here than an `any` type
because it ensures type safety (ev
nitesh.jain closed this revision.
nitesh.jain added a comment.
Commited in revision 269181
Repository:
rL LLVM
http://reviews.llvm.org/D18858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: slthakur
Date: Wed May 11 08:08:29 2016
New Revision: 269181
URL: http://llvm.org/viewvc/llvm-project?rev=269181&view=rev
Log:
[LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI
Patch by Nitesh Jain.
Summary: The ArchSpec::m_flags will be set based on ELF flag ABI.
Reviewer
nitesh.jain updated this revision to Diff 56891.
nitesh.jain added a comment.
Added IsMIPS() method.
Repository:
rL LLVM
http://reviews.llvm.org/D18858
Files:
include/lldb/Core/ArchSpec.h
source/Core/ArchSpec.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
Index: source/Plugins/Ob
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269168: Rewriting TestMultithreaded.py to solve flakyness on
Linux (authored by ravitheja).
Changed prior to commit:
http://reviews.llvm.org/D20091?vs=56671&id=56870#toc
Repository:
rL LLVM
http://r
Author: ravitheja
Date: Wed May 11 04:54:41 2016
New Revision: 269168
URL: http://llvm.org/viewvc/llvm-project?rev=269168&view=rev
Log:
Rewriting TestMultithreaded.py to solve flakyness on Linux
Summary:
test_listener_event_process_state checks for Threads
and Frames in the multithreaded_queue. T
ravitheja added a comment.
@labath, Well the other tests in TestMultithreaded.py are not flaky and I see
the only difference as an extra push operation, so I thought the push operation
could be potential bottleneck.
http://reviews.llvm.org/D20091
labath accepted this revision.
labath added a comment.
I am somewhat surprised that this solves anything (I mean, you claim that the
problem is the ordering between the push and pop, but I don't see how this
could change that ordering). If the problem was that the check_listener was not
waiting
Author: omjavaid
Date: Wed May 11 04:29:14 2016
New Revision: 269164
URL: http://llvm.org/viewvc/llvm-project?rev=269164&view=rev
Log:
Corrected aarch64 register no in TestBreakpointConditions.py
Test uses x1 in breakpoint expression while objdump shows that x1 is never used
in the code and may
32 matches
Mail list logo
