krytarowski created this revision.
krytarowski added reviewers: joerg, emaste, clayborg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
NetBSD 7.0 ships with too old libstdc++ and it lacks .
It's no longer true in the current version --
> On May 12, 2016, at 3:58 PM, Greg Clayton via lldb-commits
> wrote:
>
> +class EventDataReceipt : public EventData
> +{
> +public:
> +EventDataReceipt() :
> +EventData(),
> +m_predicate(false)
> +{
> +}
> +
> +~EventDataReceipt() override
> +{
> +}
> +
Author: enrico
Date: Thu May 12 18:04:43 2016
New Revision: 269378
URL: http://llvm.org/viewvc/llvm-project?rev=269378&view=rev
Log:
Add a check for version 15 of the shared cache format
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Modi
Author: gclayton
Date: Thu May 12 17:58:52 2016
New Revision: 269377
URL: http://llvm.org/viewvc/llvm-project?rev=269377&view=rev
Log:
Fix some long standing issues that caused tests to be flaky.
The main issues were:
- Listeners recently were converted over to used by getting a shared pointer t
I added the makefile with r269366. The tests seem to be working now:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14641
Sorry about that!
On Thu, May 12, 2016 at 6:07 PM, Cameron wrote:
> Thanks Jim, I'll definitely use that as a template next time!
>
> Ah, I think I f
Author: gclayton
Date: Thu May 12 17:36:47 2016
New Revision: 269373
URL: http://llvm.org/viewvc/llvm-project?rev=269373&view=rev
Log:
Don't crash when a process' task port goes bad.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/MachException.cpp
Modified: lldb/trunk/tools/debugser
Author: gclayton
Date: Thu May 12 17:33:02 2016
New Revision: 269372
URL: http://llvm.org/viewvc/llvm-project?rev=269372&view=rev
Log:
Fix libstdc++ failure where is not able to be imported on Darwin
systems.
The adding of to test_common.h broke 12 tests on Darwin. We work
around this by not
Author: cameron314
Date: Thu May 12 17:10:16 2016
New Revision: 269366
URL: http://llvm.org/viewvc/llvm-project?rev=269366&view=rev
Log:
Added missing makefile from patch D19124 (should fix the corresponding commit
rL269340)
Added:
lldb/trunk/packages/Python/lldbsuite/test/expression_comman
Thanks Jim, I'll definitely use that as a template next time!
Ah, I think I found the problem with the test. The makefile was in the
patch but wasn't committed. Trying that out now.
On Thu, May 12, 2016 at 5:45 PM, Jim Ingham wrote:
>
> > On May 12, 2016, at 2:25 PM, Cameron wrote:
> >
> > Sor
> On May 12, 2016, at 2:25 PM, Cameron wrote:
>
> Sorry to break the build! Apparently 'make clean' isn't executing cleanly
> during the build step of the test, but I haven't the faintest idea why. It
> builds/runs fine locally for me (then again, I'm on Windows). The makefile is
> dead simpl
tfiala added a comment.
In http://reviews.llvm.org/D20193#428971, @zturner wrote:
> I had to leave early today, can I check it tomorrow?
Sure, sounds good.
http://reviews.llvm.org/D20193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
Sorry to break the build! Apparently 'make clean' isn't executing cleanly
during the build step of the test, but I haven't the faintest idea why. It
builds/runs fine locally for me (then again, I'm on Windows). The makefile
is dead simple, and is identical to that of some other tests. Has anyone
se
I had to leave early today, can I check it tomorrow?
On Thu, May 12, 2016 at 2:10 PM Todd Fiala wrote:
> tfiala marked an inline comment as done.
> tfiala added a comment.
>
> @Zturner I think this is ready to go now. Can you give this a try on
> Windows?
>
> Also, can you try the following part
Note that while adding a "expr --allow-jit" flag to control this was great,
there already was an SBExpressionOptions option and the appropriate flags
available for this, so it was testable. I was just checking because there
really shouldn't be anything we can do from a command that we can't do
tfiala marked an inline comment as done.
tfiala added a comment.
@Zturner I think this is ready to go now. Can you give this a try on Windows?
Also, can you try the following part in cmd.exe?
cd packages\Python\lldbsuite\test_event
python -m unittest discover -s test\src -p 'Test*.py'
That
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
Looks like this CL broke CMake build bot -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14634,
could you take a look?
Repository:
rL LLVM
http://reviews.llvm.org/D19124
__
krytarowski resigned from this revision.
krytarowski removed a reviewer: krytarowski.
krytarowski added a comment.
This patch looks dead -- no activity.
Repository:
rL LLVM
http://reviews.llvm.org/D14182
___
lldb-commits mailing list
lldb-commits
Author: mamai
Date: Thu May 12 15:00:53 2016
New Revision: 269340
URL: http://llvm.org/viewvc/llvm-project?rev=269340&view=rev
Log:
[LLDB] Added support for PHI nodes to IR interpreter
This allows expressions such as 'i == 1 || i == 2` to be executed using the IR
interpreter, instead of relying
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269340: [LLDB] Added support for PHI nodes to IR interpreter
(authored by mamai).
Changed prior to commit:
http://reviews.llvm.org/D19124?vs=54134&id=57093#toc
Repository:
rL LLVM
http://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269332: Add CMake bits necessary for standalone build
(authored by kamil).
Changed prior to commit:
http://reviews.llvm.org/D15067?vs=56970&id=57091#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: kamil
Date: Thu May 12 14:49:17 2016
New Revision: 269332
URL: http://llvm.org/viewvc/llvm-project?rev=269332&view=rev
Log:
Add CMake bits necessary for standalone build
Summary: Developed on NetBSD with pkgsrc.
Reviewers: zturner, labath
Subscribers: jevinskie, zturner, tfiala, Eugene.
tfiala updated this revision to Diff 57090.
tfiala added a comment.
Now addresses the remaining review comment from Pavel. ResultsFormatter
instances are now told if their file is a stream rather than a block/char file.
The pickling formatter uses two different serializers, one for streaming an
Author: kamil
Date: Thu May 12 14:46:08 2016
New Revision: 269330
URL: http://llvm.org/viewvc/llvm-project?rev=269330&view=rev
Log:
Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD
Summary: The editline(3) library in NetBSD is by default internally wide.
Reviewers: clayborg, emaste
Subscribers: joerg,
tfiala marked 4 inline comments as done.
Comment at: packages/Python/lldbsuite/test/dotest.py:725
@@ +724,3 @@
+test_filename = os.path.abspath(os.path.join(dir, name))
+if test_filename.endswith(".pyc"):
+test_filena
tfiala updated this revision to Diff 57087.
tfiala added a comment.
Adjust last patch to include full context.
http://reviews.llvm.org/D20193
Files:
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/issue_verification/TestInvalidDecorator.py.park
packages/Python/lldb
tfiala updated this revision to Diff 57084.
tfiala added a comment.
Address most of Pavel's review comments.
New:
- Also catches multiple matching base names and converts that to a caught test
error.
Comments from Pavel not covered:
- Modifying the dual behavior of the pickling results format
labath added inline comments.
Comment at: packages/Python/lldbsuite/test_event/formatter/pickled.py:57
@@ +56,3 @@
+# end.
+if self.use_send:
+# Send it as
{serialized_length_of_serialized_bytes}{serialized_bytes}
tfiala wrote:
> tfial
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15067#428146, @krytarowski wrote:
> @Eugene.Zelenko do you agree with this patch and what @labath wrote?
If CMake works that way, it's what I need :-)
Repository:
rL LLVM
http://reviews.llvm.org/D15067
_
tfiala added a comment.
In http://reviews.llvm.org/D20193#428364, @zturner wrote:
> I will look at this in more detail later, but hold off on committing until
> i have a chance to run it on Windows
Hi Zachary.
No worries - I need to update the patch. Pavel caught one thing in the test
for t
I will look at this in more detail later, but hold off on committing until
i have a chance to run it on Windows
On Thu, May 12, 2016 at 8:05 AM Todd Fiala wrote:
> tfiala added inline comments.
>
>
> Comment at: packages/Python/lldbsuite/test_event/formatter/pickled.py:57
> @@ +5
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/test_event/formatter/pickled.py:57
@@ +56,3 @@
+# end.
+if self.use_send:
+# Send it as
{serialized_length_of_serialized_bytes}{serialized_bytes}
tfiala wrote:
> labat
tfiala added a comment.
I'll make some adjustments per your review, Pavel. Thanks! I'll put up
another patch set at that point.
Comment at: packages/Python/lldbsuite/test/dotest.py:695
@@ -694,3 +694,3 @@
# Try to match the regexp pattern, if specified.
On 11 May 2016 at 11:39, Pavel Labath wrote:
>
> Working around it this way is quite ugly. Let's try something else.
> Would getting rid of the do{}while loop in the macro fix the problem?
> I added it to make the macro a bit more safe, but I don't think it's
> really necessary...
Indeed, the tes
emaste accepted this revision.
emaste added a comment.
Thanks.
(The reason I mentioned it is that I'll add __FreeBSD__ shortly.)
http://reviews.llvm.org/D20188
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: labath
Date: Thu May 12 06:10:01 2016
New Revision: 269281
URL: http://llvm.org/viewvc/llvm-project?rev=269281&view=rev
Log:
Fix a race in ProcessGDBRemote::MonitorDebugServerProcess
Summary:
MonitorDebugServerProcess went to a lot of effort to make sure its asynchronous
invocation does
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269281: Fix a race in
ProcessGDBRemote::MonitorDebugServerProcess (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D20107?vs=56722&id=57016#toc
Repository:
rL LLVM
http://revie
krytarowski added a comment.
@Eugene.Zelenko do you agree with this patch and what @labath wrote?
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
labath accepted this revision.
labath added a comment.
In http://reviews.llvm.org/D15067#427848, @Eugene.Zelenko wrote:
> In http://reviews.llvm.org/D15067#427834, @krytarowski wrote:
>
> > In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote:
> >
> > > I would like to see implemented
krytarowski removed rL LLVM as the repository for this revision.
krytarowski updated this revision to Diff 57011.
http://reviews.llvm.org/D20188
Files:
include/lldb/Host/Editline.h
Index: include/lldb/Host/Editline.h
===
--- inclu
krytarowski added a comment.
I changed the string to "some platforms".
http://reviews.llvm.org/D20188
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
I'm glad to see this getting fixed. I have a couple comments though. :)
Comment at: packages/Python/lldbsuite/test/dotest.py:695
@@ -694,3 +694,3 @@
# Try to match the regexp pattern, if specified.
if configuration.regexp:
41 matches
Mail list logo
