tfiala added a comment.
Okay I had a look now. Just one comment on the code (inline), just for
consideration. Other than that, LGTM.
Comment at: packages/Python/lldbsuite/test/dotest_args.py:73
@@ -72,2 +72,3 @@
group.add_argument('-s', metavar='name', help='Specify the
tfiala added a comment.
Hi Zachary,
I'll have a look at this first thing in the morning!
-Todd
http://reviews.llvm.org/D20306
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
compnerd added a comment.
If you can run the test that would be wonderful. Im going to upload a slight
update to this tonight that catches a few more of the trivial cases. I think
minimizing the second pass is ideal since that is going to be much more
involved (changing APIs and such).
http
If you haven't or can't run it on Windows, then give me a chance to test it
on Windows before you commit. I can do it tomorrow unless you are set up
to do it instead.
On Mon, May 16, 2016 at 6:13 PM Saleem Abdulrasool
wrote:
> compnerd added a comment.
>
> I ran it on Darwin while I was working
zturner added a comment.
If you haven't or can't run it on Windows, then give me a chance to test it
on Windows before you commit. I can do it tomorrow unless you are set up
to do it instead.
http://reviews.llvm.org/D20278
___
lldb-commits mailing
compnerd added a comment.
I ran it on Darwin while I was working on this. Ill run it on Linux once
before I commit the first pass.
http://reviews.llvm.org/D20278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
zturner added a comment.
Which platforms did you run the test suite on?
http://reviews.llvm.org/D20278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
compnerd added a comment.
Zach is correct, this doesn't *remove* the Mutex and Condition types, merely
starts reducing the easier uses of it.
My thinking is to do this piecemeal, slowly reducing the local usage until the
real uses remain in the cases where we need to actually change the structu
sas created this revision.
sas added a reviewer: spyffe.
sas added a subscriber: lldb-commits.
Without this commit, when `log enable lldb expr` is enabled, the
disassembly of JIT'ed code is never displayed.
http://reviews.llvm.org/D20312
Files:
source/Expression/IRExecutionUnit.cpp
Index: sou
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269713: Look for CMake.app when searching for cmake
(authored by tfiala).
Changed prior to commit:
http://reviews.llvm.org/D20303?vs=57404&id=57412#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2
Author: tfiala
Date: Mon May 16 17:29:15 2016
New Revision: 269713
URL: http://llvm.org/viewvc/llvm-project?rev=269713&view=rev
Log:
Look for CMake.app when searching for cmake
On OS X systems, look for /Applications/CMake.app and ~/Applications/CMake.app
versions of the cmake command line binary
zturner created this revision.
zturner added reviewers: labath, tfiala.
zturner added a subscriber: lldb-commits.
I'm trying to get the LLDB buildbot to run tests, and currently the issue is
that many tests fail when trying to write the session log file. The build
directory on the buildbot is a
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
http://reviews.llvm.org/D20303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
tfiala created this revision.
tfiala added a reviewer: spyffe.
tfiala added a subscriber: lldb-commits.
On OS X systems, look for /Applications/CMake.app and ~/Applications/CMake.app
versions of the cmake command line binary when trying harder to find a cmake
not on the system path.
http://revi
Author: gclayton
Date: Mon May 16 16:14:44 2016
New Revision: 269707
URL: http://llvm.org/viewvc/llvm-project?rev=269707&view=rev
Log:
Make sure we notify that the section module was loaded when
SBTarget::SetSectionLoadAddress() is called. Also make sure that the section
module is unloaded when
krytarowski added a comment.
> Does remote debugging interest you?
Yes.
However, on the other hand it's low priority for me right now. I will rebase to
FreeBSD once I will get improved system support in ptrace(2) and functional
process/core instrumentation.
Repository:
rL LLVM
http://rev
Author: spyffe
Date: Mon May 16 16:11:21 2016
New Revision: 269704
URL: http://llvm.org/viewvc/llvm-project?rev=269704&view=rev
Log:
Fixed and re-enabled the Clang modules testcase.
Macros work again after Clang r269554. This testcase just needed some small
tweaks to get it going again.
Modifie
Hello everyone,
Below are some buildbot numbers for the last week of 5/08/2016 - 5/14/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
Author: spyffe
Date: Mon May 16 15:55:10 2016
New Revision: 269698
URL: http://llvm.org/viewvc/llvm-project?rev=269698&view=rev
Log:
Test diamond virtual inheritance in top-level expressions.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/test.cpp
Modified:
Hello everyone,
I am cleaning zorg a little and going to remove the next builder modules
since they are not in use for a long time now:
If anyone have plans for any of them please speak up!
ChrootSetup.py
DragonEggBuilder.py
KLEEBuilder.py
ScriptedBuilder.py
gccSuiteBuilder.py
Thanks
Galina
___
Author: gclayton
Date: Mon May 16 15:07:38 2016
New Revision: 269686
URL: http://llvm.org/viewvc/llvm-project?rev=269686&view=rev
Log:
Don't crash when OS plug-in returns None from any of the functions we might
call.
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInte
emaste added a comment.
In http://reviews.llvm.org/D20274#431058, @clayborg wrote:
> What linux and macosx do is even when debugging locally we run through
> lldb-server (a GDB remote protocol server).
And this is the way we plan to go on FreeBSD as well and will drop the
in-process debugging
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. We should work toward remove Mutex.cpp and Mutex.h completely and
also switch over to using std::condition_variable.
http://reviews.llvm.org/D20278
Author: enrico
Date: Mon May 16 12:27:26 2016
New Revision: 269673
URL: http://llvm.org/viewvc/llvm-project?rev=269673&view=rev
Log:
Make LLDB print out an explicit marker when it's displaying formatters that are
part of a disabled category
Fixes rdar://26202006
Modified:
lldb/trunk/packa
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
If you want remote debugging, you should actually implement the lldb-server
code and not do a native Process plug-in. What linux and macosx do is even when
debugging locally we r
zturner added a comment.
To be clear, I don't think this patch actually deletes LLDB's mutex. It just
deletes uses of LLDB's mutex. So the NetBSD code should continue to work after
merging this patch in. Sure it introduces another use of lldb's Mutex, but we
can always remove that later. 5
stigger added a comment.
Friendly ping.
http://reviews.llvm.org/D20041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Mon May 16 06:41:36 2016
New Revision: 269648
URL: http://llvm.org/viewvc/llvm-project?rev=269648&view=rev
Log:
Bump up adb timeout more
still seeing very rare timeouts on the buildbot.
Modified:
lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
Modified: lldb/tr
Author: omjavaid
Date: Mon May 16 06:21:49 2016
New Revision: 269647
URL: http://llvm.org/viewvc/llvm-project?rev=269647&view=rev
Log:
Xfail TestCrashDuringStep and TestCreateDuringInstructionStep on arm-linux
Both of above tests fail on arm and bugs have been reported on android already.
Adding
Author: labath
Date: Mon May 16 04:18:30 2016
New Revision: 269640
URL: http://llvm.org/viewvc/llvm-project?rev=269640&view=rev
Log:
Remove Mutex from NativeProcessLinux
NPL now assumes it is running from a single thread now, so its thread-safety is
untested
anyway (and if that assumption is bro
labath added a subscriber: labath.
labath added a comment.
In http://reviews.llvm.org/D20278#430658, @krytarowski wrote:
> Looks good, however could we merge firstly Plugins/Process/NetBSD
> http://reviews.llvm.org/D20274 ? Otherwise I will need to keep syncing my
> patch forever for generic ch
krytarowski added a comment.
There is `Mutex::` used in my code. And it's going to be removed soon.
http://reviews.llvm.org/D20278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Looking at the 2 patches, they seem to be completely independent of each
other. Would this patch going in break you somehow?
http://reviews.llvm.org/D20278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
Looking at the 2 patches, they seem to be completely independent of each
other. Would this patch going in break you somehow?
On Mon, May 16, 2016 at 12:02 AM Kamil Rytarowski wrote:
> krytarowski added a subscriber: krytarowski.
> krytarowski added a comment.
>
> Looks good, however could we merg
krytarowski added a subscriber: krytarowski.
krytarowski added a comment.
Looks good, however could we merge firstly Plugins/Process/NetBSD
http://reviews.llvm.org/D20274 ? Otherwise I will need to keep syncing my patch
forever for generic changes.
Thanks!
http://reviews.llvm.org/D20278
__
35 matches
Mail list logo
