compnerd closed this revision.
compnerd marked an inline comment as done.
compnerd added a comment.
SVN r270024.
Repository:
rL LLVM
http://reviews.llvm.org/D20351
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: jmolenda
Date: Wed May 18 21:16:41 2016
New Revision: 270015
URL: http://llvm.org/viewvc/llvm-project?rev=270015&view=rev
Log:
Check that __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ is defined
before comparing the value of it.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/M
Author: jingham
Date: Wed May 18 21:13:44 2016
New Revision: 270014
URL: http://llvm.org/viewvc/llvm-project?rev=270014&view=rev
Log:
Fix error propagation from the Z0 packet in gdb-remote breakpoint setting.
The error was not getting propagated to the caller, so the higher layers
thought the br
compnerd marked 2 inline comments as done.
Comment at: source/Interpreter/CommandObject.cpp:339
@@ -338,3 +338,3 @@
m_exe_ctx.Clear();
-m_api_locker.Unlock();
+m_api_locker.unlock();
}
zturner wrote:
> ```
> if (m_api_locker)
> m_api_locker.unloc
Author: enrico
Date: Wed May 18 18:59:24 2016
New Revision: 270004
URL: http://llvm.org/viewvc/llvm-project?rev=270004&view=rev
Log:
Fix an issue where debugserver would not properly vend OS version information
on iOS devices
The __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED macro is only defined
spyffe added a comment.
Added a few inline comments to make the patch's intent more understandable.
Comment at: include/lldb/Symbol/ClangASTContext.h:1221
@@ -1220,3 +1214,2 @@
boolm_can_evaluate_expressions;
-std::map>
spyffe created this revision.
spyffe added reviewers: paulherman, sivachandra, jingham.
spyffe added a subscriber: lldb-commits.
spyffe set the repository for this revision to rL LLVM.
`m_decl_objects` is not sound when there are multiple instances of an inline
function. The reason is that the `
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269996: Fix standalone LLDB build, when LLVM/Clang were
built with… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D20344?vs=57648&id=57700#toc
Repository:
rL LLVM
htt
Author: eugenezelenko
Date: Wed May 18 17:50:08 2016
New Revision: 269996
URL: http://llvm.org/viewvc/llvm-project?rev=269996&view=rev
Log:
Fix standalone LLDB build, when LLVM/Clang were built with
LLVM_INSTALL_TOOLCHAIN_ONLY=ON.
Fix standalone build with CMake 2.8.12.2.
Differential revision:
krytarowski accepted this revision.
krytarowski added a comment.
It works for me.
Repository:
rL LLVM
http://reviews.llvm.org/D20344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
bryanpkc updated this revision to Diff 57695.
bryanpkc added a comment.
Added a unit test in ScalarTest.cpp that catches this particular error.
http://reviews.llvm.org/D20355
Files:
source/Core/Scalar.cpp
unittests/Core/ScalarTest.cpp
Index: unittests/Core/ScalarTest.cpp
==
krytarowski added a comment.
I'm going to test it now.
Repository:
rL LLVM
http://reviews.llvm.org/D20344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
omjavaid created this revision.
omjavaid added reviewers: labath, tberghammer.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, rengolin, aemerson.
This patch makes sure that we are using correct target specific ar and objcopy
executables.
I have added
Author: omjavaid
Date: Wed May 18 15:45:12 2016
New Revision: 269980
URL: http://llvm.org/viewvc/llvm-project?rev=269980&view=rev
Log:
xfail TestTopLevelExprs for arm and aarch64 linux
TestTopLevelExprs fails on arm and aarch64 linux similar to behaviour on
android.
A bug exists here: llvm.org/p
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks good on Windows with the two suggested fixes.
Comment at: source/Interpreter/CommandObject.cpp:339
@@ -338,3 +338,3 @@
m_exe_ctx.Clear();
-m_api_locker.Unlock
Eugene.Zelenko updated this revision to Diff 57648.
Eugene.Zelenko added a comment.
Add comments per Pavel suggestion.
Repository:
rL LLVM
http://reviews.llvm.org/D20344
Files:
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalone.cmake
===
uweigand added a comment.
This patch builds and works fine on s390x-linux.
http://reviews.llvm.org/D20368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
@nitesh.jain: I have checked that this compiles, but I could not verify the
functionality for lack of hardware. Could you give this a spin? I am
particularly interested in the "debugging 32 bit process with a 64 bit server"
use case as that is most likely to break. If it
labath created this revision.
labath added reviewers: tberghammer, omjavaid, nitesh.jain, uweigand.
labath added a subscriber: lldb-commits.
Herald added a subscriber: aemerson.
this removes the last usage of the Platform plugin in NPL. It was being used
for determining the
architecture of a runn
uweigand added a reviewer: jingham.
uweigand updated this revision to Diff 57617.
uweigand added a comment.
Ping? This fixes the last remaining test suite failure on s390x. I'd like to
get a clean test suite ...
Patch updated to current sources.
Added jingham since you touched that code recen
labath added a subscriber: labath.
labath added a reviewer: labath.
labath added a comment.
This fixes the same issue as http://reviews.llvm.org/D19535, which is stalled
at the moment waiting for a unit test. You can take over if you write a quick
unit test for this (unittests/Core/ScalarTest.cp
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me. Let's give others a chance to respond though.
Comment at: cmake/modules/LLDBStandalone.cmake:103
@@ -98,2 +102,3 @@
include("${LLVM_OBJ_ROOT}/lib${
bryanpkc created this revision.
bryanpkc added a reviewer: uweigand.
bryanpkc added a subscriber: lldb-commits.
One of the cases handled by ValueObjectChild::UpdateValue() uses the entire
width of the parent's scalar value as the size of the child, and extracts the
child by calling Scalar::Extra
23 matches
Mail list logo
