Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-05-20 Thread Zachary Turner via lldb-commits
zturner added a comment. I'm still getting a lot of crashes after this, but this will at least fix the compiler errors. I will try to look at the crashes on Monday. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:354-355 @@ -358,5 +353,4 @@ { -//

[Lldb-commits] [lldb] r270254 - Adopt mmap flags that allow mmap'ed memory to be less crash prone.

2016-05-20 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri May 20 14:18:20 2016 New Revision: 270254 URL: http://llvm.org/viewvc/llvm-project?rev=270254=rev Log: Adopt mmap flags that allow mmap'ed memory to be less crash prone. On Darwin if a mmap file is code signed and the code signature is invalid, it used to crash. If we

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-20 Thread Muhammad Omair Javaid via lldb-commits
omjavaid accepted this revision. omjavaid added a comment. Seems to be causing no regressions on arm-linux. http://reviews.llvm.org/D20368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D20416: [LLDB][MIPS] Fix floating point handling in case of thread step-out

2016-05-20 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. committed in revision 270207 Repository: rL LLVM http://reviews.llvm.org/D20416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r270207 - [LLDB][MIPS] Fix floating point handling in case of thread step-out

2016-05-20 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Fri May 20 07:07:27 2016 New Revision: 270207 URL: http://llvm.org/viewvc/llvm-project?rev=270207=rev Log: [LLDB][MIPS] Fix floating point handling in case of thread step-out Patch by Nitesh Jain. Summary: These patch fix thread step-out for hard and soft float.

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-20 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39 @@ +38,3 @@ +int regset = NT_PRSTATUS; +Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid, , , sizeof_native_regs_struct); +

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-20 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39 @@ +38,3 @@ +int regset = NT_PRSTATUS; +Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid, , , sizeof_native_regs_struct); +

Re: [Lldb-commits] [PATCH] D19535: Fix 2 LLVM assertion caoused by an API missues in Scalar

2016-05-20 Thread Tamas Berghammer via lldb-commits
tberghammer abandoned this revision. tberghammer added a comment. Abandoning. as http://reviews.llvm.org/rL270062 fixed the same issue before I managed to add a test for this CL. http://reviews.llvm.org/D19535 ___ lldb-commits mailing list