Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

labath accepted this revision. labath added a reviewer: labath. labath added a comment. Looks great now. Thanks. Comment at: packages/Python/lldbsuite/test/test_categories.py:62 @@ +61,3 @@ +if not gmodules.is_compiler_clang_with_gmodules(compiler_path): +

Re: [Lldb-commits] [PATCH] D20623: [cmake] Add ability to customize (and skip) debugserver codesign

This revision was automatically updated to reflect the committed changes. Closed by commit rL270832: [cmake] Add ability to customize (and skip) debugserver codesign (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20623?vs=58424&id=58580#toc Repository: rL LLVM http:

[Lldb-commits] [lldb] r270831 - Avoid using stdio in TestVirtual

Author: labath Date: Thu May 26 03:38:02 2016 New Revision: 270831 URL: http://llvm.org/viewvc/llvm-project?rev=270831&view=rev Log: Avoid using stdio in TestVirtual Summary: using stdio in tests does not work on windows, and it is not completely reliable on linux. Avoid using stdio in this test

[Lldb-commits] [lldb] r270832 - [cmake] Add ability to customize (and skip) debugserver codesign

Author: labath Date: Thu May 26 03:38:10 2016 New Revision: 270832 URL: http://llvm.org/viewvc/llvm-project?rev=270832&view=rev Log: [cmake] Add ability to customize (and skip) debugserver codesign Summary: This adds the ability to customize the debugserver codesign process via cmake cache varia

Re: [Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual

This revision was automatically updated to reflect the committed changes. Closed by commit rL270831: Avoid using stdio in TestVirtual (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20567?vs=58418&id=58579#toc Repository: rL LLVM http://reviews.llvm.org/D20567 Files

[Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

labath created this revision. labath added reviewers: tberghammer, tfiala, nitesh.jain, omjavaid, emaste, krytarowski. labath added a subscriber: lldb-commits. Recent increase in the usage of std::weak_ptr has caused us to rediscover an issue in libstdc++ versions prior to 4.9

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

labath added a comment. I am adding everyone I think could be susceptible to this problem. It would be a good idea to check if you are still using libstdc++4.8 or older. http://reviews.llvm.org/D20671 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

labath created this revision. labath added reviewers: zturner, tfiala. labath added a subscriber: lldb-commits. One can still use the LLVM variables to control this: LLVM_ENABLE_EH, LLVM_ENABLE_RTTI. It's not clear to me why one would want to control these at lldb level and it's generally not ev

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

labath added a comment. Zachary, Todd, you added these in http://reviews.llvm.org/D3929. I know it's a long time, but do you recall what was the original motivation for that? In light of the issue in http://reviews.llvm.org/D20671, I've experimenting with compiling lldb with exceptions enabled,

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

krytarowski added a comment. NetBSD is using newer libstdc++. #include std::set s = std::set(std::allocator()); int main() { return 0; } Compiles (I need to specify the -std=c++11 option) and runs. I will try it out in the context of LLDB CMake scripts. http://reviews.llvm.org/D20671

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

emaste added a comment. FreeBSD 10.0 and later uses libc++. FreeBSD 9 has a very old libstdc++ and a very old gcc and can't build Clang 3.5 or later with the system compiler anyway. So this isn't a problem for FreeBSD. I don't know cmake well enough to approve the change but the idea definitely

Re: [Lldb-commits] [lldb] r270745 - Mark some arm-linux specific xfails marking bug entries

Omair, please be careful about using arm xfails. You are using too wide annotations and disabling tests even on configurations where they are known to pass. On 25 May 2016 at 19:48, Omair Javaid via lldb-commits wrote: > Modified: > lldb/trunk/packages/Python/lldbsuite/test/expression_command/

[Lldb-commits] [lldb] r270848 - Add "-gmodules" support to the test suite.

Author: tfiala Date: Thu May 26 08:57:03 2016 New Revision: 270848 URL: http://llvm.org/viewvc/llvm-project?rev=270848&view=rev Log: Add "-gmodules" support to the test suite. This change adds the capability of building test inferiors with the -gmodules flag to enable module debug info support. W

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270848: Add "-gmodules" support to the test suite. (authored by tfiala). Changed prior to commit: http://reviews.llvm.org/D19998?vs=58459&id=58605#toc Repository: rL LLVM http://reviews.llvm.org/D19

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. looks good Comment at: cmake/modules/LLDBConfig.cmake:432 @@ +431,3 @@ +message(WARNING +"You appear to be using linking to libstdc++ version les

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

zturner added a subscriber: zturner. zturner added a comment. Wondering if this should go in llvm. What do you think? http://reviews.llvm.org/D20671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

Wondering if this should go in llvm. What do you think? On Thu, May 26, 2016 at 7:31 AM Tamas Berghammer via lldb-commits < lldb-commits@lists.llvm.org> wrote: > tberghammer accepted this revision. > tberghammer added a comment. > This revision is now accepted and ready to land. > > looks good > >

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

labath added a comment. In http://reviews.llvm.org/D20671#440868, @zturner wrote: > Wondering if this should go in llvm. What do you think? I don't see any uses of weak_ptr in the llvm repository, so this issue should only affect lldb, I think. http://reviews.llvm.org/D20671 _

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

zturner added a comment. Ok, lgtm then http://reviews.llvm.org/D20671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

Ok, lgtm then On Thu, May 26, 2016 at 7:46 AM Pavel Labath wrote: > labath added a comment. > > In http://reviews.llvm.org/D20671#440868, @zturner wrote: > > > Wondering if this should go in llvm. What do you think? > > > I don't see any uses of weak_ptr in the llvm repository, so this issue > sh

[Lldb-commits] [lldb] r270854 - [cmake] Add a big warning about a libstdc++ issue

Author: labath Date: Thu May 26 10:16:11 2016 New Revision: 270854 URL: http://llvm.org/viewvc/llvm-project?rev=270854&view=rev Log: [cmake] Add a big warning about a libstdc++ issue Summary: Recent increase in the usage of std::weak_ptr has caused us to rediscover an issue in libstdc++ versions

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

This revision was automatically updated to reflect the committed changes. Closed by commit rL270854: [cmake] Add a big warning about a libstdc++ issue (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20671?vs=58584&id=58616#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

tfiala added a comment. Having a look now. I don't recall the context yet. http://reviews.llvm.org/D20673 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

labath added a comment. In http://reviews.llvm.org/D20673#440660, @labath wrote: > Enabling this should not make any difference in the common case, as llvm > already adds one set of exception-disabling flags if you don't specify the > flag I mentioned (llvm/cmake/modules/AddLLVM.cmake). (And

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. This looks fine to me. ( http://reviews.llvm.org/D20671 also looked fine, looks like I missed looking at that yesterday). Since Zachary initially wanted this on Windows, I suspect he needs to

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

tfiala added a comment. In http://reviews.llvm.org/D20673#440967, @labath wrote: > In http://reviews.llvm.org/D20673#440660, @labath wrote: > > > Enabling this should not make any difference in the common case, as llvm > > already adds one set of exception-disabling flags if you don't specify th

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

Don't think this is needed anymore, lgtm On Thu, May 26, 2016 at 8:59 AM Todd Fiala wrote: > tfiala added a comment. > > In http://reviews.llvm.org/D20673#440967, @labath wrote: > > > In http://reviews.llvm.org/D20673#440660, @labath wrote: > > > > > Enabling this should not make any difference i

[Lldb-commits] [lldb] r270863 - [cmake] Remove the LLDB versions of the exception-controlling variables

Author: labath Date: Thu May 26 11:11:04 2016 New Revision: 270863 URL: http://llvm.org/viewvc/llvm-project?rev=270863&view=rev Log: [cmake] Remove the LLDB versions of the exception-controlling variables Summary: One can still use the LLVM variables to control this: LLVM_ENABLE_EH, LLVM_ENABLE_

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL270863: [cmake] Remove the LLDB versions of the exception-controlling variables (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20673?vs=58587&id=58630#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D20274: Add preliminary bits for Plugins/Process/NetBSD

krytarowski abandoned this revision. krytarowski added a comment. It no longer builds due to mutex refactoring. Remove as it will need to be redone for remote debugging. Repository: rL LLVM http://reviews.llvm.org/D20274 ___ lldb-commits mailing

[Lldb-commits] [lldb] r270869 - Guard against the C++ destructor chain by not letting the debugger list clean up after itself in the C++ destructor chain.

Author: gclayton Date: Thu May 26 11:51:23 2016 New Revision: 270869 URL: http://llvm.org/viewvc/llvm-project?rev=270869&view=rev Log: Guard against the C++ destructor chain by not letting the debugger list clean up after itself in the C++ destructor chain. If users call "static void lldb::SBDe

[Lldb-commits] [lldb] r270891 - Make sure that we succeed in starting a definition before we complete it and emit an error if we fail to start the definition.

Author: gclayton Date: Thu May 26 14:24:02 2016 New Revision: 270891 URL: http://llvm.org/viewvc/llvm-project?rev=270891&view=rev Log: Make sure that we succeed in starting a definition before we complete it and emit an error if we fail to start the definition. ClangASTContext::StartTagDeclarati

[Lldb-commits] [lldb] r270932 - With -gmodules, we have been having a harder time always finding a type when we need one.

Author: gclayton Date: Thu May 26 17:33:25 2016 New Revision: 270932 URL: http://llvm.org/viewvc/llvm-project?rev=270932&view=rev Log: With -gmodules, we have been having a harder time always finding a type when we need one. We have seen cases where we have been unable to find an argument type

[Lldb-commits] [lldb] r270938 - Don't cache the stret/vrs. non-stret code pointer as static data in the runtime.

Author: jingham Date: Thu May 26 18:49:49 2016 New Revision: 270938 URL: http://llvm.org/viewvc/llvm-project?rev=270938&view=rev Log: Don't cache the stret/vrs. non-stret code pointer as static data in the runtime. It belongs in the instance, since then when you change architectures it can be adj

[Lldb-commits] [lldb] r270939 - Lock the access to the BreakpointLocationCollection.

Author: jingham Date: Thu May 26 18:55:04 2016 New Revision: 270939 URL: http://llvm.org/viewvc/llvm-project?rev=270939&view=rev Log: Lock the access to the BreakpointLocationCollection. I was investigating an odd crash in lldb when the breakpoint site goes to bump the hit counts of the locations

[Lldb-commits] [lldb] r270941 - Add a new "lldb" log channel named "demangle". If we have crashes that are related to demangling, we now can enable this logging and we will be able to reproduce demang

Author: gclayton Date: Thu May 26 19:17:18 2016 New Revision: 270941 URL: http://llvm.org/viewvc/llvm-project?rev=270941&view=rev Log: Add a new "lldb" log channel named "demangle". If we have crashes that are related to demangling, we now can enable this logging and we will be able to reproduce

Re: [Lldb-commits] [lldb] r270941 - Add a new "lldb" log channel named "demangle". If we have crashes that are related to demangling, we now can enable this logging and we will be able to reproduce de

Just curious, is this related to the dump I sent you a while back? On Thu, May 26, 2016 at 5:23 PM Greg Clayton via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: gclayton > Date: Thu May 26 19:17:18 2016 > New Revision: 270941 > > URL: http://llvm.org/viewvc/llvm-project?rev=270941

Re: [Lldb-commits] [PATCH] D16861: Pass socket scheme as part of debug server listen URL

tfiala added a subscriber: tfiala. tfiala added a comment. This change broke connection to debugserver on OS X - the constructed URL on debugserver does not take the tcp:// (URL-scheme) portion. This would manifest when 'lldb-server platform' was attempting to launch debugserver. I'm going to

[Lldb-commits] [lldb] r270961 - fix up lldb-server platform on Apple hosts

Author: tfiala Date: Thu May 26 23:04:52 2016 New Revision: 270961 URL: http://llvm.org/viewvc/llvm-project?rev=270961&view=rev Log: fix up lldb-server platform on Apple hosts r259714 introduces the transport method into the URL passed to the gdb-remote stub. On debugserver, this is not supporte

[Lldb-commits] [PATCH] D20722: Implement ProcessInfo::Dump(), log gdb-remote stub launch

tfiala created this revision. tfiala added reviewers: clayborg, labath, ovyalov. tfiala added a subscriber: lldb-commits. This change implements dumping the executable, triple, args and environment when using ProcessInfo::Dump(). It also tweaks the way Args::Dump() works so that it prints a confi

Re: [Lldb-commits] [PATCH] D20722: Implement ProcessInfo::Dump(), log gdb-remote stub launch

tfiala added a comment. Hang on, this diff is busted. It seems to have a few more changes in it than came from me. (I suspect it is something slightly out of sync between my change branch and trunk... I'll re-upload as soon as I straighten that out). http://reviews.llvm.org/D20722 ___

Re: [Lldb-commits] [PATCH] D20722: Implement ProcessInfo::Dump(), log gdb-remote stub launch

tfiala updated this revision to Diff 58751. tfiala added a comment. Fixed up whatever my arcanist-foo did wrong on the initial 'arc diff' creation of the patch. (The diff I'm putting up is exactly what comes out of 'git diff origin/master', so not sure how this got mutated into the original dif