Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-13 Thread Jason Molenda via lldb-commits
jasonmolenda added a comment. Hi Ravi, sorry for not having time to look at this patch yet - I was out of the office Friday and was catching up on everything today. I'll look at this tomorrow. My initial reactions are to be a little worried. It sounds like you have functions that are

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-13 Thread Pavel Labath via lldb-commits
labath added a comment. I think this idea in general is more acceptable, but we'll need an OK from Jason on the details. Also, we should figure out a way to add a test for this. We should definitely add a more deterministic test and not rely on TestPrintStackTraces to check this

[Lldb-commits] [lldb] r272635 - Add support to PlatformRemoteiOS, PlatformRemoteAppleWatch, and

2016-06-13 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jun 13 22:49:13 2016 New Revision: 272635 URL: http://llvm.org/viewvc/llvm-project?rev=272635=rev Log: Add support to PlatformRemoteiOS, PlatformRemoteAppleWatch, and PlatformRemoteAppleTV to check the target.exec-search-paths directories for files after looking in the

Re: [Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

2016-06-13 Thread Pavel Labath via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. The overall change looks good, but please also add a test which specifically tests for watchpoints at unaligned addresses. Last time I checked, we all watchpoint tests were passing

Re: [Lldb-commits] [PATCH] D21152: Hunt for unused memory properly when dealing with processes that can tell us about memory mappings

2016-06-13 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM http://reviews.llvm.org/D21152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D21296: [lldb] Fixed race condition on private state thread exit, take 2

2016-06-13 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good if Jim is happy. http://reviews.llvm.org/D21296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D21296: [lldb] Fixed race condition on private state thread exit, take 2

2016-06-13 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a comment. This looks okay to me. http://reviews.llvm.org/D21296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D21296: [lldb] Fixed race condition on private state thread exit, take 2

2016-06-13 Thread Greg Clayton via lldb-commits
clayborg added a comment. Ok, as long as Jim agrees, then I will give it the go ahead. http://reviews.llvm.org/D21296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D21296: [lldb] Fixed race condition on private state thread exit, take 2

2016-06-13 Thread Cameron via lldb-commits
cameron314 added a comment. @clayborg: Thanks for having a look! I've added Jim Ingham as a reviewer. @jingham, I'd appreciate if you could take a few minutes to look this over. Right, I'd seen the backup/restore of the thread. As far as I can tell it should still work; the code in

Re: [Lldb-commits] [PATCH] D21296: [lldb] Fixed race condition on private state thread exit, take 2

2016-06-13 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. This looks like it would work for normal operation. I am not sure it will work when an extra private state thread is spun up. In certain circumstances we need to create more

Re: [Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

2016-06-13 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Does this patch handle being able to share an 8 byte watchpoint between two watchpoints? Lets say you have an 8 byte array named "a" and watch to watch a[0] and a[3] and a[7]. You should

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-13 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 60539. ravitheja added a comment. Checks for nullptr http://reviews.llvm.org/D21221 Files: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-13 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 60533. ravitheja added a comment. Making EH Frame CFI the full unwinder when artificial symbols are found. http://reviews.llvm.org/D21221 Files: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-06-13 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438 @@ +437,3 @@ +// The auxiliary vector consists of a sequence of key-value pairs, where key and value are of +// the pointer size for the architecture

[Lldb-commits] [PATCH] D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets

2016-06-13 Thread Muhammad Omair Javaid via lldb-commits
omjavaid created this revision. omjavaid added reviewers: labath, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer, rengolin, aemerson. This patch adds logic to make sure we can install watchpoints at 1,2 and 4 byte alligned addresses. ptrace

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-13 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Well its not possible for the assembly unwinder to do the correct thing in this situation , as the function is entered through a stub function (which has push instruction) and then a jump. The point of this patch is to catch when to use the CFI or the assembly