[Lldb-commits] [lldb] r273979 - fixits are apparently called fix-its.

2016-06-27 Thread Jim Ingham via lldb-commits
Author: jingham Date: Mon Jun 27 20:33:03 2016 New Revision: 273979 URL: http://llvm.org/viewvc/llvm-project?rev=273979=rev Log: fixits are apparently called fix-its. Modified: lldb/trunk/include/lldb/Expression/UserExpression.h lldb/trunk/scripts/interface/SBExpressionOptions.i

[Lldb-commits] [lldb] r273963 - Fixup the "shadow" example command to use the function that takes an execution context now that the @lldb.command decorator does the right thing for the command functio

2016-06-27 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Mon Jun 27 19:06:35 2016 New Revision: 273963 URL: http://llvm.org/viewvc/llvm-project?rev=273963=rev Log: Fixup the "shadow" example command to use the function that takes an execution context now that the @lldb.command decorator does the right thing for the command

[Lldb-commits] [lldb] r273960 - fix invalid assumption about the executable module in Target::Install()

2016-06-27 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Mon Jun 27 18:21:49 2016 New Revision: 273960 URL: http://llvm.org/viewvc/llvm-project?rev=273960=rev Log: fix invalid assumption about the executable module in Target::Install() Target::Install() was assuming the module at index 0 was the executable. This is often true, but

[Lldb-commits] [lldb] r273954 - Change PlatformDarwinKernel::GetSharedModule to be a little more

2016-06-27 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jun 27 17:48:05 2016 New Revision: 273954 URL: http://llvm.org/viewvc/llvm-project?rev=273954=rev Log: Change PlatformDarwinKernel::GetSharedModule to be a little more explicit in how it adds the kernel binary, to guard against the case where a kernel corefile might

[Lldb-commits] [PATCH] D21757: Fix lldb-mi disable/enable breakpoints commands

2016-06-27 Thread Fangliang Xue via lldb-commits
faxue created this revision. faxue added reviewers: abidh, ChuckR, jacdavis. faxue added a subscriber: lldb-commits. faxue set the repository for this revision to rL LLVM. 1) Make the enable breakpoint command actually enable 2) Remove unnecessary output from disable/enable command which isn't

[Lldb-commits] [PATCH] D21770: Improve ADB utilization within Android platform

2016-06-27 Thread Oleksiy Vyalov via lldb-commits
ovyalov created this revision. ovyalov added reviewers: labath, tberghammer. ovyalov added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. - Extract sync commands like push/pull file and stat into SyncService so ADB connection that's switched in sync mode can be

Re: [Lldb-commits] [PATCH] D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files.

2016-06-27 Thread Greg Clayton via lldb-commits
clayborg added a comment. This of course would rely on the fact that each Process subclass the overrides GetMemoryRegionInfo() will follow the following rules: 1 - if no memory is mapped for a given address, set an extra "not_mapped" variable in MemoryRegionInfo and provide the next address

Re: [Lldb-commits] [PATCH] D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files.

2016-06-27 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We shouldn't need to implement this on all process subclasses. Process::GetMemoryRegions(...) could just call the Process::GetMemoryRegionInfo() and fill the stuff in. We would

Re: [Lldb-commits] [PATCH] D21751: Implement GetMemoryRegions() for Linux and Mac OSX core files.

2016-06-27 Thread Howard Hellyer via lldb-commits
hhellyer updated this revision to Diff 61960. hhellyer added a comment. Squashing local commits. http://reviews.llvm.org/D21751 Files: include/lldb/Target/Process.h source/Plugins/Process/elf-core/ProcessElfCore.cpp source/Plugins/Process/elf-core/ProcessElfCore.h

Re: [Lldb-commits] [PATCH] D21164: Improve watchpoint error reporting specially for arm/aarch64 targets

2016-06-27 Thread Muhammad Omair Javaid via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273869: Improve watchpoint error reporting specially for arm/aarch64 targets (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D21164?vs=60127=61959#toc Repository: rL LLVM

[Lldb-commits] [lldb] r273869 - Improve watchpoint error reporting specially for arm/aarch64 targets

2016-06-27 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Mon Jun 27 07:35:41 2016 New Revision: 273869 URL: http://llvm.org/viewvc/llvm-project?rev=273869=rev Log: Improve watchpoint error reporting specially for arm/aarch64 targets Differential revision: http://reviews.llvm.org/D21164 Modified:

Re: [Lldb-commits] [PATCH] D21164: Improve watchpoint error reporting specially for arm/aarch64 targets

2016-06-27 Thread Muhammad Omair Javaid via lldb-commits
omjavaid added inline comments. Comment at: source/Target/Target.cpp:714 @@ -713,2 +713,3 @@ { uint32_t num_current_watchpoints = target->GetWatchpointList().GetSize(); +if (num_supported_hardware_watchpoints == 0) clayborg wrote: > This

[Lldb-commits] [lldb] r273863 - Allow unaligned byte/word selection watchpoints for arm- linux/android targets.

2016-06-27 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Mon Jun 27 06:18:23 2016 New Revision: 273863 URL: http://llvm.org/viewvc/llvm-project?rev=273863=rev Log: Allow unaligned byte/word selection watchpoints for arm- linux/android targets. Differential revision: http://reviews.llvm.org/D21516 Modified:

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

2016-06-27 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 61940. nitesh.jain added a comment. Thanks Labath. Updated diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D20464 Files: cmake/LLDBDependencies.cmake Index: cmake/LLDBDependencies.cmake

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-27 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 61936. ravitheja added a comment. Renaming testcase http://reviews.llvm.org/D21221 Files: packages/Python/lldbsuite/test/functionalities/unwind/ehframe/ packages/Python/lldbsuite/test/functionalities/unwind/ehframe/Makefile