tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good!
We're working on cleaning up the makefiles. Thanks for pointing that out.
https://reviews.llvm.org/D22988
___
lldb-commits mailing
vsk updated this revision to Diff 66209.
vsk added a comment.
- Don't ignore Makefiles per Todd's suggestion.
https://reviews.llvm.org/D22988
Files:
.gitignore
Index: .gitignore
===
--- .gitignore
+++ .gitignore
@@ -35,6 +35,8 @
Author: jingham
Date: Fri Jul 29 13:09:12 2016
New Revision: 277185
URL: http://llvm.org/viewvc/llvm-project?rev=277185&view=rev
Log:
Some code that is sanity checking stepping out back out from one inlined
frame to another was triggering an early stop when stepping back out to a
real frame. Chec
zturner added a comment.
Aside from the compilation error caused by not including `winsock2.h`, I saw no
other obvious problems here, and there are no test regressions.
https://reviews.llvm.org/D22950
___
lldb-commits mailing list
lldb-commits@list
labath added a subscriber: labath.
labath added a comment.
Ok, there is one more big difference: MainLoop doesn't have timeouts yet. So
yes, I guess these are not yet ready for merging...
https://reviews.llvm.org/D22950
___
lldb-commits mailing lis
zturner added a comment.
Currently running the test suite, will report back when it's done.
Comment at: include/lldb/Host/File.h:442
@@ -440,1 +441,3 @@
+class SelectInfo
+{
labath wrote:
> I am not sure about the location of this class, `File` seems l
Author: tfiala
Date: Fri Jul 29 11:00:25 2016
New Revision: 277157
URL: http://llvm.org/viewvc/llvm-project?rev=277157&view=rev
Log:
Revert "updated Xcode project r277139"
This undoes my last commit. It collided with Pavel undoing
his change that my previous commit was adjusting for in the
Xcode
Author: tfiala
Date: Fri Jul 29 10:51:43 2016
New Revision: 277156
URL: http://llvm.org/viewvc/llvm-project?rev=277156&view=rev
Log:
updated Xcode project r277139
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/vie
Author: labath
Date: Fri Jul 29 10:41:52 2016
New Revision: 277154
URL: http://llvm.org/viewvc/llvm-project?rev=277154&view=rev
Log:
Revert "Rewrite gdb-remote's SendContinuePacketAndWaitForResponse"
This reverts commit r277139, because:
- broken unittest on windows (likely typo on my part)
- see
labath added a comment.
I am going to put my responses inilne:
In https://reviews.llvm.org/D22914#499519, @clayborg wrote:
> A few things that worry me:
>
> - There are no sequence IDs on any packets so when receiving responses, I am
> not sure how you are going to match up packets with their r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277140: Add/fix support for i386 elf core files (authored by
dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D22917?vs=65957&id=66114#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: dvlahovski
Date: Fri Jul 29 08:18:09 2016
New Revision: 277140
URL: http://llvm.org/viewvc/llvm-project?rev=277140&view=rev
Log:
Add/fix support for i386 elf core files
Summary:
There were places in the code, assuming(hardcoding) offsets
and types that were only valid for the x86_64 elf c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277139: Rewrite gdb-remote's
SendContinuePacketAndWaitForResponse (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D22629?vs=65895&id=66113#toc
Repository:
rL LLVM
https://rev
Author: labath
Date: Fri Jul 29 08:10:02 2016
New Revision: 277139
URL: http://llvm.org/viewvc/llvm-project?rev=277139&view=rev
Log:
Rewrite gdb-remote's SendContinuePacketAndWaitForResponse
SendContinuePacketAndWaitForResponse was huge function with very complex
interactions with
several other
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
thanks
https://reviews.llvm.org/D22917
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
labath added a comment.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:269
@@ +268,3 @@
+void
+GDBRemoteClientBase::OnRunPacketSent(bool first)
+{
Will do. At that point this whole function becomes pretty irrelevant and i will
inline it
Author: labath
Date: Fri Jul 29 05:34:52 2016
New Revision: 277133
URL: http://llvm.org/viewvc/llvm-project?rev=277133&view=rev
Log:
Fixup r277011 - wrong use of infinite timeout
The commit accidentally switched a timed wait on a condition variable into an
infinite timeout.
Change that back. And
Author: abhishek
Date: Fri Jul 29 02:46:32 2016
New Revision: 277125
URL: http://llvm.org/viewvc/llvm-project?rev=277125&view=rev
Log:
Improve code of loading plugins that provide cmnds
Summary:
- Modified code that enables writing new user-defined commands
and use them through LLDB CLI. Modi
18 matches
Mail list logo
