Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain added a comment. Thanks Greg for all your help. Repository: rL LLVM https://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

ki.stfu added a comment. Hi! So, what you want is to create pending breakpoints without locations? I'm not sure it's the correct use of -break-insert so that lldb-mi has to exit with an error in this case. The other question is why it doesn't do that and sets BPs without locations even if -f h

[Lldb-commits] [PATCH] D23043: [InstrumentationRuntime] Refactor the API (Part 1/N) (NFCI)

vsk created this revision. vsk added reviewers: kubabrecka, k8stone. vsk added subscribers: lldb-commits, friss. Adapters for instrumentation runtimes have to do two basic things: 1) Load a runtime library. 2) Install breakpoints in that library. This logic is duplicated in the adapters for

Re: [Lldb-commits] [PATCH] D22999: Resurrect standalone build

krytarowski added a comment. In https://reviews.llvm.org/D22999#501999, @tberghammer wrote: > I think it is a bad idea to duplicate the CheckAtomic.cmake file from LLVM as > the 2 copy will diverge over time and cause extra maintenance cost. What do > you think about trying to change LLVM to in

Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

jingham added a subscriber: jingham. jingham added a comment. In https://reviews.llvm.org/D22950#500582, @emaste wrote: > Testing now on FreeBSD. Do you have a sense of how many fds lldb might use in > practice? For FreeBSD we can increase it from the default if necessary via > > NOTES >

[Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

pieandcakes created this revision. pieandcakes added a reviewer: lldb-commits. pieandcakes set the repository for this revision to rL LLVM. pieandcakes added a project: LLDB. Herald added a subscriber: ki.stfu. [[ https://llvm.org/bugs/show_bug.cgi?id=28698 | bug 28698]] Repository: rL LLVM ht

[Lldb-commits] [lldb] r277359 - [asan] Remove unused #include (NFC)

Author: vedantk Date: Mon Aug 1 13:02:56 2016 New Revision: 277359 URL: http://llvm.org/viewvc/llvm-project?rev=277359&view=rev Log: [asan] Remove unused #include (NFC) Modified: lldb/trunk/source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.h Modified: lldb/tru

[Lldb-commits] [lldb] r277351 - [lldb] Delete dead, infinitely-recursive code (NFC)

Author: vedantk Date: Mon Aug 1 11:37:42 2016 New Revision: 277351 URL: http://llvm.org/viewvc/llvm-project?rev=277351&view=rev Log: [lldb] Delete dead, infinitely-recursive code (NFC) Differential Revision: https://reviews.llvm.org/D22985 Modified: lldb/trunk/tools/debugserver/source/MacOS

[Lldb-commits] [lldb] r277350 - [lldb][tsan] Perform one map lookup instead of two (NFC)

Author: vedantk Date: Mon Aug 1 11:37:37 2016 New Revision: 277350 URL: http://llvm.org/viewvc/llvm-project?rev=277350&view=rev Log: [lldb][tsan] Perform one map lookup instead of two (NFC) Differential Revision: https://reviews.llvm.org/D22983 Modified: lldb/trunk/source/Plugins/Instrumen

Re: [Lldb-commits] [PATCH] D22132: Support for OCaml native debugging

tberghammer added a subscriber: tberghammer. tberghammer accepted this revision. tberghammer added a reviewer: tberghammer. tberghammer added a comment. Do you want me to commit it in for you? https://reviews.llvm.org/D22132 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D22988: [lldb] Ignore various test artifacts (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rL277346: [lldb] Ignore various test artifacts (NFCI) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D22988?vs=66209&id=66324#toc Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [lldb] r277346 - [lldb] Ignore various test artifacts (NFCI)

Author: vedantk Date: Mon Aug 1 10:15:46 2016 New Revision: 277346 URL: http://llvm.org/viewvc/llvm-project?rev=277346&view=rev Log: [lldb] Ignore various test artifacts (NFCI) Differential Revision: https://reviews.llvm.org/D22988 Modified: lldb/trunk/.gitignore Modified: lldb/trunk/.giti

[Lldb-commits] [lldb] r277347 - [lldb][tsan] Avoid a string copy (NFC)

Author: vedantk Date: Mon Aug 1 10:15:49 2016 New Revision: 277347 URL: http://llvm.org/viewvc/llvm-project?rev=277347&view=rev Log: [lldb][tsan] Avoid a string copy (NFC) Differential Revision: https://reviews.llvm.org/D22984 Modified: lldb/trunk/source/Plugins/InstrumentationRuntime/Thre

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

tberghammer added a comment. Pavel is OOO this week but the change looks good. One request: Can you move the following part out of the android specific part as well? ifdef PIE LDFLAGS += -pie endif It will make no difference at the moment but will make the code more generic and also

Re: [Lldb-commits] [PATCH] D22999: Resurrect standalone build

tberghammer added a subscriber: tberghammer. tberghammer added a comment. I think it is a bad idea to duplicate the CheckAtomic.cmake file from LLVM as the 2 copy will diverge over time and cause extra maintenance cost. What do you think about trying to change LLVM to install this file instead o