Re: [Lldb-commits] [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation…

Thanks Hans -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 09 August 2016 01:59 To: Greg Clayton Cc: Nitesh Jain; Jaydeep Patil; Bhushan Attarde; lldb-commits@lists.llvm.org Subject: Re: [Diffusion] rL277426: [LLVM][MIPS] Add (

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request)

Thanks Hans. -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 09 August 2016 01:58 To: Greg Clayton Cc: Nitesh Jain; Jaydeep Patil; Bhushan Attarde; lldb-commits@lists.llvm.org Subject: Re: [PATCH] D20357: [LLDB][MIPS] Fix FPU Si

Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

clayborg added a comment. I used SelectHelper.h because there is a "/usr/include/select.h" header file and case insensitive file systems would have issues if I used Select.h. https://reviews.llvm.org/D22950 ___ lldb-commits mailing list lldb-commit

Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

clayborg updated this revision to Diff 67253. clayborg added a comment. Updated with all comments taken into account. Zach, please try this out and let me know if it compiles. https://reviews.llvm.org/D22950 Files: include/lldb/Utility/SelectHelper.h lldb.xcodeproj/project.pbxproj source

[Lldb-commits] [lldb] r278064 - Garbage collection is not around anymore, we can remove our support for it.

Author: gclayton Date: Mon Aug 8 17:48:57 2016 New Revision: 278064 URL: http://llvm.org/viewvc/llvm-project?rev=278064&view=rev Log: Garbage collection is not around anymore, we can remove our support for it. Modified: lldb/trunk/source/Host/macosx/HostThreadMacOSX.mm Modified: lldb/trunk

[Lldb-commits] [lldb] r278061 - Fix printf warnings.

Author: gclayton Date: Mon Aug 8 17:16:03 2016 New Revision: 278061 URL: http://llvm.org/viewvc/llvm-project?rev=278061&view=rev Log: Fix printf warnings. Modified: lldb/trunk/source/Plugins/Process/elf-core/ThreadElfCore.cpp Modified: lldb/trunk/source/Plugins/Process/elf-core/ThreadElfCo

[Lldb-commits] [lldb] r278060 - Fix RegisterInfo initializers to have all the required initializers after recent changes. This quiets a few hundred warnings on MacOSX.

Author: gclayton Date: Mon Aug 8 17:15:35 2016 New Revision: 278060 URL: http://llvm.org/viewvc/llvm-project?rev=278060&view=rev Log: Fix RegisterInfo initializers to have all the required initializers after recent changes. This quiets a few hundred warnings on MacOSX. Modified: lldb/trunk

Re: [Lldb-commits] [PATCH] D22914: [WIP] Add concurrent packets support to gdb-remote client

clayborg added a comment. One thing that should be tested before we go farther, can you check the packet speed test with and without this patch? We really need to make sure this doesn't regress. Adding thread synchronization above and beyond taking a mutex could really impact performance. Just

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid updated this revision to Diff 67229. omjavaid added a comment. Adding context. https://reviews.llvm.org/D20386 Files: packages/Python/lldbsuite/test/make/Makefile.rules Index: packages/Python/lldbsuite/test/make/Makefile.rules

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid reopened this revision. omjavaid added a comment. reopening this for new review. https://reviews.llvm.org/D20386 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

omjavaid removed rL LLVM as the repository for this revision. omjavaid updated this revision to Diff 67228. omjavaid added a comment. I have updated previous patch which handles compiler binaries which have version string appended at the end like gcc-4.9 or clang-3.5. Kindly give it a review and

Re: [Lldb-commits] [lldb] r277117 - Fix -break-insert not working when using absolute paths (MI)

Greg: ping? On Wed, Aug 3, 2016 at 9:06 AM, Hans Wennborg wrote: > For LLDB, I think it's up to Greg to decide. > > On Tue, Aug 2, 2016 at 10:20 PM, Ilia K wrote: >> Hi Hans! >> >> The author of this commit asks me is there a chance to include this changes >> to 3.9 release? I'm not sure about o

Re: [Lldb-commits] [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation…

Thanks! r278047. On Mon, Aug 8, 2016 at 10:26 AM, Greg Clayton wrote: > I am fine with this. It is in MIPS only code so it shouldn't affect anything > else. > >> On Aug 2, 2016, at 8:49 AM, Hans Wennborg wrote: >> >> While this all seems very MIPS-specific, so probably fine to merge if >> you w

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request)

Thanks! Merged in r278046. On Mon, Aug 8, 2016 at 10:25 AM, Greg Clayton wrote: > I am fine with this going in, but this fix is for MIPS only. > > >> On Aug 2, 2016, at 8:47 AM, Hans Wennborg wrote: >> >> Looks like a pretty big change to merge at this stage. >> >> I'll let Clayton decide. >> >>

Re: [Lldb-commits] [PATCH] D22999: Resurrect standalone build

krytarowski added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D22999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22369: DWARFDeclContext: Don't add '::' in front of symbol names

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We can't currently do this because we have a dependency on having this be there for existing customers. The problem is that the debug info always has the base names of types in t

Re: [Lldb-commits] [PATCH] D22914: [WIP] Add concurrent packets support to gdb-remote client

clayborg added a comment. I was out on vacation, sorry for the delay. I will get back to you later today. https://reviews.llvm.org/D22914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

Re: [Lldb-commits] [PATCH] D22831: [LLDB] Documentation for SBAddress class

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a quick clarifications on file and load addresses to make things a bit clearer. Comment at: include/lldb/API/SBAddress.h:25-26 @@ +24,4 @@ +/// +/// SBAddr

Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

clayborg added a comment. I am back from vacation again. I will place this in a stand alone file and I will use SelectInfo.h if there is a "select.h" already in any "include" directories like "/usr/include" so we don't run into problems including the right file. If there aren't any select.h fi

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request)

I am fine with this going in, but this fix is for MIPS only. > On Aug 2, 2016, at 8:47 AM, Hans Wennborg wrote: > > Looks like a pretty big change to merge at this stage. > > I'll let Clayton decide. > > Thanks, > Hans > > On Mon, Aug 1, 2016 at 11:25 PM, Nitesh Jain wrote: >> Hi Hans, >>

Re: [Lldb-commits] [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation…

I am fine with this. It is in MIPS only code so it shouldn't affect anything else. > On Aug 2, 2016, at 8:49 AM, Hans Wennborg wrote: > > While this all seems very MIPS-specific, so probably fine to merge if > you want to, it does look more like new development than just bug > fixing. > > I'm

Re: [Lldb-commits] [PATCH] D22369: DWARFDeclContext: Don't add '::' in front of symbol names

labath added a comment. Greg, what do you think about this? https://reviews.llvm.org/D22369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17856: Fix expression evaluation with operator new

labath added a comment. Sean, if you don't object, I am going to put this in next week. pl https://reviews.llvm.org/D17856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22914: [WIP] Add concurrent packets support to gdb-remote client

labath added a comment. Any thoughts on this, Greg? https://reviews.llvm.org/D22914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r278005 - Fix uninitialized field warnings in GDBRemoteRegisterContext

Author: labath Date: Mon Aug 8 08:38:33 2016 New Revision: 278005 URL: http://llvm.org/viewvc/llvm-project?rev=278005&view=rev Log: Fix uninitialized field warnings in GDBRemoteRegisterContext also take the opportunity to replace NULL with nullptr and add clang-format guards to prevent it from

[Lldb-commits] [lldb] r278001 - Clean up linux/Ptrace.h

Author: labath Date: Mon Aug 8 08:13:03 2016 New Revision: 278001 URL: http://llvm.org/viewvc/llvm-project?rev=278001&view=rev Log: Clean up linux/Ptrace.h This removes references to PT_XXX macros from the file, as they were not used anyway. It also changes the macro used to check for the defin

[Lldb-commits] [lldb] r278000 - Remove Android.h

Author: labath Date: Mon Aug 8 07:54:36 2016 New Revision: 278000 URL: http://llvm.org/viewvc/llvm-project?rev=278000&view=rev Log: Remove Android.h It only contained a reimplementation of std::to_string, which I have replaced with usages of pre-existing llvm::to_string (also, injecting members

[Lldb-commits] [lldb] r277999 - Remove SYS_tgkill from Android.h

Author: labath Date: Mon Aug 8 07:40:11 2016 New Revision: 277999 URL: http://llvm.org/viewvc/llvm-project?rev=277999&view=rev Log: Remove SYS_tgkill from Android.h instead, use __NR_tgkill directly, which seems to be the preferred form in the codebase anyway. Modified: lldb/trunk/include/

[Lldb-commits] [lldb] r277997 - Remove _isatty from Android.h

Author: labath Date: Mon Aug 8 07:26:57 2016 New Revision: 277997 URL: http://llvm.org/viewvc/llvm-project?rev=277997&view=rev Log: Remove _isatty from Android.h it is just #defined to isatty anyway, which lldb already knows how to use. Modified: lldb/trunk/include/lldb/Host/android/Android

Re: [Lldb-commits] [PATCH] D23070: [debugserver] Delete CFData.{h, cpp}, since they appear to be dead (NFCI)

labath resigned from this revision. labath removed a reviewer: labath. labath added a comment. @clayborg should approve any changes touching the debugserver. https://reviews.llvm.org/D23070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h