Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-08-12 Thread Todd Fiala via lldb-commits
tfiala added a comment. This will need another change. Existing SBAPI methods cannot have their signatures modified per the SBAPI contract. We'll need to add an entirely new method on SBSourceManager with the new signature. I'll just add newer version of DisplaySourceLinesWithLineNumbers() wi

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-08-12 Thread Todd Fiala via lldb-commits
tfiala added a comment. In https://reviews.llvm.org/D20835#446040, @aprantl wrote: > I have one last question: > While trying to add a testcase I noticed that > DisplaySourceLinesWithLineNumbers is still exported into Python with the old > signature. What is the correct way to update the Pytho

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-08-12 Thread Todd Fiala via lldb-commits
tfiala added a comment. I'm going to help Adrian land this patch. I'm looking into this now. https://reviews.llvm.org/D20835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r278552 - fix lldb-gtest target of Xcode build

2016-08-12 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Aug 12 14:27:05 2016 New Revision: 278552 URL: http://llvm.org/viewvc/llvm-project?rev=278552&view=rev Log: fix lldb-gtest target of Xcode build Change r278527 was filtering out too many libraries. The Xcode lldb-gtest target depends on linking libgtest*.a, but those were

[Lldb-commits] [lldb] r278529 - Disable TestThreadSpecificBpPlusCondition on Windows.

2016-08-12 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Aug 12 12:15:38 2016 New Revision: 278529 URL: http://llvm.org/viewvc/llvm-project?rev=278529&view=rev Log: Disable TestThreadSpecificBpPlusCondition on Windows. Test frequently times out stalling the test runner. Modified: lldb/trunk/packages/Python/lldbsuite/test

Re: [Lldb-commits] [PATCH] D23406: Fix a race in Broadcaster/Listener interaction

2016-08-12 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a comment. Yes, sorry. I seem to have trouble with remembering the Action dropdown... Thanks for figuring this out - and apologies for any hair loss we inadvertently caused you! I doubt it is important to use SmallVector rather than std::vector in

[Lldb-commits] [lldb] r278527 - Link LLDB only against libclang and libLLVM .a files to fix macOS build

2016-08-12 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Aug 12 12:01:19 2016 New Revision: 278527 URL: http://llvm.org/viewvc/llvm-project?rev=278527&view=rev Log: Link LLDB only against libclang and libLLVM .a files to fix macOS build The Xcode macOS build of LLDB is currently broken after https://reviews.llvm.org/D23232 land

[Lldb-commits] [lldb] r278526 - Fix build on Windows.

2016-08-12 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Aug 12 11:52:31 2016 New Revision: 278526 URL: http://llvm.org/viewvc/llvm-project?rev=278526&view=rev Log: Fix build on Windows. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Modified: lldb/trunk/source/Plugins/Process/gdb-remote/Proce

[Lldb-commits] [lldb] r278524 - Switch over to using socketpair for local debugserver connections as they are twice as fast as TCP sockets (on macOS at least).

2016-08-12 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Aug 12 11:46:18 2016 New Revision: 278524 URL: http://llvm.org/viewvc/llvm-project?rev=278524&view=rev Log: Switch over to using socketpair for local debugserver connections as they are twice as fast as TCP sockets (on macOS at least). This change opens a socket pair a

[Lldb-commits] [lldb] r278510 - Skip 2 android test what is broken because of debuggerd

2016-08-12 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Aug 12 09:17:05 2016 New Revision: 278510 URL: http://llvm.org/viewvc/llvm-project?rev=278510&view=rev Log: Skip 2 android test what is broken because of debuggerd debuggerd is a crash reporting system on android what installs some signal handler for SEGV to print a

Re: [Lldb-commits] [PATCH] D23406: Fix a race in Broadcaster/Listener interaction

2016-08-12 Thread Pavel Labath via lldb-commits
labath added a comment. Jim, just to double-check. Was that an "approve" then? My feeling is that the lack of visibility into the SmallVector, means more that we should resurrect the formatter than that we should stop using it. Especially considering the whole "let's integrate closer with llvm"

[Lldb-commits] Fwd: [lldb] r278500 - Fix-up r278299 for windows

2016-08-12 Thread Pavel Labath via lldb-commits
Fyi. Please check if I got that right. -- Forwarded message -- From: Pavel Labath via lldb-commits Date: 12 August 2016 at 12:20 Subject: [Lldb-commits] [lldb] r278500 - Fix-up r278299 for windows To: lldb-commits@lists.llvm.org Author: labath Date: Fri Aug 12 06:20:21 2016 New

[Lldb-commits] [lldb] r278500 - Fix-up r278299 for windows

2016-08-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Aug 12 06:20:21 2016 New Revision: 278500 URL: http://llvm.org/viewvc/llvm-project?rev=278500&view=rev Log: Fix-up r278299 for windows FD_SETSIZE on windows limits the number of file descriptors, rather than their individual magnitude (the underlying implementation uses

[Lldb-commits] [lldb] r278491 - XFAIL TestNamespaceDefinitions on gcc-4.8 and below

2016-08-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Aug 12 04:52:14 2016 New Revision: 278491 URL: http://llvm.org/viewvc/llvm-project?rev=278491&view=rev Log: XFAIL TestNamespaceDefinitions on gcc-4.8 and below Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespace_definitions/TestNamespaceDefinitions

[Lldb-commits] [lldb] r278490 - Make TestCallStopAndContinue clang-format-resilient

2016-08-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Aug 12 04:39:22 2016 New Revision: 278490 URL: http://llvm.org/viewvc/llvm-project?rev=278490&view=rev Log: Make TestCallStopAndContinue clang-format-resilient Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/TestCallStopAndContinu

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

2016-08-12 Thread Pavel Labath via lldb-commits
labath added a comment. Ok. After some though I have come up with this: - leave the tool computation logic as it is in the last version of your patch - add the ability to override the tool values via environment variables. Basically this would mean using `TOOL ?= value` instead of `TOOL = value`