Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-08-24 Thread Pavel Labath via lldb-commits
labath updated this revision to Diff 69088. labath added a comment. Sounds good. I like that this enables us to get rid of the NoLock suffix. Maybe eventually we could event replace the runtime assert with some sort of a static lock discipline checking framework, where you annotate functions wit

[Lldb-commits] [PATCH] D23830: Add cmake option to choose whether to use the builtin demangler

2016-08-24 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: zturner, emaste, krytarowski. labath added subscribers: lldb-commits, clayborg. Herald added a subscriber: emaste. Previously the builting demangler was on for platforms that explicitly set a flag by modifying Mangled.cpp (windows, freebsd). T

Re: [Lldb-commits] [PATCH] D23830: Add cmake option to choose whether to use the builtin demangler

2016-08-24 Thread Pavel Labath via lldb-commits
labath added a comment. @krytarowski: I thought I'd switch netbsd as well, as all the other platforms are doing it already. However, if you want to stick with the system demangler by default, I can easily change it to OFF ... https://reviews.llvm.org/D23830 _

[Lldb-commits] [lldb] r279627 - Fix mismatched new/free in Process:RunPrivateStateThread

2016-08-24 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 24 09:03:10 2016 New Revision: 279627 URL: http://llvm.org/viewvc/llvm-project?rev=279627&view=rev Log: Fix mismatched new/free in Process:RunPrivateStateThread NFC Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Process.cpp URL

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-08-24 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D23802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [Lldb-commits] [PATCH] D23830: Add cmake option to choose whether to use the builtin demangler

2016-08-24 Thread Greg Clayton via lldb-commits
clayborg added a comment. Looks good to me. https://reviews.llvm.org/D23830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [Project] LLDB

2016-08-24 Thread Kate Stone via lldb-commits
k8stone added a member: lldb-commits. PROJECT DETAIL https://reviews.llvm.org/project/profile/39/ ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] LLVM buildmaster will be updated and restarted tonight

2016-08-24 Thread Galina Kistanova via lldb-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D23830: Add cmake option to choose whether to use the builtin demangler

2016-08-24 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D23830#524039, @labath wrote: > @krytarowski: I thought I'd switch netbsd as well, as all the other platforms > are doing it already. However, if you want to stick with the system demangler > by default, I can easily change it to OFF ...

Re: [Lldb-commits] [PATCH] D23825: Fix warnings preventing copy elision.

2016-08-24 Thread Taras Tsugrii via lldb-commits
wttsugrii added a comment. Thanks for the review @clayborg. Could someone please commit this patch to lldb repo? https://reviews.llvm.org/D23825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] r279672 - fix darwin_log test errors on macOS < 10.12

2016-08-24 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Wed Aug 24 16:40:29 2016 New Revision: 279672 URL: http://llvm.org/viewvc/llvm-project?rev=279672&view=rev Log: fix darwin_log test errors on macOS < 10.12 The newer event-based tests I added neglected to do the macOS 10.12 check in the setup. This caused earlier macOS test

[Lldb-commits] [lldb] r279688 - Rewrite the GetFileInSDK methods in PlatformRemoteiOS,

2016-08-24 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Aug 24 18:46:48 2016 New Revision: 279688 URL: http://llvm.org/viewvc/llvm-project?rev=279688&view=rev Log: Rewrite the GetFileInSDK methods in PlatformRemoteiOS, PlatformRemoteAppleWatch, PlatformRemoteAppleTV and remove the GetFileInSDKRoot method from those classes.

[Lldb-commits] Buildbot numbers for the last week of 8/14/2016 - 8/20/2016

2016-08-24 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 8/14/2016 - 8/20/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[Lldb-commits] [lldb] r279704 - If the user has specified target.memory-module-load-level 'minimal'

2016-08-24 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Aug 24 21:33:09 2016 New Revision: 279704 URL: http://llvm.org/viewvc/llvm-project?rev=279704&view=rev Log: If the user has specified target.memory-module-load-level 'minimal' and we couldn't find a dyld binary on the debug system, override that setting and read dyld out

Re: [Lldb-commits] [PATCH] D23830: Add cmake option to choose whether to use the builtin demangler

2016-08-24 Thread Kamil Rytarowski via lldb-commits
krytarowski added a subscriber: joerg. krytarowski added a comment. Looks OK for NetBSD. @joerg are you fine with this? https://reviews.llvm.org/D23830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l