I don't think requiring user install of six would work, lldb should just
work out of the box. Renaming it to lldb_six might work.
Also yes using llvm regex everywhere would be wonderful, I honestly have no
idea why mi was developed the way it was with an aversion to using llvm
classes
On Sat, Sep
mgorny added a comment.
In https://reviews.llvm.org/D23883#539442, @krytarowski wrote:
> It looks good. Remaining TODO for standalone builds:
>
> - sanitize six.py usage (it's installed into system-wide directory, where
> standard py-six lands)
How would you prefer handling it? Can we just kil
krytarowski added a comment.
It looks good. Remaining TODO for standalone builds:
- sanitize six.py usage (it's installed into system-wide directory, where
standard py-six lands)
- bump cmake_minimum_required(VERSION 2.8.12.2) to 3.4.3 in
cmake/modules/LLDBStandalone.cmake
Final bits for Windo
mgorny added a reviewer: labath.
mgorny added a subscriber: labath.
mgorny added a comment.
@labath, since you committed https://reviews.llvm.org/D23882, could you,
please, take a look at this one as well? It's immediately following that, and
should fix the build issue resulting from use of priv
