Author: spyffe
Date: Tue Sep 13 19:48:19 2016
New Revision: 281428
URL: http://llvm.org/viewvc/llvm-project?rev=281428&view=rev
Log:
Cleaned up the code that handles function return addresses in "frame diagnose."
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/T
Author: zturner
Date: Tue Sep 13 18:45:11 2016
New Revision: 281420
URL: http://llvm.org/viewvc/llvm-project?rev=281420&view=rev
Log:
Force c++14 when running tests on Windows.
VS 2015 and higher begin making use of c++14 in their standard
library headers. As such, -std=c++11 makes it so you can
zturner added inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:88
@@ +87,3 @@
+ if (data_sp && ObjectFilePECOFF::MagicBytesMatch(data_sp)) {
+std::auto_ptr objfile_ap(
+new ObjectFilePECOFF(module_sp, data_sp, process_sp, header_addr)
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
See inlined comments. Otherwise this is great.
Comment at: include/lldb/Core/SourceManager.h:34-35
@@ -33,3 +33,4 @@
public:
-File(const FileSpec &file_spe
wallace updated this revision to Diff 71265.
wallace updated the summary for this revision.
wallace added a comment.
rebase
https://reviews.llvm.org/D24284
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
Index: source/Plugins
Author: jmolenda
Date: Tue Sep 13 18:29:46 2016
New Revision: 281418
URL: http://llvm.org/viewvc/llvm-project?rev=281418&view=rev
Log:
TestQueues could error out because the one second sleep main.c was
using to enqueue all the jobs wasn't enough time on a slow/overloaded
system. Instead use a glo
tfiala updated this revision to Diff 71262.
tfiala added a comment.
Minor tweak:
- Shut off color usage in the shared object unloading test. One of the
screen-scraped results it is checking for is not set up to handle the ansi
underline sequence on the column where the process is stopped.
ht
wallace added a comment.
thanks!
https://reviews.llvm.org/D24283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
I will commit it either later today or tomorrow.
https://reviews.llvm.org/D24283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala updated this revision to Diff 71253.
tfiala added a comment.
This change does the following:
- Removes storing the ANSI escape support flag from the stream and directly
consults the Debugger::GetUseColor() method. We should be able to change this
during a debug session (via settings set
wallace added a comment.
btw, i don't have commit access? can you commit it or should i request access?
https://reviews.llvm.org/D24283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
zturner added a comment.
I can believe that :) Looks good then.
https://reviews.llvm.org/D24283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
wallace added a comment.
Hey, apparently this change doesn't affect the test coverage, there are at
least two flaky tests that sometimes produce unexpected success:
test_step_over_dwo, test_process_interrupt_dwo
I repeatedly ran the tests with and without my change it the flakiness was
quite c
Author: spyffe
Date: Tue Sep 13 16:18:27 2016
New Revision: 281398
URL: http://llvm.org/viewvc/llvm-project?rev=281398&view=rev
Log:
Cleaned up some of the "frame diagnose" code to use Operands as currency.
Also added some utility functions around Operands to make code easier and more
compact to
Author: zturner
Date: Tue Sep 13 15:40:26 2016
New Revision: 281387
URL: http://llvm.org/viewvc/llvm-project?rev=281387&view=rev
Log:
Add some unit tests for ArchSpec.
I'm was trying to do some cleanup and code modernization and in
doing so I needed to change ParseMachCPUDashSubtypeTriple to take
zturner added a comment.
In https://reviews.llvm.org/D24283#541645, @wallace wrote:
> I've run the tests and saw that two tests have been fixed
> before:
>
> Test Methods: 1829
> Reruns:0
> Success:1061
> Expected Failure:113
> Failure:
wallace added a comment.
I've run the tests and saw that two tests have been fixed
before:
Test Methods: 1829
Reruns:0
Success:1061
Expected Failure:113
Failure: 0
Error: 7
Exceptional Exit: 0
Unexpected Succ
wallace updated this revision to Diff 71226.
wallace updated the summary for this revision.
wallace added a comment.
rebase
https://reviews.llvm.org/D24283
Files:
source/Core/ArchSpec.cpp
Index: source/Core/ArchSpec.cpp
===
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281360: Some more pointer safety in Breakpoint. (authored by
zturner).
Changed prior to commit:
https://reviews.llvm.org/D24495?vs=71185&id=71208#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24
Author: zturner
Date: Tue Sep 13 12:53:38 2016
New Revision: 281360
URL: http://llvm.org/viewvc/llvm-project?rev=281360&view=rev
Log:
Some more pointer safety in Breakpoint.
Plumb unique_ptrs<> all the way through the baton interface.
NFC, this is a minor improvement to remove the possibility of
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks fine. The only bad effect of making a CommandBaton, then going out of
your way to put it in a plain old BatonSP before passing it to us rather than a
CommandBatonSP is that the serial
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for DW_AT_ranges_base attribute
It is a new attribute emitted by clang as a GNU extension and will
be part of Dwarf5. The purpose of the attribute is to spec
Author: tfiala
Date: Tue Sep 13 11:53:07 2016
New Revision: 281352
URL: http://llvm.org/viewvc/llvm-project?rev=281352&view=rev
Log:
fixup Xcode build for removal of MIUtilParse.*
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
ht
On Mon, Sep 12, 2016 at 6:24 PM Jim Ingham wrote:
> I see the whole content, but I'll reply to this one so the reply doesn't
> get truncated on your end...
>
> > On Sep 12, 2016, at 6:03 PM, Zachary Turner wrote:
> >
> >
> > Immediately, very little. A small amount of performance, since
> compa
Author: dvlahovski
Date: Tue Sep 13 11:22:15 2016
New Revision: 281349
URL: http://llvm.org/viewvc/llvm-project?rev=281349&view=rev
Log:
Fix a merge mishap in rL281348
Modified:
lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp
Modified: lldb/trunk/source/Plugins/Process/minidump
zturner updated this revision to Diff 71185.
zturner added a comment.
There were a few outstanding compiler errors that I missed in my previous patch
as I was doing it on a build without Python. This should catch all of them.
https://reviews.llvm.org/D24495
Files:
include/lldb/Breakpoint/Br
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281348: MinidumpParsing: pid, modules, exceptions, strings
(authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D24385?vs=71154&id=71182#toc
Repository:
rL LLVM
https://review
Author: dvlahovski
Date: Tue Sep 13 10:54:38 2016
New Revision: 281348
URL: http://llvm.org/viewvc/llvm-project?rev=281348&view=rev
Log:
MinidumpParsing: pid, modules, exceptions, strings
Summary:
Added parsing of the MiscInfo data stream.
The main member of it that we care about is the process_i
tfiala updated this revision to Diff 71180.
tfiala added a comment.
Updated patch, tweaked and verified it is working, rebased against r281243.
I'd like to add some unittests for this, so this isn't ready quite yet.
https://reviews.llvm.org/D20835
Files:
include/lldb/API/SBSourceManager.h
Looks good here too
On Tue, Sep 13, 2016 at 6:21 AM Pavel Labath wrote:
> labath added a comment.
>
> Looks good as far as I am concerned.
>
>
> https://reviews.llvm.org/D24385
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
labath added a comment.
Looks good as far as I am concerned.
https://reviews.llvm.org/D24385
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dvlahovski updated this revision to Diff 71154.
dvlahovski added a comment.
Making the LinuxProcStatus a smarter class
by not parsing the pid each time when GetPid is called
https://reviews.llvm.org/D24385
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
source/Plugins/Process/min
mgorny added a comment.
Yes, thanks a lot.
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dvlahovski updated this revision to Diff 71151.
dvlahovski marked 3 inline comments as done.
dvlahovski added a comment.
Removed consumeString; Fixed comparisons in unittests; out-of-bounds check in
MinidumpString parsing
https://reviews.llvm.org/D24385
Files:
source/Plugins/Process/minidump
labath closed this revision.
labath added a comment.
I am going to assume you still want me to submit this. r281317.
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: labath
Date: Tue Sep 13 05:39:12 2016
New Revision: 281317
URL: http://llvm.org/viewvc/llvm-project?rev=281317&view=rev
Log:
Remove MIUtilParse (no longer used)
Summary: follow-up to https://reviews.llvm.org/D23882
Reviewers: dawn, krytarowski, labath, ki.stfu
Subscribers: beanz, mgorny
labath added a comment.
Just a couple of tiny comments from me.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:86
@@ +85,3 @@
+llvm::Optional MinidumpParser::GetMinidumpString(uint32_t rva) {
+ auto arr_ref = m_data_sp->GetData().drop_front(rva);
+ return parse
nitesh.jain added inline comments.
Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:972
@@ -968,4 +971,3 @@
f0_value.GetData(f0_data);
The issued was while setting f0_data and f2_data successively via
RegisterValue.GetData. Since Regis
nitesh.jain created this revision.
nitesh.jain added reviewers: clayborg, labath, bhushan.
nitesh.jain added subscribers: jaydeep, slthakur, lldb-commits.
Herald added a subscriber: sdardis.
https://reviews.llvm.org/D24498
Files:
source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp
Index: source/
Author: tberghammer
Date: Tue Sep 13 04:27:21 2016
New Revision: 281309
URL: http://llvm.org/viewvc/llvm-project?rev=281309&view=rev
Log:
Fix linux build after rL281273
Modified:
lldb/trunk/source/Core/StructuredData.cpp
Modified: lldb/trunk/source/Core/StructuredData.cpp
URL:
http://llvm.o
40 matches
Mail list logo
