[Lldb-commits] [lldb] r283082 - Fix regex in lldb lit test TestCallStopAndContinue

2016-10-02 Thread Tim Hammerquist via lldb-commits
Author: penryu Date: Sun Oct 2 19:07:24 2016 New Revision: 283082 URL: http://llvm.org/viewvc/llvm-project?rev=283082&view=rev Log: Fix regex in lldb lit test TestCallStopAndContinue https://reviews.llvm.org/D25167 Modified: lldb/trunk/lit/Expr/TestCallStopAndContinue.test Modified: lldb/t

[Lldb-commits] [lldb] r283081 - [CMake] Fixing a few missing dependencies on intrinsics_gen

2016-10-02 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Sun Oct 2 19:03:43 2016 New Revision: 283081 URL: http://llvm.org/viewvc/llvm-project?rev=283081&view=rev Log: [CMake] Fixing a few missing dependencies on intrinsics_gen These are missing dependencies that have been exposed in builds as a result of my change to make lld

[Lldb-commits] [lldb] r283069 - Revert "XFAIL TestSBData for gcc-4.9 i386"

2016-10-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Sun Oct 2 10:56:33 2016 New Revision: 283069 URL: http://llvm.org/viewvc/llvm-project?rev=283069&view=rev Log: Revert "XFAIL TestSBData for gcc-4.9 i386" Test fixed. Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py Modified: lldb/tru

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

2016-10-02 Thread Zachary Turner via lldb-commits
zturner added inline comments. > labath wrote in Args.cpp:207 > I think we don't need to call Clear() here, as all memory owned by the object > will be correctly destroyed anyway. Thanks for pointing that out. Originally I wasn't using `unique_ptr` but rather `new[]` and `delete[]`. After I

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

2016-10-02 Thread Pavel Labath via lldb-commits
labath added a comment. random drive-by. Otherwise, I like it. > Args.cpp:207 > +//-- > +Args::~Args() { Clear(); } > + I think we don't need to call Clear() here, as all memory owned by the object will be correctly destroyed