Author: jingham
Date: Fri Oct 14 19:04:38 2016
New Revision: 284296
URL: http://llvm.org/viewvc/llvm-project?rev=284296=rev
Log:
This test is no longer failing for gmodules.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestObjCMethods2.py
Modified:
Hello everyone,
LLVM buildmaster will be updated and restarted after 5 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:242
+
+ for (const auto : modules) {
+name = GetMinidumpString(module.module_name_rva);
I don't know how big the minidumps you're working with are or if
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284250: [CMake] Populate LLDB.framework's headers directory
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D25570?vs=74543=74708#toc
Repository:
rL LLVM
Author: cbieneman
Date: Fri Oct 14 12:09:55 2016
New Revision: 284250
URL: http://llvm.org/viewvc/llvm-project?rev=284250=rev
Log:
[CMake] Populate LLDB.framework's headers directory
Summary:
This patch adds support for installing public headers in LLDB.framework, and
symlinking the headers
This revision was automatically updated to reflect the committed changes.
enlight marked an inline comment as done.
Closed by commit rL284231: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue
class (authored by enlight).
Changed prior to commit:
Author: enlight
Date: Fri Oct 14 07:58:02 2016
New Revision: 284231
URL: http://llvm.org/viewvc/llvm-project?rev=284231=rev
Log:
[LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class
Summary:
Placeholder c-strings don't need to be instance variables.
Reviewers: ki.stfu, abidh
Subscribers:
labath added a comment.
First round of comments from me :).
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:248
+
+if (lowest_addr.find(module_name) == lowest_addr.end()) {
+ lowest_addr[module_name] =
If you use the `emplace` function,
enlight marked an inline comment as done.
enlight added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:116
if (!bOk)
-return m_pUnkwn;
+return kUnresolvedValue;
ki.stfu wrote:
> After couple of minutes I see the lack of logic
enlight updated this revision to Diff 74628.
enlight marked an inline comment as done.
enlight added a comment.
Rename `kUnresolvedValue` back to `kUknownValue`.
Repository:
rL LLVM
https://reviews.llvm.org/D25592
Files:
tools/lldb-mi/MICmnLLDBUtilSBValue.cpp
ki.stfu requested changes to this revision.
ki.stfu added inline comments.
This revision now requires changes to proceed.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:116
if (!bOk)
-return m_pUnkwn;
+return kUnresolvedValue;
After couple of
ki.stfu accepted this revision.
ki.stfu added inline comments.
This revision is now accepted and ready to land.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:21-22
+static const char *kUnknownValue = "??";
+static const char *kCompositeValuePlaceholder = "{...}";
+
enlight added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:21-22
+static const char *kUnknownValue = "??";
+static const char *kCompositeValuePlaceholder = "{...}";
+
ki.stfu wrote:
> use unnamed namespace here
I would like to use an
13 matches
Mail list logo
