Re: [Lldb-commits] [PATCH] D25681: [PseudoTerminal] Fix PseudoTerminal MSVC release crash

fwiw this looks good to me, a much better fix than I had. but it'z zturner who objected to my approach. On 2016-10-17 17:51, Rudy Pons via lldb-commits wrote: Ilod created this revision. Ilod added reviewers: zturner, carlokok. Ilod added a subscriber: lldb-commits. Since r278177, the Posix fu

[Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

omjavaid updated this revision to Diff 75103. omjavaid added a comment. Sorry I was on Holiday so couldnt get back to this earlier. I ll get back to your comments about GDB packet sequence in a separate thread after collecting further information. I have made the suggested corrections in above

[Lldb-commits] [lldb] r284565 - Revert back to the state before r284550

Author: cbieneman Date: Tue Oct 18 21:44:20 2016 New Revision: 284565 URL: http://llvm.org/viewvc/llvm-project?rev=284565&view=rev Log: Revert back to the state before r284550 This patch is causing a lot of issues on bots that I didn't see in local testing. I'm going to have to work on this. Rev

[Lldb-commits] [lldb] r284564 - Trying to fix a few more missing LDFLAGS.

Author: cbieneman Date: Tue Oct 18 21:31:31 2016 New Revision: 284564 URL: http://llvm.org/viewvc/llvm-project?rev=284564&view=rev Log: Trying to fix a few more missing LDFLAGS. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [lldb] r284555 - Fixing the linux bots I broke in r284550

Author: cbieneman Date: Tue Oct 18 19:13:56 2016 New Revision: 284555 URL: http://llvm.org/viewvc/llvm-project?rev=284555&view=rev Log: Fixing the linux bots I broke in r284550 Need to gate cxx linker adding driver-mode flag based on the linker being clang. Modified: lldb/trunk/packages/Pyth

[Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

beanz added a comment. @joerg, it is OS X exclusive, and bash is the system default shell, so I think that makes sense. Repository: rL LLVM https://reviews.llvm.org/D25750 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

This revision was automatically updated to reflect the committed changes. Closed by commit rL284552: When invoking Terminal, don't assume the default shell (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25750?vs=75069&id=75098#toc Repository: rL LLVM https://rev

[Lldb-commits] [lldb] r284552 - When invoking Terminal, don't assume the default shell

Author: cbieneman Date: Tue Oct 18 18:55:34 2016 New Revision: 284552 URL: http://llvm.org/viewvc/llvm-project?rev=284552&view=rev Log: When invoking Terminal, don't assume the default shell Summary: If a user has their shell set to a non-POSIX conferment shell the TestTerminal.py tests fail bec

[Lldb-commits] [lldb] r284551 - [CMake] Don't include LLDB_TEST_COMPILER in cached variable

Author: cbieneman Date: Tue Oct 18 18:54:28 2016 New Revision: 284551 URL: http://llvm.org/viewvc/llvm-project?rev=284551&view=rev Log: [CMake] Don't include LLDB_TEST_COMPILER in cached variable Summary: CMake has no builtin mechanism for cache invalidation. As a general convention you want to

[Lldb-commits] [PATCH] D25751: [CMake] Don't include LLDB_TEST_COMPILER in cached variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL284551: [CMake] Don't include LLDB_TEST_COMPILER in cached variable (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25751?vs=75073&id=75097#toc Repository: rL LLVM https:

[Lldb-commits] [PATCH] D25753: Use clang --driver-mode instead of guessing c++ compiler path

This revision was automatically updated to reflect the committed changes. Closed by commit rL284550: Use clang --driver-mode instead of guessing c++ compiler path (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25753?vs=75078&id=75095#toc Repository: rL LLVM http

[Lldb-commits] [lldb] r284550 - Use clang --driver-mode instead of guessing c++ compiler path

Author: cbieneman Date: Tue Oct 18 18:53:24 2016 New Revision: 284550 URL: http://llvm.org/viewvc/llvm-project?rev=284550&view=rev Log: Use clang --driver-mode instead of guessing c++ compiler path Summary: When building the LLDB test programs, if your CC is clang it actually isn't safe to make

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

Ahh nvm then, I'm on mobile so couldn't see the patch, missed that this was Apple only On Tue, Oct 18, 2016 at 4:49 PM Jim Ingham wrote: > This piece of code is OS X only, it's cons'ing up an AppleScript to run > the process in a new Terminal.app window. So unless Windows has > implemented an Ap

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

This piece of code is OS X only, it's cons'ing up an AppleScript to run the process in a new Terminal.app window. So unless Windows has implemented an AppleScript drivable Terminal.app behind our backs we don't need to work this problem that hard... Jim > On Oct 18, 2016, at 4:43 PM, Zachary

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

I don't think you need to go out of your way to account for this, but Microsoft recently shipped bash on Windows in a full ubuntu environment. I can't check right this second, but I don't think it has sh, only bash. What about a fallback? Try bash, if you can't find it try sh. Thoughts? On Tue, Oct

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

I am pretty sure /bin/sh is supposed to be a posix shell. We could probably use that as well if we felt that there might be an OS X without /bin/bash. But we aren't using any but the most basic properties of the shell along this code path. It isn't being done for shell expansion or anything

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

dmikulin updated this revision to Diff 75090. dmikulin added a comment. Fixed indentation. Repository: rL LLVM https://reviews.llvm.org/D25756 Files: source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp source/Plugins/Process/FreeBSD/Pro

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

dmikulin created this revision. dmikulin added a subscriber: lldb-commits. dmikulin set the repository for this revision to rL LLVM. dmikulin added a project: LLDB. Herald added subscribers: emaste, rengolin, aemerson. Implementation of software single step for FreeBSD on ARM. The code is largely

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

Actually that's a good point. We can default to bash but add a setting to override. The issue we have to solve is that the current approach fails with non-POSIX shells. -Todd > On Oct 18, 2016, at 4:09 PM, Joerg Sonnenberger wrote: > > joerg added a comment. > > OK, this is OSX specific, but

Re: [Lldb-commits] [PATCH] debugserver: Disable four-char-constants and format-pedantic warnings

Pavel Labath writes: > Thanks for the patch. Could you submit the patch through phabricator > and add Greg Clayton as a reviewer. Maybe later. I don't have time to fight with phabricator today. > That said, my preference would be to actually fix those warnings > instea

[Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

joerg added a comment. OK, this is OSX specific, but I still think that hardcoding bash is a bad idea. Does it need anything not in `/bin/sh`? https://reviews.llvm.org/D25750 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

joerg added a comment. Hard-coding `/bin/bash` is not an improvement in my opinion. There are quite a few systems where this is plainly breaking things. https://reviews.llvm.org/D25750 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [PATCH] D25714: [Test Suite] Allow overriding codesign identity

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25714 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D25745: [CMake] Rename lldb-launcher to darwin-debug

tfiala accepted this revision. tfiala added a subscriber: labath. tfiala added a comment. This revision is now accepted and ready to land. This seems fine, but @labath might want to weigh in if Android tools have a hard-baked assumption anywhere on lldb-launcher. https://reviews.llvm.org/D25745

[Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Yep, looks right. We shouldn't be assuming the shell. https://reviews.llvm.org/D25750 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25753: Use clang --driver-mode instead of guessing c++ compiler path

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D25753: Use clang --driver-mode instead of guessing c++ compiler path

beanz created this revision. beanz added reviewers: tfiala, zturner, labath. beanz added a subscriber: lldb-commits. When building the LLDB test programs, if your CC is clang it actually isn't safe to make CXX a string replace of "clang -> clang++". This falls down on unix configurations if your

[Lldb-commits] [PATCH] D25751: [CMake] Don't include LLDB_TEST_COMPILER in cached variable

beanz created this revision. beanz added reviewers: tfiala, zturner, labath. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. CMake has no builtin mechanism for cache invalidation. As a general convention you want to not expand user-specified variables in other cached va

[Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

beanz created this revision. beanz added a reviewer: tfiala. beanz added a subscriber: lldb-commits. If a user has their shell set to a non-POSIX conferment shell the TestTerminal.py tests fail because the shell blurb constructed here may not work in their shell. In my specific case fish-shell

[Lldb-commits] [PATCH] D25680: [cmake] Make dependencies of lldb libraries private, take 2

krytarowski added a comment. Looks fine, thanks. Repository: rL LLVM https://reviews.llvm.org/D25680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25745: [CMake] Rename lldb-launcher to darwin-debug

beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. This tool is only built on Darwin, and the name darwin-debug matches the Xcode project. We should have this in sync unless there is a good reason not to.

[Lldb-commits] [PATCH] D25714: [Test Suite] Allow overriding codesign identity

beanz updated this revision to Diff 75057. beanz added a comment. Updating to use lldbtest_config. https://reviews.llvm.org/D25714 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/dotest_args.py packages/Python/lldbsuite/test/lldbtest.py test/CMakeLists.txt

[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

Eugene.Zelenko added a comment. There are same problems with formatting as in https://reviews.llvm.org/D25726. Also test case main() has wrong indentation. https://reviews.llvm.org/D25734 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D25733: Add data formatter for libstdc++ tuple

Eugene.Zelenko added a comment. There are same problems with formatting as in https://reviews.llvm.org/D25726. Also test case main() has wrong indentation. https://reviews.llvm.org/D25733 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

tberghammer added a comment. In https://reviews.llvm.org/D25726#573127, @Eugene.Zelenko wrote: > Please run Clang-format over new code. I run it before upload but it mush have picked up some strange config. Will run it again before submit. Thanks for noticing it. https://reviews.llvm.org/D25

[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

tberghammer created this revision. tberghammer added reviewers: labath, granata.enrico. tberghammer added a subscriber: lldb-commits. Add data formatter for libstdc++ unique_ptr https://reviews.llvm.org/D25734 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatte

[Lldb-commits] [PATCH] D25733: Add data formatter for libstdc++ tuple

tberghammer created this revision. tberghammer added reviewers: labath, granata.enrico. tberghammer added a subscriber: lldb-commits. Herald added subscribers: mgorny, beanz. Add data formatter for libstdc++ tuple https://reviews.llvm.org/D25733 Files: packages/Python/lldbsuite/test/function

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

Eugene.Zelenko added a comment. Please run Clang-format over new code. Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:12 + +#include +#include STL headers should be after application's headers. Comment at: source/Pl

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

tberghammer updated this revision to Diff 75025. tberghammer added a comment. Herald added subscribers: mgorny, beanz. Move the code to a new cpp file https://reviews.llvm.org/D25726 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/T

[Lldb-commits] [lldb] r284484 - xfail TestMiSyntax.py's test_lldbmi_output_grammar on macOS

Author: tfiala Date: Tue Oct 18 10:15:24 2016 New Revision: 284484 URL: http://llvm.org/viewvc/llvm-project?rev=284484&view=rev Log: xfail TestMiSyntax.py's test_lldbmi_output_grammar on macOS Needs to be investigated. This is failing locally and on the Xcode CI. rdar://28805064 Modified:

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

tberghammer created this revision. tberghammer added reviewers: labath, granata.enrico. tberghammer added a subscriber: lldb-commits. Improve the libstdc++ smart pointer formatters - Display the strong/weak count in the summary - Display the pointed object as a synthetic member - Create s

[Lldb-commits] [PATCH] D25677: Minidump plugin: redesign the x86_64 register context

dvlahovski updated this revision to Diff 74987. dvlahovski added a comment. Merge if's checking the same context flag https://reviews.llvm.org/D25677 Files: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.h I

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

mgorny planned changes to this revision. mgorny added a comment. `LLVM_CMAKE_PATH` posted as https://reviews.llvm.org/D25724. https://reviews.llvm.org/D25668 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] r284469 - Fixup r284466 - try to unbreak NetBSD

Author: labath Date: Tue Oct 18 05:46:45 2016 New Revision: 284469 URL: http://llvm.org/viewvc/llvm-project?rev=284469&view=rev Log: Fixup r284466 - try to unbreak NetBSD NetBSD does not have getopt as well - we need to apply the workaround there too. FreeBSD seems to be fine though. Modified:

[Lldb-commits] [PATCH] D25680: [cmake] Make dependencies of lldb libraries private, take 2

This revision was automatically updated to reflect the committed changes. Closed by commit rL284466: [cmake] Make dependencies of lldb libraries private, take 2 (authored by labath). Changed prior to commit: https://reviews.llvm.org/D25680?vs=74854&id=74967#toc Repository: rL LLVM https://r

[Lldb-commits] [lldb] r284466 - [cmake] Make dependencies of lldb libraries private, take 2

Author: labath Date: Tue Oct 18 05:26:57 2016 New Revision: 284466 URL: http://llvm.org/viewvc/llvm-project?rev=284466&view=rev Log: [cmake] Make dependencies of lldb libraries private, take 2 Summary: The dependencies of our libraries (only liblldb, really) we marked as public, which caused all

[Lldb-commits] [PATCH] D25680: [cmake] Make dependencies of lldb libraries private, take 2

labath added subscribers: krytarowski, emaste, sylvestre.ledru. labath added a comment. @sylvestre.ledru : I believe this will fix the LINK_LLVM_DYLIB issue you were encountering. Let me know if you're still having problems after this. @emaste @krytarowski : This has potential to break linking on

[Lldb-commits] [PATCH] D25714: [Test Suite] Allow overriding codesign identity

labath added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:484 +os.environ['LLDB_CODESIGN_IDENTITY'] = args.codesign_identity + The function is not really consistent in this aspect, but if you don't really need this to be in the env

Re: [Lldb-commits] [PATCH] debugserver: Disable four-char-constants and format-pedantic warnings

Hi, Thanks for the patch. Could you submit the patch through phabricator and add Greg Clayton as a reviewer. That said, my preference would be to actually fix those warnings instead of silencing them. pl On 17 October 2016 at 08:24, Justin Bogner via lldb-commits wrot