nitesh.jain updated the summary for this revision.
nitesh.jain updated this revision to Diff 79864.
nitesh.jain added a comment.
Updated diff as per suggestion.
https://reviews.llvm.org/D27124
Files:
source/Target/StopInfo.cpp
Index: source/Target/StopInfo.cpp
==
jingham added a comment.
Other than the request for a more logging, this seems fine.
Comment at: source/Plugins/ExpressionParser/Clang/IRForTarget.cpp:514-515
+ default:
+ encoding_flags = 0x0600; /* fall back to 0x0600, kCFStringEncodingASCII */
+ }
+ Constant *encoding_arg
jasonmolenda added a comment.
For what it's worth, this change was part of the changes we made to reduce
packet traffic for "private stops". When a high-level "step" or "next" command
is done, we instruction step (or fast-step with Jim's fast-step code when it
sees a sequence of instructions t
spyffe created this revision.
spyffe added a reviewer: jingham.
spyffe added a subscriber: LLDB.
spyffe set the repository for this revision to rL LLVM.
We have a longstanding issue where the expression parser does not handle wide
CFStrings (e.g., `@"凸凹"`) correctly, producing the useless error m
jmajors created this revision.
jmajors added a reviewer: labath.
jmajors added a subscriber: lldb-commits.
Herald added a subscriber: danalbert.
To prevent costly calls to the server to get the PC for every thread,
add all the thread's PCs to the jstopinfo message. This also makes the
Linux/Androi
Author: jmolenda
Date: Wed Nov 30 17:00:52 2016
New Revision: 288284
URL: http://llvm.org/viewvc/llvm-project?rev=288284&view=rev
Log:
Add another address to look for the kernel load addr in
DynamicLoaderDarwinKernel::SearchForKernelWithDebugHints
on 32-bit devices.
Modified:
lldb/trunk/s
probinson added a comment.
Thanks for helping to decipher the test result!
Repository:
rL LLVM
https://reviews.llvm.org/D27282
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288282: PR31214: Make a test tolerate "line 0" when stepping
by instruction. (authored by probinson).
Changed prior to commit:
https://reviews.llvm.org/D27282?vs=79813&id=79824#toc
Repository:
rL LLV
Author: probinson
Date: Wed Nov 30 16:47:25 2016
New Revision: 288282
URL: http://llvm.org/viewvc/llvm-project?rev=288282&view=rev
Log:
PR31214: Make a test tolerate "line 0" when stepping by instruction.
Differential Revision: http://reviews.llvm.org/D27282
Modified:
lldb/trunk/packages/Py
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
And remember to check the accept revision...
https://reviews.llvm.org/D27282
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
jingham added a comment.
That's great. The source stepping should never have to do this by hand, so
special casing the instruction stepping was perfect.
https://reviews.llvm.org/D27282
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
probinson added a comment.
Forgot to mention this is for PR31214.
https://reviews.llvm.org/D27282
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
probinson created this revision.
probinson added a reviewer: jingham.
probinson added a subscriber: LLDB.
LLVM is about to start emitting "line 0" records more often in the DWARF line
table.
One test tripped over this; made the test accommodate the new records.
https://reviews.llvm.org/D27282
emaste added a comment.
In https://reviews.llvm.org/D27126#609150, @labath wrote:
> In https://reviews.llvm.org/D27126#607057, @dmikulin wrote:
>
> > I can run tests on 32bit ARM FreeBSD 11.RC3 rpi2, but without software
> > single step not a lot of tests pass on ARM FreeBSD ;)
> > Can we get h
emaste added inline comments.
Comment at: source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:551-557
+} else {
+ static const uint8_t g_arm_breakpoint_opcode[] = {0xFE,0xDE,0xFF,0xE7};
+ size_t trap_opcode_size = sizeof(g_arm_breakpoint_opcode);
+ assert(bp_si
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
That looks correct to me as well. Thanks for taking the time to clean this up.
Comment at: source/Target/Process.cpp:4926-4928
+diagnostic_manager.PutString(eDiagnosti
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks great to me. Thank you Kuba!!!
https://reviews.llvm.org/D27017
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
labath added a comment.
In https://reviews.llvm.org/D27126#607057, @dmikulin wrote:
> I can run tests on 32bit ARM FreeBSD 11.RC3 rpi2, but without software single
> step not a lot of tests pass on ARM FreeBSD ;)
> Can we get https://reviews.llvm.org/D25756 committed?
I'll leave that decision
Author: labath
Date: Wed Nov 30 10:08:45 2016
New Revision: 288247
URL: http://llvm.org/viewvc/llvm-project?rev=288247&view=rev
Log:
Fix handling of consecutive slashes in FileSpec::GetNormalizedPath()
The core of the function was actually handling them correctly. However, the
early exit was bein
labath created this revision.
labath added a reviewer: jingham.
labath added a subscriber: lldb-commits.
Since the function is way too big already, I tried at least to factor out the
timeout computation stuff into a separate function. I've tried to make the new
code semantically equivalent, and it
Author: labath
Date: Wed Nov 30 05:56:32 2016
New Revision: 288241
URL: http://llvm.org/viewvc/llvm-project?rev=288241&view=rev
Log:
Convert most of the Process class to Timeout<>
This changes most of the class to use the new Timeout class. The one function
left is RunThreadPlan, which I left for
Author: labath
Date: Wed Nov 30 05:09:47 2016
New Revision: 288239
URL: http://llvm.org/viewvc/llvm-project?rev=288239&view=rev
Log:
Fix OSX build for r288238
Modified:
lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/Pr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288238: Use Timeout<> in the Listener class (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D27136?vs=79313&id=79714#toc
Repository:
rL LLVM
https://reviews.llvm.org/D27136
Author: labath
Date: Wed Nov 30 04:41:42 2016
New Revision: 288238
URL: http://llvm.org/viewvc/llvm-project?rev=288238&view=rev
Log:
Use Timeout<> in the Listener class
Summary:
Communication classes use the Timeout<> class to specify the timeout. Listener
class was converted to chrono some time
Author: labath
Date: Wed Nov 30 04:25:02 2016
New Revision: 288237
URL: http://llvm.org/viewvc/llvm-project?rev=288237&view=rev
Log:
Remove a spurious reference to ProcessElfCore
We were referencing a the process class from a register context, which seems
intuitively wrong. Also, the comment abov
Author: labath
Date: Wed Nov 30 04:17:58 2016
New Revision: 288236
URL: http://llvm.org/viewvc/llvm-project?rev=288236&view=rev
Log:
Remove an x86-ism from RegisterInfoInterface
Summary:
While adding FPR support to x86 elf core files (D26300), we ended up adding a
very x86-specific function to th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288236: Remove an x86-ism from RegisterInfoInterface
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D27222?vs=79618&id=79713#toc
Repository:
rL LLVM
https://reviews.llvm.org
27 matches
Mail list logo
