[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

dmikulin updated this revision to Diff 79987. dmikulin added a comment. Addressed review comments. Haven't had a chance to re-test it on an arm board. Repository: rL LLVM https://reviews.llvm.org/D25756 Files: source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp source/Plugins/Process/Fre

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

jasonmolenda added a comment. @labath ah I see I hadn't looked at the lldb-server packets so I didn't know you had jThreadsInfo, good to hear. Yes, if your target is built mostly -fomit-frame-pointer, lldb-server won't be able to do a stack walk without reading eh_frame or the arm unwind info

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

Thanks, Sean! On Thu, Dec 1, 2016 at 11:25 AM, Sean Callanan wrote: > $ svn commit > Sendingsource/Plugins/ExpressionParser/Clang/IRForTarget.cpp > Transmitting file data .done > Committing transaction... > Committed revision 288403. > > Sorry for the noise, folks. > > Sean > > On Dec 1,

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

jingham added a comment. This looks fine. Can you add a comment explaining why this is necessary, it isn't obvious right off the bat? If this is fixing a test case, then just add a comment and this change is fine. If the fix is test-suite neutral, then please add a test case. https://review

[Lldb-commits] [PATCH] D27291: Handle UTF-16 and UTF-32 constant CFStrings

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks good. Repository: rL LLVM https://reviews.llvm.org/D27291 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

$ svn commit Sendingsource/Plugins/ExpressionParser/Clang/IRForTarget.cpp Transmitting file data .done Committing transaction... Committed revision 288403. Sorry for the noise, folks. Sean > On Dec 1, 2016, at 11:21 AM, Sean Callanan wrote: > > It'll be a fix. ETA 10 minutes. > >> On

[Lldb-commits] [lldb] r288403 - Handle empty strings when looking for a CFString's encoding.

Author: spyffe Date: Thu Dec 1 13:14:55 2016 New Revision: 288403 URL: http://llvm.org/viewvc/llvm-project?rev=288403&view=rev Log: Handle empty strings when looking for a CFString's encoding. Should fix the bots. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Mo

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

It'll be a fix. ETA 10 minutes. > On Dec 1, 2016, at 11:16 AM, Sean Callanan via lldb-commits > wrote: > > It's definitely this one. I'll have a fix or a revert in the next 30 minutes. >> On Dec 1, 2016, at 10:58 AM, Tim Hammerquist > > wrote: >> >> Builds with this

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

It's definitely this one. I'll have a fix or a revert in the next 30 minutes. > On Dec 1, 2016, at 10:58 AM, Tim Hammerquist wrote: > > Builds with this patch have been failing due to a segfaulting testcase. See: > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/22721/ >

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

Builds with this patch have been failing due to a segfaulting testcase. See: http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/22721/ http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/22722/ At first glance, it's possible the failure was introduced by either this commit (r28

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

clayborg added a comment. I am not sure I like the implications of all this MIPS specific knowledge in this test. I would like it if we can abstract this into the GDB remote protocol. Since we get the register descriptions from the lldb-server, it would be nice if the register description for t

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I let Jim OK this patch. https://reviews.llvm.org/D27124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

labath planned changes to this revision. labath added a comment. Thanks for the suggestion. I'll try using `__ANDROID__` instead. Comment at: cmake/platforms/Android.cmake:36 # flags and definitions remove_definitions( -DANDROID -D__ANDROID__ ) +add_definitions( -DANDROID -DL

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

danalbert added inline comments. Comment at: cmake/platforms/Android.cmake:36 # flags and definitions remove_definitions( -DANDROID -D__ANDROID__ ) +add_definitions( -DANDROID -DLLDB_DISABLE_LIBEDIT ) You're removing it a line before just to add it back? `__AN

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

labath created this revision. labath added reviewers: tberghammer, zturner. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, srhines, danalbert. This replaces all the uses of the __ANDROID_NDK__ define with ANDROID. This is a preparatory step to remove our custom android

[Lldb-commits] [lldb] r288387 - Remove another hack from the android toolchain file

Author: labath Date: Thu Dec 1 11:48:51 2016 New Revision: 288387 URL: http://llvm.org/viewvc/llvm-project?rev=288387&view=rev Log: Remove another hack from the android toolchain file This is no longer an issue with recent versions of the android ndk. Modified: lldb/trunk/cmake/platforms/An

[Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

Author: spyffe Date: Thu Dec 1 11:46:51 2016 New Revision: 288386 URL: http://llvm.org/viewvc/llvm-project?rev=288386&view=rev Log: Handle UTF-16 and UTF-32 constant CFStrings We have a longstanding issue where the expression parser does not handle wide CFStrings (e.g., @"凸凹") correctly, produc

[Lldb-commits] [PATCH] D27291: Handle UTF-16 and UTF-32 constant CFStrings

spyffe updated this revision to Diff 79935. spyffe added a comment. Updated to reflect Jim's comments. Repository: rL LLVM https://reviews.llvm.org/D27291 Files: packages/Python/lldbsuite/test/lang/objc/unicode-string/TestUnicodeString.py packages/Python/lldbsuite/test/lang/objc/unicode-

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

nitesh.jain updated this revision to Diff 79890. nitesh.jain added a comment. Update diff as per suggestion. Thanks https://reviews.llvm.org/D27088 Files: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py Index: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbG

[Lldb-commits] [PATCH] D26505: Remove a hack from the Android toolchain file

This revision was automatically updated to reflect the committed changes. Closed by commit rL288331: Remove a hack from the Android toolchain file (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26505?vs=77484&id=79889#toc Repository: rL LLVM https://reviews.llvm.or

[Lldb-commits] [lldb] r288331 - Remove a hack from the Android toolchain file

Author: labath Date: Thu Dec 1 05:30:08 2016 New Revision: 288331 URL: http://llvm.org/viewvc/llvm-project?rev=288331&view=rev Log: Remove a hack from the Android toolchain file Summary: The fix is to make sure llvm does not pull in dlopen() in configurations where it is not available. Reviewe

[Lldb-commits] [PATCH] D27258: Use Timeout<> in Process::RunThreadPlan

This revision was automatically updated to reflect the committed changes. Closed by commit rL288326: Use Timeout<> in Process::RunThreadPlan (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27258?vs=79737&id=79886#toc Repository: rL LLVM https://reviews.llvm.org/D272

[Lldb-commits] [lldb] r288326 - Use Timeout<> in Process::RunThreadPlan

Author: labath Date: Thu Dec 1 04:57:30 2016 New Revision: 288326 URL: http://llvm.org/viewvc/llvm-project?rev=288326&view=rev Log: Use Timeout<> in Process::RunThreadPlan Summary: Since the function is way too big already, I tried at least to factor out the timeout computation stuff into a sepa

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm, after you consider my comment below. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py:30 +# Indicating SR.FR bit status +fr_fl

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

nitesh.jain updated this revision to Diff 79881. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D27088 Files: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py Index: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

labath added a comment. Looks like a good starting point. Apart from some style nits, I'd like us to remove sending of the `registers` field in the `jstopinfo`, as it is not necessary anymore. Also, we should add an lldb-server style test for this. @jasonmolenda, we already have jThreadsInfo su