[Lldb-commits] [PATCH] D27476: Install lldb Python module on Windows.

vadimcn created this revision. vadimcn added reviewers: zturner, hans. vadimcn added a subscriber: lldb-commits. vadimcn set the repository for this revision to rL LLVM. vadimcn added a project: LLDB. Herald added a subscriber: mgorny. With this change, "script import lldb" succeeds when executed

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

labath added a comment. This discussion has diverged across lldb-dev and lldb-commits. I think we should move it to one place. I propose lldb-dev, as that seems a better place for high-level discussions. https://reviews.llvm.org/D27459 ___

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

jingham added a comment. I not infrequently have some non-trivial code in the "if (log)" block that gathers the information that I am then going to print, or loops over entities printing them. Putting more complex code like that inside a macro looks awful and is hard to debug. I don't think

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

zturner added a comment. In https://reviews.llvm.org/D27459#614672, @clayborg wrote: > Does llvm::formatv allow you to specify the base of integers, or just where > they go? Can you give it width, number base, leading characters and other > things like a lot of what printf does? You can

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

zturner added a comment. In https://reviews.llvm.org/D27459#614670, @clayborg wrote: > Part of the reason I like the current "if (log) log->Printf()" is that it > doesn't cost you much if logging isn't enabled. So if you have a log line > like: > > if (log) > log->Printf("%s %s %s",

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

clayborg added a comment. I am fine with us changing logging, just want to make sure it works well. Ideally it would include: - almost zero cost when logging disabled. No arguments should be passed to any functions and then determine that logging is disabled, it should check if logging is

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

clayborg added a comment. Does llvm::formatv allow you to specify the base of integers, or just where they go? Can you give it width, number base, leading characters and other things like a lot of what printf does? https://reviews.llvm.org/D27459

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

clayborg added a comment. Part of the reason I like the current "if (log) log->Printf()" is that it doesn't cost you much if logging isn't enabled. So if you have a log line like: if (log) log->Printf("%s %s %s", myStringRef1.str().c_str(), myStringRef2.str().c_str(),

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

clayborg added a comment. The other way to do this that might be easier is to require this register is always read via a "p" packet and watch for the size that comes back and adjust the register size for that register accordingly. https://reviews.llvm.org/D27088

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

clayborg added a comment. We should be able to handle this being thread specific. Each stop reply packet and qThreadStopInfo (asks for a complete stop reply packet for each thread), or the the "jThreadsInfo" packet (see "$trunk/docs/lldb-gdb-remote.txt" for detail) has the ability to return

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Great, thanks! https://reviews.llvm.org/D27124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

labath added a comment. In https://reviews.llvm.org/D27459#614549, @zturner wrote: > A couple comments: > > 1. If we're going to use `formatv` (yay!) then let's standardize. No point > mising `formatv` and streaming, especially when the former will almost always > be less verbose. In this

Re: [Lldb-commits] [PATCH] D27394: Fix expression evaluation inside lambda functions for gcc

> On Dec 6, 2016, at 1:42 AM, Tamas Berghammer via Phabricator > wrote: > > tberghammer added a reviewer: aprantl. > tberghammer added a comment. > > +Adrian > > Thank you for all the comment. I agree that teaching the AST Importer to be > able to handle types

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

zturner added a comment. A couple comments: 1. If we're going to use `formatv` (yay!) then let's standardize. No point mising `formatv` and streaming, especially when the former will almost always be less verbose. 2. One of the concerns that came up last time was that of evaluating the

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

labath created this revision. labath added a subscriber: lldb-commits. https://reviews.llvm.org/D27459 Files: include/lldb/Core/Log.h source/Plugins/Process/Linux/NativeProcessLinux.cpp Index: source/Plugins/Process/Linux/NativeProcessLinux.cpp

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

nitesh.jain added a comment. Hi Greg, I am not sure whether this approach will work in Multithreaded application. Since if any thread modify the SR.FR bit then the change will get reflect in all copy of SR.FR of all other threads. So if we stop at thread A and thread B (running) try to modify

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

nitesh.jain updated this revision to Diff 80414. nitesh.jain added a comment. Update diff as per suggestion https://reviews.llvm.org/D27124 Files: source/Target/StopInfo.cpp Index: source/Target/StopInfo.cpp === ---

[Lldb-commits] [lldb] r288797 - Use Timeout<> in EvaluateExpressionOptions class

Author: labath Date: Tue Dec 6 05:24:51 2016 New Revision: 288797 URL: http://llvm.org/viewvc/llvm-project?rev=288797=rev Log: Use Timeout<> in EvaluateExpressionOptions class Modified: lldb/trunk/include/lldb/Target/Target.h lldb/trunk/source/API/SBExpressionOptions.cpp

[Lldb-commits] [PATCH] D27394: Fix expression evaluation inside lambda functions for gcc

tberghammer added a reviewer: aprantl. tberghammer added a comment. +Adrian Thank you for all the comment. I agree that teaching the AST Importer to be able to handle types inside a DeclBlock would be the best long term solution but I am not sure about its complexity and feasibility (will take