Author: jmolenda
Date: Wed Feb 1 21:02:51 2017
New Revision: 293858
URL: http://llvm.org/viewvc/llvm-project?rev=293858&view=rev
Log:
Add logging to SBThread::GetInfoItemByPathAsString to
print the path being requested.
Change the GetInfoItemByPathAsString docuemtnation in
the .i file to use do
labath added a comment.
the newlines were a red herring. I think the problem is that you forgot to use
the LINK_LIBS argument (see comment).
This works on linux after applying this change (and fixing ObjectFileELF test
dependencies, which you missed because they were added yesterday).
==
labath added a comment.
BTW, I just noticed that the Breakpoint change has dos line breaks for some
reason. Maybe that could be the cause. I'll try it out tomorrow.
https://reviews.llvm.org/D29352
___
lldb-commits mailing list
lldb-commits@lists.ll
jingham added a comment.
I meant the code in source/Host, but somehow missed the change to
Host/macosx/Symbols.cpp on the first pass, so you probably did.
https://reviews.llvm.org/D29427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
zturner added a comment.
I didn't do everything needed to get Utility to be standalone if that's what
you mean. Some things are trickier than others, so I wanted to isolate this CL
to strictly mechanical code move.
What Host code were you referring to?
BTW, I'll probably submit this tomorrow
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This looks fine to me. Just check it on in and we'll fix the project files
after the fact.
BTW, did you scrub the Host code and do the mutatis mutandis on them, or will
we have to do that
labath added a comment.
Unfortunately, I am still getting undefined symbols when building some of the
unittest binaries:
FAILED: : && /usr/bin/clang++-3.6 -fPIC -fvisibility-inlines-hidden -Wall
-W -Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wmissing-field-initializers -pedantic -Wn
Author: jmolenda
Date: Wed Feb 1 16:41:38 2017
New Revision: 293831
URL: http://llvm.org/viewvc/llvm-project?rev=293831&view=rev
Log:
Update xcodeproj to track ConvertEnum.cpp et al being removed.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/projec
Derp. Thanks for catching that!
On Wed, Feb 1, 2017 at 2:41 PM Jason Molenda wrote:
> You need some break;s.
>
>
> -const char *lldb_private::GetVoteAsCString(Vote vote) {
> - switch (vote) {
> - case eVoteNo:
> -return "no";
> - case eVoteNoOpinion:
> -return "no opinion";
> - case
You need some break;s.
-const char *lldb_private::GetVoteAsCString(Vote vote) {
- switch (vote) {
- case eVoteNo:
-return "no";
- case eVoteNoOpinion:
-return "no opinion";
- case eVoteYes:
-return "yes";
- }
- return "invalid";
-}
+template <> struct format_provider {
+ stat
beanz updated this revision to Diff 86721.
beanz added a comment.
Unit tests are updated in https://reviews.llvm.org/rL293821. This update makes
one last change to the unit tests to build with the explicit dependencies.
https://reviews.llvm.org/D29352
Files:
cmake/LLDBDependencies.cmake
cm
Author: cbieneman
Date: Wed Feb 1 16:17:00 2017
New Revision: 293821
URL: http://llvm.org/viewvc/llvm-project?rev=293821&view=rev
Log:
[CMake] Update unit tests with accurate dependencies
This is extending the updates from r293696 to the LLDB unit tests.
Modified:
lldb/trunk/unittests/Break
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293806: Break some dependencies in lldbUtility. (authored by
zturner).
Changed prior to commit:
https://reviews.llvm.org/D29359?vs=86516&id=86693#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29
Author: zturner
Date: Wed Feb 1 13:45:14 2017
New Revision: 293806
URL: http://llvm.org/viewvc/llvm-project?rev=293806&view=rev
Log:
Break some dependencies in lldbUtility.
Differential Revision: https://reviews.llvm.org/D29359
Removed:
lldb/trunk/include/lldb/Utility/ConvertEnum.h
lldb
beanz added a comment.
Ah! I forgot to update the unittest directory. I'll get a patch in today that
updates the unittests following the pattern from the libraries.
https://reviews.llvm.org/D29352
___
lldb-commits mailing list
lldb-commits@lists.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293803: [cmake] Remove VERSION property from executable
targets (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D29126?vs=85751&id=86685#toc
Repository:
rL LLVM
https://revie
Author: labath
Date: Wed Feb 1 13:12:22 2017
New Revision: 293803
URL: http://llvm.org/viewvc/llvm-project?rev=293803&view=rev
Log:
[cmake] Remove VERSION property from executable targets
Summary:
Currently, in the default configuration, the "install" target will
install all llvm executables unv
krytarowski added a comment.
It looks good.
https://reviews.llvm.org/D29406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
In https://reviews.llvm.org/D29405#663566, @labath wrote:
> It does not seem to work for me. I get this when I run ninja check-lldb in
> the build directory:
>
> Traceback (most recent call last):
> File "/usr/local/google/home/labath/ll/llvm/tools/lldb/test/do
lgtm
On 1 February 2017 at 11:01, Zachary Turner wrote:
> Correct, I'm not doing any of the "long term" stuff now, I was just thinking
> out loud with that.
>
> On Wed, Feb 1, 2017 at 10:49 AM Jim Ingham wrote:
>>
>> I don't think any of this should be terribly controversial. The "Long
>> term"
Correct, I'm not doing any of the "long term" stuff now, I was just
thinking out loud with that.
On Wed, Feb 1, 2017 at 10:49 AM Jim Ingham wrote:
> I don't think any of this should be terribly controversial. The "Long
> term" part of the proposals might be, but that's not what you're talking
>
labath added a comment.
It does not seem to work for me. I get this when I run ninja check-lldb in the
build directory:
Traceback (most recent call last):
File "/usr/local/google/home/labath/ll/llvm/tools/lldb/test/dotest.py",
line 6, in
import lldbsuite.test
File
"/usr/local/
labath added inline comments.
Comment at: source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:163
+ // Resolve any executable within a bundle on MacOSX
+ Host::ResolveExecutableInBundle(resolved_module_spec.GetFileSpec());
+
This is the bit that was only pr
I don't think any of this should be terribly controversial. The "Long term"
part of the proposals might be, but that's not what you're talking about here,
right?
These changes will presumably require adjustments to the Xcode project. If you
can do that yourself, then that's great. If you nee
labath created this revision.
various platforms very using nearly identical code for this method. As far as I
can tell there was nothing platform-specific about the differences, but rather
it looked like it was caused by tiny tweaks being made to individual copies
without affecting the overall fun
krytarowski added a comment.
Please help to test this patch for regressions, at the moment I don't have all
the test suits passing and I might have miss something.
At least `scripts/Python/modify-python-lldb.py` had to retain 'import six'.
Repository:
rL LLVM
https://reviews.llvm.org/D29405
krytarowski created this revision.
krytarowski added a project: LLDB.
The current version of LLDB installs six.py into global python library
directory. This approach produces conflicts downstream with distribution's
py-six copy.
Install six.py into subdirectory as this is a common way of handli
krytarowski created this revision.
krytarowski added a project: LLDB.
Include for strcmp(3) and memset(3).
Sponsored by
Repository:
rL LLVM
https://reviews.llvm.org/D29403
Files:
packages/Python/lldbsuite/test/api/multiple-debuggers/multi-process-driver.cpp
Index:
packages/Python/lld
valentinagiusti added a comment.
I am not sure what you mean, this is a pluggable command and as such it has to
be a dynamic loadable lib.
As for the wrong install name of the binary, I don't think I can fix it from
here, the SOVERSION is set by AddLLVM.cmake.
On which platform did you get this
Author: labath
Date: Wed Feb 1 10:43:22 2017
New Revision: 293779
URL: http://llvm.org/viewvc/llvm-project?rev=293779&view=rev
Log:
Fix android build of the new process launcher
Android does not define the "cross-platform" symbol PT_TRACE_ME. Define
it ourselves, so we can keep the rest of the c
Author: kamil
Date: Wed Feb 1 10:02:55 2017
New Revision: 293774
URL: http://llvm.org/viewvc/llvm-project?rev=293774&view=rev
Log:
Do not pass non-POD type variables through variadic function
Summary:
Cannot pass object of non-POD type 'const CMIUtilString' through variadic
function.
This beha
krytarowski updated this revision to Diff 86644.
krytarowski edited the summary of this revision.
krytarowski added a comment.
Replace SetErrorDescriptionn(errMsg); with SetErrorDescription(errMsg);
Repository:
rL LLVM
https://reviews.llvm.org/D29256
Files:
tools/lldb-mi/MICmnBase.cpp
to
sylvestre.ledru added a comment.
Like llvm or lldb in general, just integrate it into liblldb?
By the way, liblldb-intel-mpxtable.so-5.0 is incorrect should be
liblldb-intel-mpxtable.so.5.0
Repository:
rL LLVM
https://reviews.llvm.org/D29078
__
valentinagiusti added a comment.
Do you have a better proposal?
Repository:
rL LLVM
https://reviews.llvm.org/D29078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sylvestre.ledru added a comment.
This change is creating a new library
usr/lib/llvm-5.0/bin/liblldb-intel-mpxtable.so on GNU/Linux 64b
That sounds pretty specific, is that really something that we want to do?
Repository:
rL LLVM
https://reviews.llvm.org/D29078
Author: kamil
Date: Wed Feb 1 08:35:08 2017
New Revision: 293770
URL: http://llvm.org/viewvc/llvm-project?rev=293770&view=rev
Log:
Document that LaunchProcessPosixSpawn is used on NetBSD
No functional change.
Sponsored by
Modified:
lldb/trunk/source/Host/common/Host.cpp
Modified: lldb/tr
Author: kamil
Date: Wed Feb 1 08:30:40 2017
New Revision: 293768
URL: http://llvm.org/viewvc/llvm-project?rev=293768&view=rev
Log:
Transform ProcessLauncherLinux to ProcessLauncherPosixFork
Summary:
Use ProcessLauncherPosixFork in Linux and NetBSD.
Changes to ProcessLauncherLinux:
- Limit pers
Author: ismail
Date: Wed Feb 1 07:33:50 2017
New Revision: 293767
URL: http://llvm.org/viewvc/llvm-project?rev=293767&view=rev
Log:
Fix missing include after r293660
Modified:
lldb/trunk/tools/intel-mpx/IntelMPXTablePlugin.cpp
Modified: lldb/trunk/tools/intel-mpx/IntelMPXTablePlugin.cpp
URL
38 matches
Mail list logo
