[Lldb-commits] [lldb] r296733 - x86AssemblyInspectionEngine::AugmentUnwindPlanFromCallSite could access

Author: jmolenda Date: Wed Mar 1 23:08:10 2017 New Revision: 296733 URL: http://llvm.org/viewvc/llvm-project?rev=296733=rev Log: x86AssemblyInspectionEngine::AugmentUnwindPlanFromCallSite could access the byte past the end of the buffer it had been given. ASAN catch. Modified:

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

jingham added a comment. Also, it would be good to add a test that ensures that calling "process handle" actually passes the right thing to your SendSignalsToIgnore. https://reviews.llvm.org/D30520 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

jingham added a comment. Of course, the default implementation would do nothing, and you would override it with your GDB remote protocol specific version. https://reviews.llvm.org/D30520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

jingham added a comment. The ability to send a set of signals for the remote stub to ignore isn't inherently specific to the GDB Remote protocol. Some other remote protocol could very well implement the same functionality. SendSignalsToIgnoreIfNeeded seems like it should be in Process, and

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

eugene created this revision. If QPassSignals packaet is supported by lldb-server, lldb-client will utilize it and ask the server to ignore signals that don't require stops or notifications. Such signals will be immediately re-injected into inferior to continue normal execution.

Re: [Lldb-commits] [PATCH] D30515: Made GetClangTargetCPU() const.

lgtm On Wed, Mar 1, 2017 at 4:26 PM Jason Majors via Phabricator via lldb-commits wrote: > jmajors created this revision. > > It does not change members or call non-const members. > HostInfo::GetArchitecture() returns a const object ref (maybe others?), > which

[Lldb-commits] [PATCH] D30515: Made GetClangTargetCPU() const.

jmajors created this revision. It does not change members or call non-const members. HostInfo::GetArchitecture() returns a const object ref (maybe others?), which can't access the non-const function. https://reviews.llvm.org/D30515 Files: include/lldb/Core/ArchSpec.h

[Lldb-commits] [lldb] r296717 - Fix various warnings. NFC

Author: zturner Date: Wed Mar 1 18:05:25 2017 New Revision: 296717 URL: http://llvm.org/viewvc/llvm-project?rev=296717=rev Log: Fix various warnings. NFC Modified: lldb/trunk/source/Commands/CommandObjectFrame.cpp lldb/trunk/source/Commands/CommandObjectType.cpp

[Lldb-commits] [lldb] r296693 - Make it clear what you should modify when you copy any of these sample

Author: jingham Date: Wed Mar 1 16:23:30 2017 New Revision: 296693 URL: http://llvm.org/viewvc/llvm-project?rev=296693=rev Log: Make it clear what you should modify when you copy any of these sample test cases. Modified:

[Lldb-commits] [lldb] r296692 - Add a test to ensure that SBFrame::Disassemble produces some output.

Author: jingham Date: Wed Mar 1 16:18:37 2017 New Revision: 296692 URL: http://llvm.org/viewvc/llvm-project?rev=296692=rev Log: Add a test to ensure that SBFrame::Disassemble produces some output. Added:

[Lldb-commits] [lldb] r296669 - Add a sample_test directory with simple starter

Author: jingham Date: Wed Mar 1 14:25:48 2017 New Revision: 296669 URL: http://llvm.org/viewvc/llvm-project?rev=296669=rev Log: Add a sample_test directory with simple starter test cases for standard and "inline" tests. Added: lldb/trunk/packages/Python/lldbsuite/test/sample_test/

[Lldb-commits] [lldb] r296611 - Mark TestYMMRegister as no_debug_info_test

Author: labath Date: Wed Mar 1 05:18:59 2017 New Revision: 296611 URL: http://llvm.org/viewvc/llvm-project?rev=296611=rev Log: Mark TestYMMRegister as no_debug_info_test We don't need to run this test multiple times to check whether we can read a register. Modified:

[Lldb-commits] [PATCH] D30453: test: pass correct objcopy and ar paths to the test runner

This revision was automatically updated to reflect the committed changes. Closed by commit rL296593: test: pass correct objcopy and ar paths to the test runner (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30453?vs=90008=90134#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D30402: Modernize Enable/DisableLogChannel interface a bit

This revision was automatically updated to reflect the committed changes. Closed by commit rL296592: Modernize Enable/DisableLogChannel interface a bit (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30402?vs=9=90132#toc Repository: rL LLVM

[Lldb-commits] [lldb] r296595 - Fix gcc compilation of LogTest.cpp

Author: labath Date: Wed Mar 1 04:08:51 2017 New Revision: 296595 URL: http://llvm.org/viewvc/llvm-project?rev=296595=rev Log: Fix gcc compilation of LogTest.cpp Modified: lldb/trunk/unittests/Core/LogTest.cpp Modified: lldb/trunk/unittests/Core/LogTest.cpp URL:

[Lldb-commits] [lldb] r296592 - Modernize Enable/DisableLogChannel interface a bit

Author: labath Date: Wed Mar 1 04:08:40 2017 New Revision: 296592 URL: http://llvm.org/viewvc/llvm-project?rev=296592=rev Log: Modernize Enable/DisableLogChannel interface a bit Summary: Use StringRef and ArrayRef where possible. This adds an accessor to the Args class to get a view of the

[Lldb-commits] [lldb] r296593 - test: pass correct objcopy and ar paths to the test runner

Author: labath Date: Wed Mar 1 04:08:44 2017 New Revision: 296593 URL: http://llvm.org/viewvc/llvm-project?rev=296593=rev Log: test: pass correct objcopy and ar paths to the test runner Summary: The test runner has code to autodetect this, but it's not very smart -- in particular, it fails in