labath added a comment.
I like the idea of adding boilerplate first, so that we can than better focus
on the important stuff later. However, I think you've have gone a bit too far
with it -- you introduce a lot of functions I am pretty sure will not be
necessary for your case, or that should be
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
At one point we will need to come up with a better way to control these
features.
Repository:
rL LLVM
https://reviews.llvm.org/D31146
___
lld
krytarowski added a comment.
In https://reviews.llvm.org/D31138#706216, @labath wrote:
> I like the idea of adding boilerplate first, so that we can than better focus
> on the important stuff later. However, I think you've have gone a bit too far
> with it -- you introduce a lot of functions I
krytarowski added a comment.
I'm still evaluating whether to implement on the kernel side
`PT_SET_SIGPASS`/`PT_GET_SIGPASS`. Some software like floating point can use it
heavily.
Repository:
rL LLVM
https://reviews.llvm.org/D31146
___
lldb-comm
labath added a comment.
In https://reviews.llvm.org/D31129#705597, @zturner wrote:
> See what you think about this. I've created a folder called `Mocks` under
> `Utility`, and created a new target out of it. `UtilityTests` links against
> it, and so does `InterpreterTests`. To do this I had
labath added a comment.
In https://reviews.llvm.org/D31146#706249, @krytarowski wrote:
> I'm still evaluating whether to implement on the kernel side
> `PT_SET_SIGPASS`/`PT_GET_SIGPASS`. Some software like floating point can use
> it heavily.
Also there are programs which use SIGALRM or realt
Author: labath
Date: Tue Mar 21 08:49:50 2017
New Revision: 298375
URL: http://llvm.org/viewvc/llvm-project?rev=298375&view=rev
Log:
Replace std::ofstream with llvm::raw_fd_ostream
Summary:
ofstream does not handle paths with non-ascii characters correctly on
windows, so I am switching these to l
Author: labath
Date: Tue Mar 21 08:49:45 2017
New Revision: 298374
URL: http://llvm.org/viewvc/llvm-project?rev=298374&view=rev
Log:
Remove ProcFileReader
This removes the last usage of ProcFileReader from NativeProcessLinux
and then deletes the class itself.
Removed:
lldb/trunk/source/Plugi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298375: Replace std::ofstream with llvm::raw_fd_ostream
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D31079?vs=92144&id=92484#toc
Repository:
rL LLVM
https://reviews.llvm.
krytarowski added inline comments.
Comment at: source/Host/openbsd/HostInfoOpenBSD.cpp:20
+
+uint32_t HostInfoOpenBSD::GetMaxThreadNameLength() { return 16; }
+
The need for this has been removed in trunk.
Repository:
rL LLVM
https://reviews.llvm.org/D31131
krytarowski updated this revision to Diff 92492.
krytarowski added a comment.
Style fix.
Repository:
rL LLVM
https://reviews.llvm.org/D31138
Files:
source/Plugins/Process/CMakeLists.txt
source/Plugins/Process/NetBSD/CMakeLists.txt
source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
krytarowski updated this revision to Diff 92490.
krytarowski edited the summary of this revision.
krytarowski added a comment.
Cut down the unused functions from the Native Process NetBSD Plugin.
Repository:
rL LLVM
https://reviews.llvm.org/D31138
Files:
source/Plugins/Process/CMakeLists.t
krytarowski created this revision.
krytarowski added a project: LLDB.
NetBSD can share the same logging functionality with Linux and FreeBSD.
Sponsored by
Repository:
rL LLVM
https://reviews.llvm.org/D31191
Files:
source/Initialization/SystemInitializerCommon.cpp
Index: source/Initiali
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Heh... I did not expect it would get this small, but ok. :)
Repository:
rL LLVM
https://reviews.llvm.org/D31138
___
lldb-commits mailing list
krytarowski created this revision.
krytarowski added a project: LLDB.
NetBSD is a modern ELF UNIX-like system.
There is requires DynamicLoaderPOSIXDYLD e.g. for ELF AUXV reading from the
client.
Sponsored by
Repository:
rL LLVM
https://reviews.llvm.org/D31192
Files:
source/Plugins/Dyna
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I think you should group these "add netbsd to a list" type of changes into
single diff. There's not point in reviewing each separately.
Repository:
rL LLVM
https://reviews.llvm.org/D31192
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
It looks like you are bundling two changes into one patch, one to move the
StopInfoOverrideCallback from ArchSpec to Process, and one to change how the
help for the list of archite
Author: rnk
Date: Tue Mar 21 12:09:20 2017
New Revision: 298399
URL: http://llvm.org/viewvc/llvm-project?rev=298399&view=rev
Log:
Update for LLVM API rename of AttributeSet -> AttributeList
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86AB
zturner added a comment.
The architecture help change snuck in, I already removed it locally but didn't
re-upload.
As for why I'm trying to get this out of `ArchSpec`, it turns out `ArchSpec` is
one of the biggest causes of dependency cycles. It's used all over the place,
which triggers a dep
Author: rnk
Date: Tue Mar 21 12:15:50 2017
New Revision: 298402
URL: http://llvm.org/viewvc/llvm-project?rev=298402&view=rev
Log:
Remove stray paren that got in while attempting to fix the build for
AttributeList
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptR
Author: kamil
Date: Tue Mar 21 12:25:47 2017
New Revision: 298405
URL: http://llvm.org/viewvc/llvm-project?rev=298405&view=rev
Log:
Add NetBSD case in Entry::Type::ThreadID
Summary:
NetBSD native threads are printed as 64-bit unsigned integers.
The underlying system type of a thread identity is
Author: kamil
Date: Tue Mar 21 12:26:55 2017
New Revision: 298406
URL: http://llvm.org/viewvc/llvm-project?rev=298406&view=rev
Log:
Enable ProcessPOSIXLog on NetBSD
Summary:
NetBSD can share the same logging functionality with Linux and FreeBSD.
Sponsored by
Reviewers: labath, emaste, joerg,
Author: kamil
Date: Tue Mar 21 12:27:59 2017
New Revision: 298407
URL: http://llvm.org/viewvc/llvm-project?rev=298407&view=rev
Log:
Enable AUXV and QPassSignals in gdb-remote for NetBSD
Summary:
NetBSD is an ELF platform and it uses Elf Auxiliary Vector like Linux and other
modern BSDs.
While t
Author: kamil
Date: Tue Mar 21 12:30:47 2017
New Revision: 298408
URL: http://llvm.org/viewvc/llvm-project?rev=298408&view=rev
Log:
Add stub for PluginProcessNetBSD
Summary:
This is the base for introduction of further features to support Process
Tracing on NetBSD, in local and remote setup.
Th
krytarowski added a comment.
This approach is easier for my to understand each change and make sure that
it's actually needed and correct (or looking like a proper solution).
There are 2 similar changes left I don't fully understand and code interfering
with the OpenBSD platform addition that I
Author: kamil
Date: Tue Mar 21 12:39:15 2017
New Revision: 298409
URL: http://llvm.org/viewvc/llvm-project?rev=298409&view=rev
Log:
Create instance of DynamicLoaderPOSIXDYLD on NetBSD
Summary:
NetBSD is a modern ELF UNIX-like system.
There is requires DynamicLoaderPOSIXDYLD e.g. for ELF AUXV rea
jingham added a comment.
None of this isn't modeling the situation particularly clearly, since we have
"architecture specific modifications to general behaviors" that aren't coming
in through plugins so that it would be easy to modify the behavior for new
architectures. Instead, we're requiring
Thanks for the suggestions! Not sure if I'll be able to make those changes
before tomorrow EOD, and after that I will be out for ~2 weeks, so if time
doesn't permit, I may not follow up with another patch until after I get
back.
On Tue, Mar 21, 2017 at 11:19 AM Jim Ingham via Phabricator <
revi..
eugene accepted this revision.
eugene added a comment.
This revision is now accepted and ready to land.
I like how much code you deleted.
https://reviews.llvm.org/D31129
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org
Author: zturner
Date: Tue Mar 21 13:25:04 2017
New Revision: 298412
URL: http://llvm.org/viewvc/llvm-project?rev=298412&view=rev
Log:
Move StringList from Core -> Utility.
Added:
lldb/trunk/include/lldb/Utility/StringList.h
lldb/trunk/source/Utility/StringList.cpp
Removed:
lldb/trunk/
Author: zturner
Date: Tue Mar 21 13:45:42 2017
New Revision: 298419
URL: http://llvm.org/viewvc/llvm-project?rev=298419&view=rev
Log:
Fix build broken by StringList move.
Modified:
lldb/trunk/include/lldb/Utility/StringList.h
lldb/trunk/source/Symbol/Symtab.cpp
Modified: lldb/trunk/inclu
Author: penryu
Date: Tue Mar 21 17:08:16 2017
New Revision: 298451
URL: http://llvm.org/viewvc/llvm-project?rev=298451&view=rev
Log:
Mirror CMake changes from r298412 to Xcode project
Mlldb.xcodeproj/project.pbxproj
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/tru
Author: zturner
Date: Tue Mar 21 17:46:46 2017
New Revision: 298455
URL: http://llvm.org/viewvc/llvm-project?rev=298455&view=rev
Log:
[deps script] Sort cycles by the difficulty of breaking.
When passing --discover-cycles and --show-counts, it displays
the number of dependencies between each hop
Author: zturner
Date: Tue Mar 21 19:27:24 2017
New Revision: 298465
URL: http://llvm.org/viewvc/llvm-project?rev=298465&view=rev
Log:
Delete the remainder of platform specific code in FileSpec.
Differential Revision: https://reviews.llvm.org/D31129
Added:
lldb/trunk/unittests/Utility/Mocks/
Author: zturner
Date: Tue Mar 21 19:27:54 2017
New Revision: 298466
URL: http://llvm.org/viewvc/llvm-project?rev=298466&view=rev
Log:
Break the cycle between Host and PluginProcessUtility.
There are only two users of NativeRegisterContextRegisterInfo,
and both are in process plugins. Moving this
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298465: Delete the remainder of platform specific code in
FileSpec. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D31129?vs=92373&id=92577#toc
Repository:
rL LLVM
https://
Hello everyone,
Below are some buildbot numbers for the week of 03/05/2017 - 03/11/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Hello everyone,
Below are some buildbot numbers for the last week of 03/12/2017 -
03/18/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
krytarowski created this revision.
krytarowski added a project: LLDB.
Herald added a subscriber: mgorny.
NetBSD ships with NativeProcessNetBSD inherited from NativeProcessProtocol.
Link Plugins/Process/gdb-remote with lldbPluginProcessNetBSD in order to resolve
correctly the linking to Launch an
39 matches
Mail list logo
