labath added a comment.
Thanks for digging into this, I've learned something new today. Fixing this
with a cast seems reasonable then.
https://reviews.llvm.org/D32137
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
labath added a comment.
A test would infinitely times more valuable then a demo script. What is the
tiniest core file you can produce on NetBSD? (on linux we've gotten them down
to about 20K) Then we could check that in and write a test for it...
Repository:
rL LLVM
https://reviews.llvm.org
ravitheja updated this revision to Diff 95930.
ravitheja added a comment.
New diff with requested changes.
https://reviews.llvm.org/D29581
Files:
include/lldb/API/LLDB.h
include/lldb/API/SBDefines.h
include/lldb/API/SBError.h
include/lldb/API/SBProcess.h
include/lldb/API/SBStructuredD
ravitheja marked 7 inline comments as done.
ravitheja added inline comments.
Comment at: include/lldb/API/SBProcess.h:251
+ /// supported. To obtain the actual used trace options please
+ /// use the GetTraceConfig API. For the custom parameters, only
+ /// the par
krytarowski added a comment.
In https://reviews.llvm.org/D32149#731887, @labath wrote:
> A test would infinitely times more valuable then a demo script. What is the
> tiniest core file you can produce on NetBSD? (on linux we've gotten them down
> to about 20K) Then we could check that in and wr
kettenis added a comment.
Generally looks reasonable to me. A few comments inline.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1374
+else if ((note.n_name == LLDB_NT_OWNER_NETBSDCORE) &&
+ (note.n_type == LLDB_NT_NETBSD_NT_PROCINFO)) {
//
Author: labath
Date: Thu Apr 20 06:27:58 2017
New Revision: 300833
URL: http://llvm.org/viewvc/llvm-project?rev=300833&view=rev
Log:
Add libc++ category the three more tests
I thought my previous commit got the last ones but somehow I missed
these. This also resurrects TestDataFormatterLibcxxSet,
Author: labath
Date: Thu Apr 20 06:28:07 2017
New Revision: 300834
URL: http://llvm.org/viewvc/llvm-project?rev=300834&view=rev
Log:
Make TestStaticVariables XFAIL more specific
The test fails because an older clang did not emit the required debug
info (I am not sure when this got added, but clan
kettenis added a comment.
In https://reviews.llvm.org/D32149#731887, @labath wrote:
> A test would infinitely times more valuable then a demo script. What is the
> tiniest core file you can produce on NetBSD? (on linux we've gotten them down
> to about 20K) Then we could check that in and write
krytarowski added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1374
+else if ((note.n_name == LLDB_NT_OWNER_NETBSDCORE) &&
+ (note.n_type == LLDB_NT_NETBSD_NT_PROCINFO)) {
// Set the elf OS version to NetBSD. Also clear the
kettenis added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1374
+else if ((note.n_name == LLDB_NT_OWNER_NETBSDCORE) &&
+ (note.n_type == LLDB_NT_NETBSD_NT_PROCINFO)) {
// Set the elf OS version to NetBSD. Also clear the ven
Author: labath
Date: Thu Apr 20 07:30:30 2017
New Revision: 300837
URL: http://llvm.org/viewvc/llvm-project?rev=300837&view=rev
Log:
Skip TestLibCxxAtomic with gcc
older versions of libc++ (still used on some linux systems) are not
compatible with gcc.
Modified:
lldb/trunk/packages/Python/l
Author: labath
Date: Thu Apr 20 07:30:18 2017
New Revision: 300836
URL: http://llvm.org/viewvc/llvm-project?rev=300836&view=rev
Log:
Recompute ArchSpec core after MergeFrom
Summary:
MergeFrom was updating the architecture if the target triple did not
have it set. However, it was leaving the core
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300836: Recompute ArchSpec core after MergeFrom (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D32221?vs=95722&id=95941#toc
Repository:
rL LLVM
https://reviews.llvm.org/D322
krytarowski added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1374
+else if ((note.n_name == LLDB_NT_OWNER_NETBSDCORE) &&
+ (note.n_type == LLDB_NT_NETBSD_NT_PROCINFO)) {
// Set the elf OS version to NetBSD. Also clear the
labath added a comment.
In https://reviews.llvm.org/D32149#731920, @krytarowski wrote:
> In https://reviews.llvm.org/D32149#731887, @labath wrote:
>
> > A test would infinitely times more valuable then a demo script. What is the
> > tiniest core file you can produce on NetBSD? (on linux we've go
Note that getAsInteger returns false on success, so be careful!
On Thu, Apr 20, 2017 at 6:09 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> In https://reviews.llvm.org/D32149#731920, @krytarowski wrote:
>
> > In https://reviews.llvm.org/D32149#7318
labath added a comment.
Jim, Jason, could one of you take a look at this please?
This part of the code is not really my specialty, so I'd appreciate your
thoughts on this.
https://reviews.llvm.org/D32022
___
lldb-commits mailing list
lldb-commits@
davide added a comment.
In https://reviews.llvm.org/D32137#731727, @labath wrote:
> Thanks for digging into this, I've learned something new today. Fixing this
> with a cast seems reasonable then.
Me too, apparently C++ integer promotion is less obvious than I thought ;)
https://reviews.llvm
labath created this revision.
Herald added a subscriber: aprantl.
Since r299449 "Make RuntimeDyld honor the ProcessAllSections flag." we
have been experiencing an assertion failure when evaluating expressions
on linux.
Based on my investigation, the sequence of events is as follows:
- lldb sets
Author: davide
Date: Thu Apr 20 09:45:33 2017
New Revision: 300845
URL: http://llvm.org/viewvc/llvm-project?rev=300845&view=rev
Log:
[Utility] Placate another GCC warning.
Differential Revision: https://reviews.llvm.org/D32137
Modified:
lldb/trunk/source/Plugins/Process/Utility/RegisterCont
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300845: [Utility] Placate another GCC warning. (authored by
davide).
Changed prior to commit:
https://reviews.llvm.org/D32137?vs=95485&id=95961#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3213
Author: kamil
Date: Thu Apr 20 11:35:36 2017
New Revision: 300853
URL: http://llvm.org/viewvc/llvm-project?rev=300853&view=rev
Log:
Resurrect LLDB Standalone build on NetBSD
Include CheckIncludeFile for check_include_file() in CMake.
Detect in CMake.
This header is available on NetBSD.
Modifie
Author: spyffe
Date: Thu Apr 20 13:07:51 2017
New Revision: 300862
URL: http://llvm.org/viewvc/llvm-project?rev=300862&view=rev
Log:
Changed a use of APInt::getSignBit to APInt::getSignMask.
Modified:
lldb/trunk/source/Core/Scalar.cpp
Modified: lldb/trunk/source/Core/Scalar.cpp
URL:
http://
scott.smith created this revision.
ConstStrings are immutable, so there is no need to grab even a reader lock in
order to read the length field.
Repository:
rL LLVM
https://reviews.llvm.org/D32306
Files:
source/Utility/ConstString.cpp
Index: source/Utility/ConstString.cpp
==
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
Approving the LLDB/Linux working again.
Thanks for digging in to this Pavel. Greg Clayton appears to have hit the same
issue recently too. Digging through bugs.llvm.org, it looks like this mig
jasonmolenda added a comment.
Sorry Pavel, I kept meaning to look at this patch this week but hadn't yet. I
will later today. When I read over your description of the problem, it sounded
like a good fix - haven't looked at the code yet.
https://reviews.llvm.org/D32022
Author: jingham
Date: Thu Apr 20 16:51:27 2017
New Revision: 300902
URL: http://llvm.org/viewvc/llvm-project?rev=300902&view=rev
Log:
Add an example command to toggle between disassembly-only and source mode.
Sometimes you are debugging in source, but you really only want to see
the disassembly.
scott.smith created this revision.
UniqueCStringMap "sorts" the entries for fast lookup, but really it only cares
about uniqueness. ConstString can be compared by pointer along, rather than
with strcmp, resulting in much faster comparisons. Change the interface to
take ConstString instead, an
Hello everyone,
Below are some buildbot numbers for the week of 04/02/2017 - 04/08/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Hello everyone,
Below are some buildbot numbers for the last week of 04/09/2017 -
04/15/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
jasonmolenda added a comment.
I'd recommend Greg Clayton as a reviewer.
Repository:
rL LLVM
https://reviews.llvm.org/D32316
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda added a comment.
You should also add lldb-commits as a subscriber, fwiw, so
comments/questions/etc are cc:'ed to the -commits list.
Repository:
rL LLVM
https://reviews.llvm.org/D32316
___
lldb-commits mailing list
lldb-commits@lists
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This will break the Swift REPL as it relies on debug info and we won't be told
about the ".debug_XXX" or "__debug_XXX" sections if we disable this. Jim or
Sean should verify this
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Very close. A few misuses of ConstString and this will be good to go.
Comment at: include/lldb/Interpreter/Property.h:43
+ ConstString GetName() const { return
jasonmolenda added a comment.
Hi Pavel, I'd document the new flag in include/lldb/Core/Address.h where we
have documentation for the other flags being used.
It seems like we're fixing this a little indirectly, and I'm not sure it's the
best approach. I want to make sure I understand the situat
36 matches
Mail list logo
