labath added a comment.
Ok, then let's keep them. I don't mind changing all call sites -- having a
separate category object is the cleanest solution with least magic. However see
my comments about category naming and merging.
Comment at: unittests/Core/TimerTest.cpp:39
s
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Makes sense. Thank you for the explanation (I assumed homogeneous aggregate and
vector are the same).
https://reviews.llvm.org/D32813
labath created this revision.
Herald added a subscriber: aprantl.
Debug info sections, (or non-SHF_ALLOC sections in general) should be
linked as if their load address was zero to emulate the behavior of the
static linker.
I've made two tests for this: One checks that we are able to properly
proc
Author: labath
Date: Fri May 5 05:50:02 2017
New Revision: 302220
URL: http://llvm.org/viewvc/llvm-project?rev=302220&view=rev
Log:
ABISysV_arm64: compute return value for large vectors correctly
Summary:
Arm64 Procedure Call Standard specifies than only vectors up to 16 bytes
are stored in v0 (
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302220: ABISysV_arm64: compute return value for large
vectors correctly (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32813?vs=97676&id=97927#toc
Repository:
rL LLVM
https
labath added inline comments.
Comment at: source/Symbol/Symtab.cpp:257
-// The "const char *" in "class_contexts" must come from a
-// ConstString::GetCString()
-std::set class_contexts;
-UniqueCStringMap mangled_name_to_index;
-std::vector symbol_contexts(n
labath accepted this revision.
labath added a comment.
I can do the pushing. :)
Thanks for the patch.
Comment at: include/lldb/Utility/TaskPool.h:89
+void TaskMapOverInt(size_t begin, size_t end,
+std::function const &func);
Making this a
Author: labath
Date: Fri May 5 06:16:59 2017
New Revision: 302223
URL: http://llvm.org/viewvc/llvm-project?rev=302223&view=rev
Log:
Add TaskMap for iterating a function over a set of integers
Summary:
Many parallel tasks just want to iterate over all the possible numbers from 0
to N-1. Rather
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302223: Add TaskMap for iterating a function over a set of
integers (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32757?vs=97907&id=97931#toc
Repository:
rL LLVM
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302225: Fix segfault resulting from empty print prompt
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32421?vs=97717&id=97937#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: labath
Date: Fri May 5 06:51:21 2017
New Revision: 302225
URL: http://llvm.org/viewvc/llvm-project?rev=302225&view=rev
Log:
Fix segfault resulting from empty print prompt
Summary:
I have found a way to segfault lldb in 7 keystrokes! Steps to reproduce:
1) Launch lldb
2) Type `print` and
labath added a comment.
Committed as 302225. I've fixed the indentation in your test, and added a
couple of decorators to match other pexpect tests. Thanks for the patch!
Repository:
rL LLVM
https://reviews.llvm.org/D32421
___
lldb-commits maili
labath added a comment.
Jason, any thoughts on my comments above?
https://reviews.llvm.org/D32022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
scott.smith added inline comments.
Comment at: source/Symbol/Symtab.cpp:257
-// The "const char *" in "class_contexts" must come from a
-// ConstString::GetCString()
-std::set class_contexts;
-UniqueCStringMap mangled_name_to_index;
-std::vector symbol_conte
Don't even need a template. Use llvm::function_ref
On Fri, May 5, 2017 at 4:30 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL302223: Add TaskMap for iterating a function over a set
scott.smith updated this revision to Diff 97973.
scott.smith marked 2 inline comments as done.
scott.smith added a comment.
remove same-name-different-site support from Timer::Category
Repository:
rL LLVM
https://reviews.llvm.org/D32823
Files:
include/lldb/Core/Timer.h
source/API/SystemI
scott.smith added inline comments.
Comment at: unittests/Core/TimerTest.cpp:39
std::this_thread::sleep_for(std::chrono::milliseconds(10));
-Timer t2("CAT1", "");
+// Explicitly testing the same category as above.
+static Timer::Category tcat1b("CAT1");
--
clayborg added a comment.
What are the measured improvements here? We can't slow things down on any
platforms. I know MacOS didn't respond well to making demangling run in
parallel. I want to see some numbers here. And please don't quote numbers with
tcmalloc or any special allocator unless you
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm, thank you.
Comment at: unittests/Core/TimerTest.cpp:39
std::this_thread::sleep_for(std::chrono::milliseconds(10));
-Timer t2("CAT1", "");
+// Explicitly te
Author: fjricci
Date: Fri May 5 12:18:08 2017
New Revision: 302260
URL: http://llvm.org/viewvc/llvm-project?rev=302260&view=rev
Log:
Add missing 'arch' key to valid qHostInfo keys
Summary:
'arch' is a valid qHostInfo key, but the unit
test for qHostInfo did not include it in the set of possible
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302260: Add missing 'arch' key to valid qHostInfo keys
(authored by fjricci).
Changed prior to commit:
https://reviews.llvm.org/D32711?vs=97322&id=97983#toc
Repository:
rL LLVM
https://reviews.llvm.
scott.smith marked an inline comment as done.
scott.smith added a comment.
In https://reviews.llvm.org/D32820#747309, @clayborg wrote:
> What are the measured improvements here? We can't slow things down on any
> platforms. I know MacOS didn't respond well to making demangling run in
> parallel
clayborg added a comment.
I would suggest adding Pavel and Tamas, or anyone that has contributed to
DynamicLoaderPOSIXDYLD as this will affect them.
Repository:
rL LLVM
https://reviews.llvm.org/D32597
___
lldb-commits mailing list
lldb-commits@l
Author: cbieneman
Date: Fri May 5 15:35:50 2017
New Revision: 302282
URL: http://llvm.org/viewvc/llvm-project?rev=302282&view=rev
Log:
Fix UDP Socket connections
Some of the refactoring in r301492 broke UDP socket connections. This is a
partial revert of that refactoring. At some point I'll spe
Author: lhames
Date: Fri May 5 17:42:13 2017
New Revision: 302314
URL: http://llvm.org/viewvc/llvm-project?rev=302314&view=rev
Log:
Add DidStartExecuting/WillFinishExecuting methods to Expression.
These methods can be used by the derived expression types to perform expression
specific and/or lan
Author: jingham
Date: Fri May 5 18:38:26 2017
New Revision: 302323
URL: http://llvm.org/viewvc/llvm-project?rev=302323&view=rev
Log:
Added "info threads", "thread 1" and "apropos".
Modified:
lldb/trunk/www/lldb-gdb.html
Modified: lldb/trunk/www/lldb-gdb.html
URL:
http://llvm.org/viewvc/llv
jmajors created this revision.
Herald added a subscriber: mgorny.
This is a new C++ test framework based on Google Test, and one working
example test.
The intention is to replace the existing tests in
packages/Python/lldbsuite/test/tools/lldb-server/ with this suite
and use this framework for all
Author: jingham
Date: Fri May 5 20:15:47 2017
New Revision: 302327
URL: http://llvm.org/viewvc/llvm-project?rev=302327&view=rev
Log:
Be a little more permissive in DynamicLoaderMacOS::CanLoadImage
If we can't find the "is dyld locked" symbol, assume it is safe
to load the image unless we only ha
28 matches
Mail list logo
