krytarowski added a comment.
Can we go with this change?
Repository:
rL LLVM
https://reviews.llvm.org/D32149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski updated this revision to Diff 100035.
krytarowski added a comment.
Rebase to HEAD.
Apply "Error" -> "Status" rename.
Repository:
rL LLVM
https://reviews.llvm.org/D32149
Files:
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/Process/elf-core/ProcessElfCore.cpp
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Oh, yeah, check the checkbox, Jim...
https://reviews.llvm.org/D33283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jingham added a comment.
That looks right to me, and is much nicer to read.
I think "plan failure" once you've actually kicked off the execution of a
function calling thread plan is theoretical, there are plenty of ways the plan
can fail, though at present all the ways I can think of would
tatyana-krasnukha added a comment.
It can make sense to add
static_assert(eReturnStatusStarted != result);
after cmd_obj->Execute() invocation at CommandInterpreter::HandleCommand, do
you think?
Repository:
rL LLVM
https://reviews.llvm.org/D32366
Author: sas
Date: Tue May 23 14:22:31 2017
New Revision: 303677
URL: http://llvm.org/viewvc/llvm-project?rev=303677=rev
Log:
Fix bad change in RenderScriptx86ABIFixups.cpp, forgot to change everything
necessary
Summary: I didn't change all instances of i to I in this loop. I am a bad
person
Author: sas
Date: Tue May 23 13:54:03 2017
New Revision: 303674
URL: http://llvm.org/viewvc/llvm-project?rev=303674=rev
Log:
hange RenderScriptx86ABIFixups.cpp to use llvm::AttributeList iterator
LLVM::AttributeList recently had getNumSlots() removed, which broke the
build. This fixes the build
CreateStructuredDictionary() needs the GIL to be held because it calls
PyList_GET_SIZE from a nested function.
ScriptInterpreterPython.cpp.patch
Description: ScriptInterpreterPython.cpp.patch
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg added a comment.
Looks like we are down to just running clang format on the code so the R"(
strings don't go over 80 chars and this is good to go from me.
https://reviews.llvm.org/D32585
___
lldb-commits mailing list
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Very close and overall very nice, just a few implementation details to take
care of.
Comment at: include/lldb/API/SBStructuredData.h:20-28
+ enum Type {
+
Done. I have also added a little change which allow to use debug_info section
when eh_frame is absent. This case really can take place on some platforms.
Thanks,
Tatyana
From: Abid, Hafiz [mailto:hafiz_a...@mentor.com]
Sent: Tuesday, 23 May, 2017 3:31 PM
To: Tatyana Krasnukha
clayborg added a comment.
Add a test and fix the minor things as suggested and this will be good to go.
https://reviews.llvm.org/D33426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Pavel's right, it would be good to add a test case. You could modify the test
case in packages/Python/lldbsuite/test/functionalities/thread/num_threads/ to
this end. Note this
Author: jingham
Date: Tue May 23 11:11:21 2017
New Revision: 303643
URL: http://llvm.org/viewvc/llvm-project?rev=303643=rev
Log:
We shouldn't put actual tests in directories that contain
other test directories.
Added:
ravitheja updated this revision to Diff 99891.
ravitheja added a comment.
Modifying string literals in Unit tests.
https://reviews.llvm.org/D32585
Files:
docs/lldb-gdb-remote.txt
include/lldb/API/SBTrace.h
include/lldb/Core/TraceOptions.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303627: Add support for new (3.0.11+) swigs (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D33409?vs=99755=99878#toc
Repository:
rL LLVM
https://reviews.llvm.org/D33409
Author: labath
Date: Tue May 23 05:55:17 2017
New Revision: 303627
URL: http://llvm.org/viewvc/llvm-project?rev=303627=rev
Log:
Add support for new (3.0.11+) swigs
Summary:
A change in swig 3.0.9 has caused it to generate modules incompatible
with us using them as __init__.py (bug #769). Swig
labath added inline comments.
Comment at:
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:400
+
+ HandlePacket(server, "jTraceStart:{\"buffersize\" : 8192,\"jparams\" :
{\"psb\" : 1,\"tracetech\" : \"intel-pt\"},\"metabuffersize\" :
8192,\"threadid\" :
ravitheja added inline comments.
Comment at:
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:400
+
+ HandlePacket(server, "jTraceStart:{\"buffersize\" : 8192,\"jparams\" :
{\"psb\" : 1,\"tracetech\" : \"intel-pt\"},\"metabuffersize\" :
8192,\"threadid\" :
labath added inline comments.
Comment at:
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:400
+
+ HandlePacket(server, "jTraceStart:{\"buffersize\" : 8192,\"jparams\" :
{\"psb\" : 1,\"tracetech\" : \"intel-pt\"},\"metabuffersize\" :
8192,\"threadid\" :
labath added a comment.
Sounds like an awesome feature.
Could you please add a test for it as well?
https://reviews.llvm.org/D33426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ravitheja updated this revision to Diff 99870.
ravitheja added a comment.
Updates from last review.
https://reviews.llvm.org/D32585
Files:
docs/lldb-gdb-remote.txt
include/lldb/API/SBTrace.h
include/lldb/Core/TraceOptions.h
include/lldb/Host/common/NativeProcessProtocol.h
ravitheja added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3293
+ if (custom_params_sp) {
+if (custom_params_sp->GetType() !=
StructuredData::Type::eTypeDictionary) {
+ error.SetErrorString("Invalid
23 matches
Mail list logo
