[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

2017-05-25 Thread Brian Gianforcaro via Phabricator via lldb-commits
bgianfo updated this revision to Diff 100365. bgianfo added a comment. Address Pavel's feedback, made the unit test more robust. This update increases the robustness of the new test I added. We ensure synchronization, and force the threads into the state we want them to be in by manually

[Lldb-commits] [lldb] r303965 - FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap

2017-05-25 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu May 25 22:15:46 2017 New Revision: 303965 URL: http://llvm.org/viewvc/llvm-project?rev=303965=rev Log: FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap In the absense of a more specific handler for TRAP_CAP (generated by ENOTCAPABLE or ECAPMODE while in capability

Re: [Lldb-commits] [PATCH] D33504: Fix FDE indexing while scan debug_info section

2017-05-25 Thread Robinson, Paul via lldb-commits
IANA lldb developer, but I should think lldb would want to understand a DWARF 4 .debug_frame section. (And it didn't change in DWARF 5, either!) --paulr > -Original Message- > From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf > Of Pavel Labath via lldb-commits >

[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

2017-05-25 Thread Jason Majors via Phabricator via lldb-commits
jmajors updated this revision to Diff 100288. jmajors marked an inline comment as done. jmajors added a comment. Made directory test more portable. https://reviews.llvm.org/D32930 Files: unittests/CMakeLists.txt unittests/tools/CMakeLists.txt unittests/tools/lldb-server/CMakeLists.txt

[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

2017-05-25 Thread Jason Majors via Phabricator via lldb-commits
jmajors updated this revision to Diff 100287. jmajors added a comment. Make inferior break more portable. Restrict tests to running on Linux, BSD, or Android systems. https://reviews.llvm.org/D32930 Files: unittests/CMakeLists.txt unittests/tools/CMakeLists.txt

[Lldb-commits] [lldb] r303907 - Fix bug #28898

2017-05-25 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Thu May 25 15:12:30 2017 New Revision: 303907 URL: http://llvm.org/viewvc/llvm-project?rev=303907=rev Log: Fix bug #28898 lldb: libedit produces garbled, unusable input on Linux Apply patch from Christos Zoulas, upstream libedit developer. It has been tested on NetBSD/amd64.

Re: [Lldb-commits] [PATCH] D33504: Fix FDE indexing while scan debug_info section

2017-05-25 Thread Pavel Labath via lldb-commits
+lldb-commits Yes, that is certainly a viable approach. If there is a subset of dwarf that we are capable of parsing correctly then it would be great to enable that. On 25 May 2017 at 16:46, Tatyana Krasnukha wrote: > This binary uses DWARF 4, that introduces two

[Lldb-commits] [lldb] r303854 - Revert "Fix FDE indexing while scan debug_info section."

2017-05-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu May 25 08:13:12 2017 New Revision: 303854 URL: http://llvm.org/viewvc/llvm-project?rev=303854=rev Log: Revert "Fix FDE indexing while scan debug_info section." This reverts commit r303847 as it introduces a number of regressions. Investigation has showed that we are

[Lldb-commits] [lldb] r303848 - Recommit "RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false"

2017-05-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu May 25 05:50:06 2017 New Revision: 303848 URL: http://llvm.org/viewvc/llvm-project?rev=303848=rev Log: Recommit "RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false" This is a resubmit of r303732, which was reverted due to a regression. The original patch

[Lldb-commits] [PATCH] D33283: RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false

2017-05-25 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL303848: Recommit "RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false" (authored by labath). Changed prior to commit: https://reviews.llvm.org/D33283?vs=100099=100221#toc Repository: rL

[Lldb-commits] [lldb] r303847 - Fix FDE indexing while scan debug_info section.

2017-05-25 Thread Hafiz Abid Qadeer via lldb-commits
Author: abidh Date: Thu May 25 05:21:29 2017 New Revision: 303847 URL: http://llvm.org/viewvc/llvm-project?rev=303847=rev Log: Fix FDE indexing while scan debug_info section. There are some differences between eh_frame and debug_frame formats that are not considered by

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

2017-05-25 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Affirmative. Tests should go in together with the feature they are testing. Repository: rL LLVM https://reviews.llvm.org/D32149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

2017-05-25 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Getting really close now. However, the debug trap issue is still not resolved. And we still have to figure out how to make sure the tests don't blow up on platforms that don't support debugging via lldb-server (i.e., anything except linux, android, netbsd). One option

[Lldb-commits] [PATCH] D33283: RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false

2017-05-25 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thanks for the explanation. I'll continue the discussion about the conditional breakpoint thingy on bug #33164, which I've just filed. https://reviews.llvm.org/D33283 ___ lldb-commits mailing list

Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section

2017-05-25 Thread Abid, Hafiz via lldb-commits
?I will commit on your behalf. Thanks, Abid From: Tatyana Krasnukha Sent: Wednesday, May 24, 2017 6:30 PM To: Abid, Hafiz; lldb-commits@lists.llvm.org Subject: RE: [Lldb-commits] Patch for fixing FDE indexing when scan