jasonmolenda added a comment.
Yeah, looks good. You'll only see this on i386 because the SysV ABI require
4-byte stack alignment. On x86_64 it's 16-byte so the compiler doesn't need to
emit the AND instruction to realign it. On darwin we required 16 byte
alignment on i386 too so we never saw
dlj created this revision.
dlj added projects: lld, clang.
Herald added subscribers: mehdi_amini, sanjoy.
The GoogleTest lit format accepts two parameters to its constructor: a
subdirectory to find test binaries, and a required suffix for the test
filenames. Typically, the config should look lik
Author: spyffe
Date: Thu Jun 29 17:39:17 2017
New Revision: 306773
URL: http://llvm.org/viewvc/llvm-project?rev=306773&view=rev
Log:
[Data formatters] Make NSSetM support both old- and new-style representation
NSSetM has two in-memory representations depending on what Foundation version
is in us
Author: penryu
Date: Thu Jun 29 16:33:40 2017
New Revision: 306765
URL: http://llvm.org/viewvc/llvm-project?rev=306765&view=rev
Log:
Fix some type-based warnings
Modified:
lldb/trunk/source/Commands/CommandObjectThread.cpp
lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
lldb/trunk/t
Author: jmolenda
Date: Thu Jun 29 15:50:53 2017
New Revision: 306752
URL: http://llvm.org/viewvc/llvm-project?rev=306752&view=rev
Log:
Update default cpu subtype for armv7 processes to armv7k, the most
likely cpu subtype at this point.
Modified:
lldb/trunk/tools/debugserver/source/RNBRemote.c
Author: jingham
Date: Thu Jun 29 11:54:40 2017
New Revision: 306725
URL: http://llvm.org/viewvc/llvm-project?rev=306725&view=rev
Log:
Timer.{h,cpp} moved, find them again in the project file.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxp
abhishek.aggarwal added inline comments.
Comment at: tools/intel-features/intel-pt/Decoder.cpp:411
+std::string image_path(image_complete_path, path_length);
+try {
+ readExecuteSectionInfos.emplace_back(
labath wrote:
> abhishek.aggarwal
Author: labath
Date: Thu Jun 29 09:15:42 2017
New Revision: 306693
URL: http://llvm.org/viewvc/llvm-project?rev=306693&view=rev
Log:
Speculative fix for windows build broken by r306668
Modified:
lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
Modified: lldb/trunk/unittests/SymbolF
Author: labath
Date: Thu Jun 29 08:24:38 2017
New Revision: 306686
URL: http://llvm.org/viewvc/llvm-project?rev=306686&view=rev
Log:
Fix Mac build for the Timer move
Modified:
lldb/trunk/source/Host/macosx/Symbols.cpp
lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp
M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306682: Move Timer and TraceOptions from Core to Utility
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D34746?vs=104624&id=104647#toc
Repository:
rL LLVM
https://reviews.ll
Author: labath
Date: Thu Jun 29 07:32:23 2017
New Revision: 306683
URL: http://llvm.org/viewvc/llvm-project?rev=306683&view=rev
Log:
Android.rules: build x86 tests with -mstackrealign
All android builds systems have switched to -mstackrealign for building
x86 binaries, so follow their cue with ou
Author: labath
Date: Thu Jun 29 07:32:17 2017
New Revision: 306682
URL: http://llvm.org/viewvc/llvm-project?rev=306682&view=rev
Log:
Move Timer and TraceOptions from Core to Utility
Summary:
The classes have no dependencies, and they are used both by lldb and
lldb-server, so it makes sense for th
Cool, lgtm
On Thu, Jun 29, 2017 at 5:52 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath updated this revision to Diff 104624.
> labath added a comment.
>
> That's a good idea. This time I almost smuggled in a (unused) Host include
> into
> Utility -- it was a leftover f
labath added inline comments.
Comment at: tools/intel-features/intel-pt/Decoder.cpp:411
+std::string image_path(image_complete_path, path_length);
+try {
+ readExecuteSectionInfos.emplace_back(
abhishek.aggarwal wrote:
> labath wrote:
> >
abhishek.aggarwal added a comment.
Thanks for your review Pavel. My comments are inlined. Let me know your opinion
:)
Comment at: tools/intel-features/intel-pt/Decoder.cpp:411
+std::string image_path(image_complete_path, path_length);
+try {
+ readExec
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306668: [unittests] Add a helper function for getting an
input file (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D34683?vs=104145&id=104627#toc
Repository:
rL LLVM
https:/
Author: labath
Date: Thu Jun 29 06:02:15 2017
New Revision: 306669
URL: http://llvm.org/viewvc/llvm-project?rev=306669&view=rev
Log:
Make scripts/analyze-project-deps.py executable
Modified:
lldb/trunk/scripts/analyze-project-deps.py (contents, props changed)
Modified: lldb/trunk/scripts/a
Author: labath
Date: Thu Jun 29 06:02:11 2017
New Revision: 306668
URL: http://llvm.org/viewvc/llvm-project?rev=306668&view=rev
Log:
[unittests] Add a helper function for getting an input file
Summary:
Fetching an input file required about five lines of code, and this was
repeated in multiple uni
labath updated this revision to Diff 104624.
labath added a comment.
That's a good idea. This time I almost smuggled in a (unused) Host include into
Utility -- it was a leftover from the Host::ThreadLocalStorage times. I'll make
sure to run it in the future.
After fixing that issue, I see no diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL30: [UnwindAssembly/x86] Add support for "lea imm(%ebp),
%esp" pattern (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D34750
Files:
lldb/trunk/source/Plugins/UnwindAssembly/x
Author: labath
Date: Thu Jun 29 05:40:13 2017
New Revision: 30
URL: http://llvm.org/viewvc/llvm-project?rev=30&view=rev
Log:
[UnwindAssembly/x86] Add support for "lea imm(%ebp), %esp" pattern
Summary:
The instruction pattern:
and $-16, %esp
sub $imm, %esp
...
lea imm(%ebp), %esp
appears
karnajitw added a comment.
Looks like the right thing to do. I will make the changes accordingly.
Repository:
rL LLVM
https://reviews.llvm.org/D34776
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
labath added a comment.
Thank you for making the changes. I concede that I am not always clear in my
communications, and I apologize if I was being rude.
I am happy with the cmake stuff, but I noticed a new issue now. Exceptions are
banned in llvm, so we need to figure out how to remove them fr
On 28 June 2017 at 15:16, Scott Smith wrote:
> x86_64 stacks are supposed to be naturally 16-byte aligned. Maybe try a
> 32-byte AVX instruction and see if the compiler aligns to a 32-byte
> boundary?
>
I was able to generate the "andq $-16, %rsp" part of the pattern. The
trick was that the comp
labath added inline comments.
Comment at: source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:92
clang_ast_context->GetBasicType(eBasicTypeVoid).GetPointerType();
-lldb::addr_t args[] = {addr, length, prot_arg, flags_arg, fd, offset};
+llvm::SmallVec
25 matches
Mail list logo
