[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

2017-07-13 Thread Pavel Labath via Phabricator via lldb-commits
labath marked 2 inline comments as done. labath added a comment. In https://reviews.llvm.org/D31172#807180, @jingham wrote: > Sorry I wasn't clear. I meant that since the Target knows everything it > needs to know to vend the correct Architecture plugin, you should get it from > the Target, no

[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

2017-07-13 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 106398. labath added a comment. Moving the plugin to Target and other minor fixups. I also wrote a test for the functionality covered by the override callback. (I'm not including it here to avoid polluting the review, but a part of this change will be to move

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

2017-07-13 Thread Karnajit Wangkhem via Phabricator via lldb-commits
karnajitw updated this revision to Diff 106423. karnajitw added a comment. Updated the patch. While referring to the linux implementation, looks like I have added a reinterpret_cast on message.GetFaultAddress which is not required in the freebsd scenario. Repository: rL LLVM https://reviews

[Lldb-commits] [PATCH] D35356: [zorg] Enable assertions on the linux lldb bot

2017-07-13 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. This adds support for the extra_cmake_args argument to the LLDBScriptCommandsFactory and uses that to enable assertions on the linux bot. While I'm in there, I also remove the "update ndk" step -- it was a bad idea because it's introducing android-specific code into

[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

2017-07-13 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Added a suggestion to make Target::GetArchitecturePlugin lazy and to ask if the arch is supported. Most of the time we will set this once and never need to change it, even when we attach, change arch, etc. The new suggestion will allow us to use the same arch plug-in w

[Lldb-commits] [PATCH] D34911: Enable parsing C++ names generated by lambda functions.

2017-07-13 Thread Xuetian Weng via Phabricator via lldb-commits
wengxt added a comment. I don't have commit access. May any one help me to commit? https://reviews.llvm.org/D34911 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

2017-07-13 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D31172#808038, @clayborg wrote: > Added a suggestion to make Target::GetArchitecturePlugin lazy and to ask if > the arch is supported. Most of the time we will set this once and never need > to change it, even when we attach, change arch, etc.

[Lldb-commits] [PATCH] D31172: Move stop info override callback code from ArchSpec into Process

2017-07-13 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In https://reviews.llvm.org/D31172#808105, @labath wrote: > In https://reviews.llvm.org/D31172#808038, @clayborg wrote: > > > Added a suggestion to make Target::GetArchitecturePlugin lazy and to ask if > > the arch is supported. Most of the time we will set this once an

[Lldb-commits] [PATCH] D34911: Enable parsing C++ names generated by lambda functions.

2017-07-13 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene added a comment. In https://reviews.llvm.org/D34911#808059, @wengxt wrote: > I don't have commit access. May any one help me to commit? I'll do it for you. https://reviews.llvm.org/D34911 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] r307942 - Fix a deadlock in the Python interpreter vrs. SIGINT.

2017-07-13 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Jul 13 12:45:54 2017 New Revision: 307942 URL: http://llvm.org/viewvc/llvm-project?rev=307942&view=rev Log: Fix a deadlock in the Python interpreter vrs. SIGINT. The interpreter gets invoked in the sigint handler to cancel long-running Python operations. That requires t

[Lldb-commits] [lldb] r307943 - Convert a few more tests to use run_to_source_breakpoint.

2017-07-13 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Jul 13 12:46:21 2017 New Revision: 307943 URL: http://llvm.org/viewvc/llvm-project?rev=307943&view=rev Log: Convert a few more tests to use run_to_source_breakpoint. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/unwind_expression/TestUnwindE

[Lldb-commits] [lldb] r307944 - Enable parsing C++ names generated by lambda functions.

2017-07-13 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Jul 13 12:48:43 2017 New Revision: 307944 URL: http://llvm.org/viewvc/llvm-project?rev=307944&view=rev Log: Enable parsing C++ names generated by lambda functions. https://reviews.llvm.org/D34911 from Weng Xuetian. Modified: lldb/trunk/source/Plugins/Language/CPlusP

Re: [Lldb-commits] [PATCH] D34911: Enable parsing C++ names generated by lambda functions.

2017-07-13 Thread Jim Ingham via lldb-commits
Done (r307944). Thanks for the patch! Jim > On Jul 13, 2017, at 8:20 AM, Xuetian Weng via Phabricator via lldb-commits > wrote: > > wengxt added a comment. > > I don't have commit access. May any one help me to commit? > > > https://reviews.llvm.org/D34911 > > > > _

[Lldb-commits] [PATCH] D34911: Enable parsing C++ names generated by lambda functions.

2017-07-13 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene added a comment. Jim already did it. Thanks Jim. https://reviews.llvm.org/D34911 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r307957 - Fix debugserver accepting remote connections

2017-07-13 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Jul 13 13:58:13 2017 New Revision: 307957 URL: http://llvm.org/viewvc/llvm-project?rev=307957&view=rev Log: Fix debugserver accepting remote connections While adding IPv6 support to debugserver I broke handling wildcard addresses and fully qualified address filtering.

Re: [Lldb-commits] [lldb] r247852 - Add an OperatingSystem plugin to support goroutines

2017-07-13 Thread Jason Molenda via lldb-commits
Hi Ryan, we're having a tiny problem with the Go OperatingSystem plugin at Apple. I know it's been a while since you've worked on this, but I wanted to see if you had an opinion about how we should address this. Some iPhone app developers download static libraries (aka ranlib archives aka coll