[Lldb-commits] [PATCH] D35607: Extend 'target symbols add' to set symbol file for a given module

eugene updated this revision to Diff 107628. eugene retitled this revision from "Extend 'target symbols add' to load symbols from a given file by UUID." to "Extend 'target symbols add' to set symbol file for a given module". eugene edited the summary of this revision. eugene added a comment. Fou

[Lldb-commits] [PATCH] D35525: Fix "help format" output

jessicah updated this revision to Diff 107623. jessicah added a comment. A test case was added. https://reviews.llvm.org/D35525 Files: packages/Python/lldbsuite/test/help/TestHelp.py source/Interpreter/CommandInterpreter.cpp Index: source/Interpreter/CommandInterpreter.cpp ===

[Lldb-commits] [PATCH] D35525: Fix "help format" output

clayborg added a comment. Add a test for this and this will be good to go. https://reviews.llvm.org/D35525 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D35525: Fix "help format" output

jingham added a comment. BTW, the second listing was after applying your patch, showing it clearly does the right thing... https://reviews.llvm.org/D35525 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [PATCH] D35525: Fix "help format" output

jingham added a comment. Yes, your version clearly has the test right. I was wondering why this didn't have a more dramatic ill-effect, but it turns out that this function is only used for printing argument help text, which it clearly messes up: (lldb) help format --

[Lldb-commits] [PATCH] D35525: Fix "help format" output

jessicah added reviewers: jingham, clayborg. jessicah added a comment. Add Jim and Greg per Zachary's suggestion. Jessica https://reviews.llvm.org/D35525 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

Re: [Lldb-commits] [PATCH] D35525: Fix "help format" output

I am OOO for another week, can you add jingham or clayborg instead? On Thu, Jul 20, 2017 at 11:40 AM Jessica Han via Phabricator < revi...@reviews.llvm.org> wrote: > jessicah added reviewers: tfiala, zturner. > jessicah added a comment. > > Todd, Zachary, > > Can you help review this change? > > T

[Lldb-commits] [PATCH] D35525: Fix "help format" output

jessicah added reviewers: tfiala, zturner. jessicah added a comment. Todd, Zachary, Can you help review this change? Thanks, Jessica https://reviews.llvm.org/D35525 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

clayborg added a comment. I am not sure how sensitive typemaps are to the names of the arguments? Maybe we can just have you use different names and then the two typemaps won't collide? You can also write some manual code to do the remapping without typemaps. Regardless of whether you are goin

[Lldb-commits] [PATCH] D35607: Extend 'target symbols add' to load symbols from a given file by UUID.

eugene added a comment. In https://reviews.llvm.org/D35607#814982, @clayborg wrote: > So we should just make sure this works: > > (lldb) target symbols add --shlib a.out debug_binaries/a.out > I like this, and I'm going to implement it. Pavel is right and the way UUID is set for modules wit

[Lldb-commits] [PATCH] D35607: Extend 'target symbols add' to load symbols from a given file by UUID.

clayborg added a comment. One other idea if we go with the UUID::Type solution: if we have UUIDs that are different, we could ask the ObjectFile (ObjectFileELF) to see if it thinks the files go together. Not sure if there is anything in the ELF file that would allow us to do that. In Mach-O we

[Lldb-commits] [PATCH] D35607: Extend 'target symbols add' to load symbols from a given file by UUID.

clayborg added a comment. In https://reviews.llvm.org/D35607#815769, @labath wrote: > In https://reviews.llvm.org/D35607#814982, @clayborg wrote: > > > So we should just make sure this works: > > > > (lldb) target symbols add --shlib a.out debug_binaries/a.out > > > > > > The --uuid option is t

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

abhishek.aggarwal added a comment. In https://reviews.llvm.org/D33035#803801, @clayborg wrote: > Much better on the API with Swig. Just a few inlined questions around > GetRawBytes. Hi Greg .. Thanks for feedback. My comments are inlined. Comment at: tools/intel-features/in

[Lldb-commits] [PATCH] D35666: Add data formatter for libc++ std::queue

labath created this revision. Herald added subscribers: mgorny, srhines. Herald added a reviewer: EricWF. std::queue is just a fancy wrapper around another container, so all we need to do is to delegate to the it. https://reviews.llvm.org/D35666 Files: packages/Python/lldbsuite/test/function

[Lldb-commits] [PATCH] D35607: Extend 'target symbols add' to load symbols from a given file by UUID.

labath added a comment. In https://reviews.llvm.org/D35607#814982, @clayborg wrote: > So we should just make sure this works: > > (lldb) target symbols add --shlib a.out debug_binaries/a.out > > > The --uuid option is there to help you match up without having to specify the > file path. If I a

[Lldb-commits] [PATCH] D35311: lldb-server tests: Add support for testing debugserver

labath added a comment. In https://reviews.llvm.org/D35311#814941, @jingham wrote: > This isn't about this patch, but replying to: > > > debugserver replies to the k packet instead of just dropping the connection > > - stopping code adjusted, although we should probably consider aligning the >