Author: gclayton
Date: Fri Nov 10 14:39:07 2017
New Revision: 317945
URL: http://llvm.org/viewvc/llvm-project?rev=317945&view=rev
Log:
Added a way to dump the full paths to all source files in a module that has
debug info.
Modified:
lldb/trunk/www/troubleshooting.html
Modified: lldb/trunk/
zturner added a comment.
In https://reviews.llvm.org/D39896#922381, @probinson wrote:
> Drive by comment:
>
> In https://reviews.llvm.org/D39896#94, @jingham wrote:
>
> > You're right, the Triple stuff is in ADT! I was using it as an example of
> > something you clearly wouldn't do so I did
probinson added a comment.
Drive by comment:
In https://reviews.llvm.org/D39896#94, @jingham wrote:
> You're right, the Triple stuff is in ADT! I was using it as an example of
> something you clearly wouldn't do so I didn't actually check to see if it was
> done. That's pretty funny.
>
>
jingham added a comment.
Yes, my intention was not to gate this patch on figuring out the right role for
Utility/Core/Whatever. It just seemed an apropos moment to bring this up.
You're right, the Triple stuff is in ADT! I was using it as an example of
something you clearly wouldn't do so I d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317919: [lldb] Remove unused method declaration (authored by
alexshap).
Changed prior to commit:
https://reviews.llvm.org/D39884?vs=122379&id=122493#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: alexshap
Date: Fri Nov 10 11:40:53 2017
New Revision: 317919
URL: http://llvm.org/viewvc/llvm-project?rev=317919&view=rev
Log:
[lldb] Remove unused method declaration
FindCompleteObjCDefinitionType is not used anywhere and there is no
implementation of it, only a declaration.
Test plan:
zturner added a comment.
I'd be open to having another organizational component that isn't Utility. But
as Jim said, there isn't a critical mass of stuff yet in Utility to figure out
where it makes sense to draw the line.
In all honesty, that second component might just end up being "Core" aga
clayborg added a comment.
I just saw Jim's email for this, Please comment in this bug so we can all see
the info in one location. Accepting pending the outcome of the discussion that
Jim start in email that I am pasting below:
> I'm not sure we have enough instances to decide on better organiza
I'm not sure we have enough instances to decide on better organization, but
ArchSpec really doesn't feel like a Utility for lldb. That would be like
moving the llvm triple handling to ADT, that seems a little weird. Similarly
having the register stuff in Utility seems odd as well. I would nev
Super awesome. When you do move it to Utility, can you run the deps python
script to see if any cmake dependencies can be updated?
On Fri, Nov 10, 2017 at 4:02 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath created this revision.
>
> In https://reviews.llvm.org/D39387,
alexandreyy added a comment.
In https://reviews.llvm.org/D39681#921620, @labath wrote:
> Looks good, thank you. Just please make sure you change the file name at top
> of the new header file and add inclusion guards.
Done. Could you commit it?
I don't have commit access.
https://reviews.llvm
alexandreyy updated this revision to Diff 122423.
alexandreyy added a comment.
Added inclusion guards in elf-core-enums.h
https://reviews.llvm.org/D39681
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionaliti
labath created this revision.
In https://reviews.llvm.org/D39387, I was quick to jump to conclusion that
ArchSpec has no
external dependencies. It turns there still was one call to
HostInfo::GetArchitecture left -- for implementing the "systemArch32"
architecture and friends.
Since GetAugmentedA
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317881: Clean up NativeRegisterContext (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D39837
Files:
lldb/trunk/include/lldb/Host/common/NativeRegisterContext.h
lldb/trunk/includ
Author: labath
Date: Fri Nov 10 03:05:49 2017
New Revision: 317881
URL: http://llvm.org/viewvc/llvm-project?rev=317881&view=rev
Log:
Clean up NativeRegisterContext
Summary:
This commit removes the concrete_frame_idx member from
NativeRegisterContext and related functions, which was always set to
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, thank you. Just please make sure you change the file name at top of
the new header file and add inclusion guards.
Comment at: source/Plugins/Process/elf-core/elf
labath updated this revision to Diff 122407.
labath marked 3 inline comments as done.
labath added a comment.
- provide default no-op implementations in TypeSystem, so derived classes don't
have to override them if they don't want to
- have SBType::GetTemplateArgumentType return the type of the i
17 matches
Mail list logo
