Re: [Lldb-commits] [PATCH] Use the DWARF linkage name when importing C++ methods

Thanks, created here: https://reviews.llvm.org/D40283 I got here via http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch ; Should that documentation be updated? Would a patch be appropriate? - Nelson On Mon, Nov 20, 2017 at 7:57 AM Greg Clayton wrote: > Please submit a revi

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

nelhage created this revision. Herald added subscribers: JDevlieghere, aprantl. When importing C++ methods into clang AST nodes from the DWARF symbol table, preserve the `DW_AT_linkage_name` and use it as the linker ("asm") name for the symbol. Concretely, this enables `expression` to call into

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

FTR, the size of the compile-unit header also changed in DWARF version 5, independent of the 32/64 format. On a different topic, I had thought there was a goal of nuking lldb's copy of the DWARFxxx headers and converting to use LLVM's? Did I imagine this? If I do remember that correctly, fidd

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

You can make structs that are host and byte-order independent, LLVM is filled with stuff like this. And while you might end up processing the information off in a way that it can be stored in a single compile unit without such a struct, it still can be useful when you're actually *doing* the parsi

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

sizeof(struct) tends to include system level padding for the current host. But to answer your question, no there isn't a structure defined like this and we wouldn't use them anyway as we want to fill out one compile unit struct that works for both. > On Nov 20, 2017, at 8:01 AM, Zachary Turner

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

Right but isn’t there a DWARF64_HEADER and DEARF32_HEADER struct somewhere? This way you could just say return m_isdwarf64 ? sizeof(DWARF64_HEADER) : sizeof(DWARF32_HEADER); On Mon, Nov 20, 2017 at 7:50 AM Greg Clayton wrote: > > On Nov 19, 2017, at 4:56 PM, Zachary Turner wrote: > > > > On Sun

Re: [Lldb-commits] [PATCH] Use the DWARF linkage name when importing C++ methods

Please submit a review of this patch through reviews.llvm.org . - svn diff -x -U9 > /tmp/a.patch - login or create a login if you don't already have one - Select Differential from the top left corner - Click "+ Create Diff" in upper right - Click "Choose File" and s

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

> On Nov 19, 2017, at 4:56 PM, Zachary Turner wrote: > > > > On Sun, Nov 19, 2017 at 6:35 AM Jan Kratochvil via Phabricator via > lldb-commits > wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL318626: