labath created this revision.
labath added a reviewer: clayborg.
Herald added subscribers: JDevlieghere, emaste.
These two functions were calling each other, while handling different
branches of the if(IsInMemory()). I am assuming this had a reason at
some point in the past, but right now it's jus
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D41169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
asmith added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:392-399
+ bool is_regex = false;
+ if (name_str.find_first_of("[]?*.-+\\") != std::string::npos) {
+// Trying to compile an invalid regex could throw an exception.
+// Only search
asmith added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:127
+ }
+ lldbassert(m_session_up.get());
+ if (auto enum_tables_up = m_session_up->getEnumTables()) {
clayborg wrote:
> I am assuming this assert won't fire if we give t
Can we try using lldb_private::RegularExpression for everything? (Long
term, adding a new base class method seems like a better approach, but at
least this quick fix is an immediate fix and should be strictly better than
crashing)
On Wed, Dec 13, 2017 at 10:27 AM Aaron Smith via Phabricator <
rev
clayborg accepted this revision.
clayborg added a comment.
This was left over from before we mmap'ed the entire object file into memory.
Removing it is fine as the backing DataBufferSP for the object file will be
mmaped or not depending on where the file was loaded from and if the section
isn't
Ah sorry, didn't see this for a while!
Yes -- I agree on both points here.
vedant
> On Dec 11, 2017, at 9:07 PM, Zachary Turner wrote:
>
> Long term it would be nice if we could get all these register definitions
> automatically generated with llvm-tblgen. That's a big undertaking, though.
>
Hello everyone,
Below are some buildbot numbers for the week of 11/26/2017 - 12/02/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the last week of 12/3/2017 - 12/9/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
