Author: jingham
Date: Mon Jan 8 19:03:20 2018
New Revision: 322054
URL: http://llvm.org/viewvc/llvm-project?rev=322054=rev
Log:
Cut and paste error - I wasn't actually running both tests...
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
Modified:
owenpshaw added a comment.
Thanks! I don't have commit access, so someone needs to commit this for me,
right?
https://reviews.llvm.org/D41745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D41745#970362, @owenpshaw wrote:
> Updated patch with new function name suggested by @clayborg. Added unit test
> and changed to llvm::function_ref as
owenpshaw updated this revision to Diff 128991.
owenpshaw added a comment.
Updated patch with new function name suggested by @clayborg. Added unit test
and changed to llvm::function_ref as suggested by @labath.
Based on Greg's comments in the other thread, I've kept the new function
separate,
IIUA, this code is negotiating the best compression to use for communication
between lldb & the remote stub. Since there's no guarantee that the remote
stub has anything to do with llvm, you can't just use whatever llvm uses.
Jim
> On Jan 7, 2018, at 2:11 AM, Michał Górny via Phabricator via
xoviat added a comment.
Thanks for the quick response! This change was prompted by a failed build using
the `cmake ..`, `cmake --build .`, `cmake --build . --target install` standard
workflow. I look forward to the fix in LLVM 7!
Repository:
rL LLVM
https://reviews.llvm.org/D41824
davide added a comment.
Opened https://bugs.llvm.org/show_bug.cgi?id=35857
Repository:
rL LLVM
https://reviews.llvm.org/D41824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
