vsk added a comment.
Is this OK to commit?
https://reviews.llvm.org/D42277
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
The funny thing is this is only 981 characters long... Not sure what the right
cutoff would be...
Repository:
rL LLVM
https://reviews.llvm.org/D31451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
eugene added a comment.
Greg, this name is amazing. My c++filt refuses to demangle it. We can probably
give up on parsing C++ names if they're longer than 1000 characters or
something.
Repository:
rL LLVM
https://reviews.llvm.org/D31451
___
lld
clayborg added a comment.
This is part of the problem, but not the entire thing.. We had a mangled name:
_ZNK3shk6detail17CallbackPublisherIZNS_5ThrowERKNSt15__exception_ptr13exception_ptrEEUlOT_E_E9SubscribeINS0_9ConcatMapINS0_18CallbackSubscriberIZNS_6GetAllIiNS1_IZZNS_9ConcatMapIZNS_6ConcatIJNS
labath planned changes to this revision.
labath added inline comments.
Comment at: source/Host/linux/Host.cpp:129
+ auto buffer_sp = DataBufferLLVM::CreateSliceFromPath(exe_path, 0x20, 0);
+ if (buffer_sp)
+return ArchSpec();
eugene wrote:
> Shouldn't it be
eugene added inline comments.
Comment at: source/Host/linux/Host.cpp:129
+ auto buffer_sp = DataBufferLLVM::CreateSliceFromPath(exe_path, 0x20, 0);
+ if (buffer_sp)
+return ArchSpec();
Shouldn't it be
```
if (!buffer_sp)
```
?
https://reviews.llvm.org/D
xiaobai closed this revision.
xiaobai added a subscriber: compnerd.
xiaobai added a comment.
@compnerd committed this for me! r323363
https://reviews.llvm.org/D42264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: compnerd
Date: Wed Jan 24 11:00:08 2018
New Revision: 323363
URL: http://llvm.org/viewvc/llvm-project?rev=323363&view=rev
Log:
www: update lldb architecture doc
ArchSpec was moved from Core to Utility, so I modified the docs to
reflect that.
Patch by Alex Langford !
Modified:
lldb/t
owenpshaw updated this revision to Diff 131310.
owenpshaw added a comment.
- Updated condition for yaml2obj dependency, now based on LLDB_BUILT_STANDALONE
- Find yaml2obj in the same directory as clang
- Move yaml2obj code into lldbtest.py so it's available to all tests
Is the findBuiltClang func
davide accepted this revision.
davide added a comment.
Thanks for the spring cleaning!
https://reviews.llvm.org/D42488
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
Herald added subscribers: llvm-commits, hintonda.
This code is making debugging of large C++ apps so slow it is unusable...
Repository:
rL LLVM
https://reviews.llvm.org/D31451
___
lldb-commits mailing list
lldb-commits@l
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine to me.
https://reviews.llvm.org/D42488
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: labath
Date: Wed Jan 24 08:40:22 2018
New Revision: 323340
URL: http://llvm.org/viewvc/llvm-project?rev=323340&view=rev
Log:
Remove unused includes from the Host module
Modified:
lldb/trunk/source/Host/common/Symbols.cpp
lldb/trunk/source/Host/freebsd/Host.cpp
lldb/trunk/sourc
labath created this revision.
labath added reviewers: eugene, krytarowski.
Herald added subscribers: hintonda, mgorny.
The ObjectFile class was used to determine the architecture of a running
process by inspecting it's main executable. There were two issues with
this:
- it's in the wrong layer
-
14 matches
Mail list logo
