Hi Pavel, I closed this phabracator, I've been working on this on-and-off and I
think a different approach would be better.
I am working up a patch where I change tools/lldb-server/lldb-platform.cpp from
using a fork() model to using std::thread's. The main thread listens for
incoming connecti
Author: jmolenda
Date: Fri Feb 2 16:37:46 2018
New Revision: 324158
URL: http://llvm.org/viewvc/llvm-project?rev=324158&view=rev
Log:
Turn off the deprecated ALWAYS_SEARCH_USER_PATHS feature
in debugserver. This is already set this way in the lldb
project files but not in debugserver. Updating
jingham added a comment.
There is code in the GDBRemoteTestBase that makes targets from yaml2obj. See
the createTarget method in
packages/Python/lldbsuite/functionalities/gdb_remote_client/gdbclientutils.py.
Actually, that's method should be pulled out of the gdb_remote_client and moved
to T
davide added a subscriber: zturner.
davide added a comment.
In https://reviews.llvm.org/D42870#996913, @krytarowski wrote:
> Is there a working example of this? I would clone an existing code for Linux
> or other supported OS and adapt it for NetBSD.
>
> Please note that I'm in the process of re
krytarowski added a comment.
Is there a working example of this? I would clone an existing code for Linux or
other supported OS and adapt it for NetBSD.
Please note that I'm in the process of restoration LLDB (lldb-server) so I
cannot execute regular tests, at least in close time.
Repository:
davide added a comment.
In https://reviews.llvm.org/D42870#996899, @clayborg wrote:
> Probably take a ELF file that is NetBSD and obj2yaml it. The test would run
> yaml2obj on it and then test that things are recognized correctly via the SB
> interfaces (check triple is correct)?
The SBApi in
clayborg added a comment.
You would check in the YAML code for the NetBSD ELF file so that the test case
can make it into an ELF file, run the test, verify things, and then cleanup the
created ELF file.
Repository:
rL LLVM
https://reviews.llvm.org/D42870
_
clayborg added a comment.
Probably take a ELF file that is NetBSD and obj2yaml it. The test would run
yaml2obj on it and then test that things are recognized correctly via the SB
interfaces (check triple is correct)?
Repository:
rL LLVM
https://reviews.llvm.org/D42870
___
krytarowski added a comment.
What would the test do?
Repository:
rL LLVM
https://reviews.llvm.org/D42870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
Please add a test case.
Repository:
rL LLVM
https://reviews.llvm.org/D42870
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
krytarowski updated this revision to Diff 132689.
Repository:
rL LLVM
https://reviews.llvm.org/D42868
Files:
source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
Index: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324156: Fix a copy of a fixed length, possibly non-nul
terminated, string (authored by jmolenda, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42828?vs=132500&id=132688#toc
Reposit
Author: jmolenda
Date: Fri Feb 2 14:48:45 2018
New Revision: 324156
URL: http://llvm.org/viewvc/llvm-project?rev=324156&view=rev
Log:
Fix a copy of a fixed length, possibly non-nul terminated, string
into a std::string so we don't run off the end of the array when
there is no nul byte in ProcessE
krytarowski added inline comments.
Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:116
static_cast(*thread).SetStoppedBySignal(SIGSTOP);
- process_up->SetState(StateType::eStateStopped);
Another option is to call:
```
process_up->SetSta
krytarowski created this revision.
krytarowski added reviewers: joerg, labath.
Herald added subscribers: llvm-commits, emaste.
Split the recognition into NetBSD executables
& shared libraries and core(5) files.
Introduce new owner type: "NetBSD-CORE",
as core(5) files are not tagged in the same w
krytarowski added a comment.
Extracted from: https://reviews.llvm.org/D32149.
Repository:
rL LLVM
https://reviews.llvm.org/D42870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
krytarowski added a comment.
(gdb) r
Starting program: /public/llvm-build/bin/lldb-server g \*:1234 --
/usr/bin/look
[New process 15150]
Thread 1 received signal SIGSEGV, Segmentation fault.
lldb_private::NativeProcessProtocol::GetCurrentThreadID (this=0x0) at
/public/llvm/tools/lld
krytarowski created this revision.
krytarowski added reviewers: labath, joerg.
Herald added a subscriber: llvm-commits.
krytarowski edited the summary of this revision.
We cannot call process_up->SetState() inside
the NativeProcessNetBSD::Factory::Launch
function because it triggers a NULL pointer
jankratochvil updated this revision to Diff 132670.
jankratochvil marked an inline comment as done.
jankratochvil added a comment.
Simplify the testcase by: lldbutil.run_to_name_breakpoint
https://reviews.llvm.org/D42853
Files:
packages/Python/lldbsuite/test/linux/sepdebugsymlink/Makefile
jankratochvil updated this revision to Diff 132668.
jankratochvil added a comment.
Simplify the testcase using: lldbutil.run_to_name_breakpoint
https://reviews.llvm.org/D42852
Files:
packages/Python/lldbsuite/test/linux/buildidcase/Makefile
packages/Python/lldbsuite/test/linux/buildidcase/
owenpshaw updated this revision to Diff 132641.
owenpshaw added a comment.
- adjust WriteObjectFile signature to return Status and take an std::vector
- match project formatting style
I toyed with adding allow_flash to as an argument, but didn't really like it
because it seemed to bring things b
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Great. The important thing for me was that a new object is constructed for each
permutation of test function / variant.
https://reviews.llvm.org/D42836
__
jingham added a comment.
Can you fix the test case as mentioned inline. If something doesn't work
please just ping me and I'll fix it. I'd like to get off propagating this
boiler-plate...
Comment at:
packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestSymbolsSepDebugS
Author: jingham
Date: Fri Feb 2 10:39:25 2018
New Revision: 324119
URL: http://llvm.org/viewvc/llvm-project?rev=324119&view=rev
Log:
Add the ability to restrict the breakpoint to a module
for run_to_{source,name}_breakpoint.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py
Mo
Author: adrian
Date: Fri Feb 2 10:32:29 2018
New Revision: 324115
URL: http://llvm.org/viewvc/llvm-project?rev=324115&view=rev
Log:
Use an alternative approach to prevent Spotlight from indexing the build
directory.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
lldb/trun
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Makes sense for me, but make sure Pavel is ok with this as well before
committing.
https://reviews.llvm.org/D42853
___
lldb-commits mailing
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Many file systems are case insensitive so that is probably why it works on some
computers.
https://reviews.llvm.org/D42852
___
lldb-commits
jankratochvil created this revision.
jankratochvil added reviewers: labath, clayborg.
Herald added a subscriber: aprantl.
I have found LLDB cannot find separate debug info of Fedora /usr/bin/gdb. It
is because:
lrwxrwxrwx 1 root root 14 Jan 25 20:41 /usr/bin/gdb -> ../libexec/gdb*
-rw
labath added a comment.
In https://reviews.llvm.org/D42836#996288, @aprantl wrote:
> That looks great, to make sure I understand this correctly, is the following
> accurate?
>
> If we apply this on top of https://reviews.llvm.org/D42763, and we have
>
> tests/my/testA.py:
> class TestA(Bas
jankratochvil created this revision.
jankratochvil added reviewers: labath, clayborg.
I have found the lookup by build-id (when lookup by
/usr/lib/debug/path/name/exec.debug failed) does not work as LLDB tries the
build-id hex string in uppercase but Fedora uses lowercase.
xubuntu-16.10 also use
aprantl added a comment.
That looks great, to make sure I understand this correctly, is the following
accurate?
If we apply this on top of https://reviews.llvm.org/D42763, and we have
tests/my/testA.py:
class TestA(Base):
def setUp(self):
...
def testAone(self):
clayborg added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:668
return status.ToError();
- thread_data.name = prpsinfo.pr_fname;
+ thread_data.name.assign (prpsinfo.pr_fname, sizeof (prpsinfo.pr_fname));
SetID(prpsinfo.
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/api/listeners/TestListener.py:26
TestBase.setUp(self)
-self.build()
aprantl wrote:
> labath wrote:
> > I'm confused by these changes. I was under the impression that setUp
labath updated this revision to Diff 132557.
labath added a comment.
Move getDebugInfo definition to "Base" class (fixes lldb-mi tests).
https://reviews.llvm.org/D42836
Files:
packages/Python/lldbsuite/test/decorators.py
packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
pack
JDevlieghere added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbinline.py:96-98
+return "-N dwarf %s" % (testdir)
else:
+return "-N dsym %s" % (testdir)
labath wrote:
> aprantl wrote:
> > labath wrote:
> > > xia
labath created this revision.
labath added reviewers: aprantl, jingham.
Herald added subscribers: JDevlieghere, eraman.
This changes the way we store the debug info variant to make it
available earlier in the test bringup: instead of it being set by the
test wrapper method, it is set as a *propert
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, just make sure to not include extra \0 bytes.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:668
return status.ToError();
- thread_d
labath added a comment.
Yes, it's mostly stylistic differences, but there is one more important thing
that we need to figure out, and that's making sure that the test only runs if
we actually have XML support compiled-in. If there's isn't anything in the SB
API that would tell us that (I cursor
Well... it would be *very*-nice-to-have thing. I would very much love
to be able to run at least one pdb test from linux. (So, I'm not
opposing this in any way, just pointing out what needs to happen).
On 1 February 2018 at 18:35, Zachary Turner wrote:
> Yea good point. We can probably punt on th
39 matches
Mail list logo