clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We probably need a test then.
https://reviews.llvm.org/D44752
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tromey added a comment.
In https://reviews.llvm.org/D44752#1052027, @clayborg wrote:
> Can you add this to the patch for the rust plug-in then?
Yes, I already did; I just thought that since it was a latent bug in upstream
that I would submit it separately.
https://reviews.llvm.org/D44752
clayborg added a comment.
Can you add this to the patch for the rust plug-in then?
https://reviews.llvm.org/D44752
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide added a comment.
OK, I'll commit it for you later today.
https://reviews.llvm.org/D44907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tromey added a comment.
In https://reviews.llvm.org/D44907#1051931, @davide wrote:
> @tromey thanks! do you need somebody to commit this for you?
Yes. I do not have commit access.
https://reviews.llvm.org/D44907
___
lldb-commits mailing list
tromey added a comment.
I only found this because I tried to use it in my rust plugin. So, I would
rather implement it, because if I removed it, I would have to find a new way to
do this.
https://reviews.llvm.org/D44752
___
lldb-commits mailing
davide added a comment.
Just remove it I'd say (bonus point if you can remove other bits)
https://reviews.llvm.org/D44752
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide added a comment.
@tromey thanks! do you need somebody to commit this for you?
https://reviews.llvm.org/D44907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
Should this be removed then? If not one was using it, we should remove it from
the header file.
https://reviews.llvm.org/D44752
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Very nice. Thanks for doing this. Someone a while back had converted Scalar to
use APInt and APFloat and never got around to all of these details.
https://reviews.llvm.org/D44907
fjricci abandoned this revision.
fjricci added a comment.
I'm not going to get to this
https://reviews.llvm.org/D41909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
We already have section dumping code in the lldb-test utility. Extending the
output to dump the detected section type seems like a good (and simple) thing
to do.
Repository:
rL LLVM
https://reviews.llvm.org/D44998
___
Author: labath
Date: Thu Mar 29 03:09:11 2018
New Revision: 328770
URL: http://llvm.org/viewvc/llvm-project?rev=328770=rev
Log:
NativeThreadProtocol: delete dead code
These functions were unused as everyone just went straight for the
direct operations on the register context. In fact, the
13 matches
Mail list logo
