eugene created this revision.
eugene added reviewers: labath, jingham.
Fixing crash after "breakpoint delete". Bug:
https://bugs.llvm.org/show_bug.cgi?id=36430
https://reviews.llvm.org/D45554
Files:
davide added a comment.
In https://reviews.llvm.org/D45547#1065054, @jasonmolenda wrote:
> Ah, no you couldn't set up a command alias like that. Still, if the full
> name was statistics, you could type 'stat' and it would match. 'stats'
> wouldn't, though.
>
> I do think decoupling the
jasonmolenda added a comment.
Ah, no you couldn't set up a command alias like that. Still, if the full name
was statistics, you could type 'stat' and it would match. 'stats' wouldn't,
though.
I do think decoupling the disabling action from the dumping action would be an
improvement. You
jasonmolenda added a comment.
My two cents,
Why print the '### Start STATISTICS dump ###' header/footer when printing the
results? I don't think we demarcate result output like that anywhere else in
lldb. I don't think it adds anything for the user.
I would probably name the command
davide created this revision.
davide added reviewers: jingham, friss, JDevlieghere, aprantl, labath, clayborg.
This allows us to collect useful metrics about lldb debugging sessions.
I thought that an example would be better than a thousand words:
Process 19705 stopped
* thread #1, queue =
Author: jingham
Date: Wed Apr 11 12:27:03 2018
New Revision: 329844
URL: http://llvm.org/viewvc/llvm-project?rev=329844=rev
Log:
Fix a thinko in CommandObjectMemoryRegion.
Don't try to read the first argument till you've checked
that there is one.
Modified:
Author: davide
Date: Wed Apr 11 10:53:02 2018
New Revision: 329831
URL: http://llvm.org/viewvc/llvm-project?rev=329831=rev
Log:
[Target] Remove dead/commented out code. NFC.
Some spring cleaning before I touch this file more extensively.
Modified:
lldb/trunk/include/lldb/Target/Target.h
davide accepted this revision.
davide added a comment.
LGTM
https://reviews.llvm.org/D45518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere updated this revision to Diff 142037.
JDevlieghere added a comment.
- Address Adrian's feedback
https://reviews.llvm.org/D45518
Files:
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/dotest_args.py
packages/Python/lldbsuite/test/make/Makefile.rules
JDevlieghere added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:306
+ if args.dsymutil:
+os.environ['DSYMUTIL'] = args.dsymutil
+ else:
aprantl wrote:
> I suppose we could point to llvm-dsymutil even on non-darwin
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:306
+ if args.dsymutil:
+os.environ['DSYMUTIL'] = args.dsymutil
+ else:
I suppose we could point to llvm-dsymutil even on non-darwin platforms? Might
be useful
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
Sorry for getting in here late. This seems to be a great improvement on the
state of the art, and given it's only enabled for the CMake build, I see little
harm not going forward with it.
In
JDevlieghere added inline comments.
Comment at: lit/Suite/lldbtest.py:46
+cmd = self.dotest_cmd + [testPath, '-p', testName]
+print ' '.join(cmd)
+
labath wrote:
> It looks like `executeCommand` accepts a list of args for a command as well,
> so
JDevlieghere added a comment.
The only outstanding issue is calling `llvm-lit` with the path to the test
suite. Does anybody with more lit experience know how we can solve this?
https://reviews.llvm.org/D45333
___
lldb-commits mailing list
JDevlieghere updated this revision to Diff 142028.
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
- Feedback Pavel
- Makes `check-lldb` invoke *only* lit.
https://reviews.llvm.org/D45333
Files:
lit/Suite/lit.cfg
lit/Suite/lit.site.cfg.in
JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, davide, jingham, labath.
Herald added a subscriber: mgorny.
With the upstream implementation of dsymutil containing almost all
functionality from the one shipped with Xcode, we want to use the
in-tree version for running
Author: labath
Date: Wed Apr 11 06:30:54 2018
New Revision: 329803
URL: http://llvm.org/viewvc/llvm-project?rev=329803=rev
Log:
llgs: Send "rich" errors in response to vAttach packets
There are plenty of ways attaching can go wrong. Having the server
report the exact error means we can give
JDevlieghere updated this revision to Diff 141982.
JDevlieghere added a comment.
- Address Greg's comment and factor out the method.
- Add a test case.
https://reviews.llvm.org/D45497
Files:
include/lldb/Target/ThreadList.h
On Wed, 11 Apr 2018 01:24:53 +0200, Jan Kratochvil wrote:
> On Wed, 11 Apr 2018 00:53:20 +0200, Jan Kratochvil wrote:
> > On Wed, 11 Apr 2018 00:22:45 +0200, Greg Clayton wrote:
> > > If this is all in the same file, then the offsets are all in the
> > > .debug_info? What am I missing?
> >
> >
19 matches
Mail list logo
