Author: davide
Date: Mon Apr 16 16:59:01 2018
New Revision: 330170
URL: http://llvm.org/viewvc/llvm-project?rev=330170=rev
Log:
[Statistics] Relax the test output a little bit.
We don't really care about the order as this is a dictionary.
It should be more resilient to changes (adding/shuffling
clayborg added a comment.
Looks good. I questions if we want PlaceholderModule to be available for all
symbolicators/core dump plugins. See inlined comments.
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:47
Author: davide
Date: Mon Apr 16 15:55:34 2018
New Revision: 330165
URL: http://llvm.org/viewvc/llvm-project?rev=330165=rev
Log:
[Commands] Expose statistics through the SBAPI.
The API is `SBStructuredData GetStatistics()`. This allows
the command to be used in scripts.
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330163: Make sure deleting all breakpoints clears their
sites first (authored by eugene, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: eugene
Date: Mon Apr 16 15:26:21 2018
New Revision: 330163
URL: http://llvm.org/viewvc/llvm-project?rev=330163=rev
Log:
Make sure deleting all breakpoints clears their sites first
Bug: https://bugs.llvm.org/show_bug.cgi?id=36430
Differential Revision: https://reviews.llvm.org/D45554
lemo updated this revision to Diff 142706.
lemo edited the summary of this revision.
https://reviews.llvm.org/D45700
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
lemo added inline comments.
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:53
+ // Creates a synthetic module section covering the whole module image
+ void CreateImageSection(const MinidumpModule *module, Target& target) {
+const ConstString
amccarth added a comment.
Nice!
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:53
+ // Creates a synthetic module section covering the whole module image
+ void CreateImageSection(const MinidumpModule *module, Target& target) {
+const ConstString
lemo created this revision.
lemo added reviewers: clayborg, labath, amccarth.
lemo added a project: LLDB.
Herald added subscribers: JDevlieghere, aprantl.
Normally, LLDB is creating a high-fidelity representation of a live
process, including a list of modules and sections, with the
associated
Author: davide
Date: Mon Apr 16 12:07:14 2018
New Revision: 330149
URL: http://llvm.org/viewvc/llvm-project?rev=330149=rev
Log:
[lldb-private] Mark a function as inline to prevent multiple def errors.
Modified:
lldb/trunk/include/lldb/lldb-private-enumerations.h
Modified:
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Sure.
https://reviews.llvm.org/D45554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
eugene added a comment.
If nobody minds, I'd appreciate if somebody would accept this patch.
https://reviews.llvm.org/D45554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
I think you need to mark this inline otherwise you're going to get multiple
definitions no?
On Mon, Apr 16, 2018 at 11:29 AM Davide Italiano via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: davide
> Date: Mon Apr 16 11:25:57 2018
> New Revision: 330147
>
> URL:
Author: davide
Date: Mon Apr 16 11:25:57 2018
New Revision: 330147
URL: http://llvm.org/viewvc/llvm-project?rev=330147=rev
Log:
[Statistics] Move GetStatDescription to an header file.
In preparation for using it in the API.
Modified:
lldb/trunk/include/lldb/lldb-private-enumerations.h
labath added a comment.
Thank you for the patch. For testing I'd recommend taking a look at r320813
https://reviews.llvm.org/D40616, which implemented the SHF_COMPRESSED part of
the compressed section support. It looks like we should add a new field to the
"lldb-test module-sections" output,
15 matches
Mail list logo