[Lldb-commits] [lldb] r330170 - [Statistics] Relax the test output a little bit.

2018-04-16 Thread Davide Italiano via lldb-commits
Author: davide Date: Mon Apr 16 16:59:01 2018 New Revision: 330170 URL: http://llvm.org/viewvc/llvm-project?rev=330170=rev Log: [Statistics] Relax the test output a little bit. We don't really care about the order as this is a dictionary. It should be more resilient to changes (adding/shuffling

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

2018-04-16 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Looks good. I questions if we want PlaceholderModule to be available for all symbolicators/core dump plugins. See inlined comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:47

[Lldb-commits] [lldb] r330165 - [Commands] Expose statistics through the SBAPI.

2018-04-16 Thread Davide Italiano via lldb-commits
Author: davide Date: Mon Apr 16 15:55:34 2018 New Revision: 330165 URL: http://llvm.org/viewvc/llvm-project?rev=330165=rev Log: [Commands] Expose statistics through the SBAPI. The API is `SBStructuredData GetStatistics()`. This allows the command to be used in scripts. Added:

[Lldb-commits] [PATCH] D45554: Make sure deleting all breakpoints clears their sites first

2018-04-16 Thread Eugene Zemtsov via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL330163: Make sure deleting all breakpoints clears their sites first (authored by eugene, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r330163 - Make sure deleting all breakpoints clears their sites first

2018-04-16 Thread Eugene Zemtsov via lldb-commits
Author: eugene Date: Mon Apr 16 15:26:21 2018 New Revision: 330163 URL: http://llvm.org/viewvc/llvm-project?rev=330163=rev Log: Make sure deleting all breakpoints clears their sites first Bug: https://bugs.llvm.org/show_bug.cgi?id=36430 Differential Revision: https://reviews.llvm.org/D45554

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

2018-04-16 Thread Leonard Mosescu via Phabricator via lldb-commits
lemo updated this revision to Diff 142706. lemo edited the summary of this revision. https://reviews.llvm.org/D45700 Files: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

2018-04-16 Thread Leonard Mosescu via Phabricator via lldb-commits
lemo added inline comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:53 + // Creates a synthetic module section covering the whole module image + void CreateImageSection(const MinidumpModule *module, Target& target) { +const ConstString

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

2018-04-16 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth added a comment. Nice! Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:53 + // Creates a synthetic module section covering the whole module image + void CreateImageSection(const MinidumpModule *module, Target& target) { +const ConstString

[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

2018-04-16 Thread Leonard Mosescu via Phabricator via lldb-commits
lemo created this revision. lemo added reviewers: clayborg, labath, amccarth. lemo added a project: LLDB. Herald added subscribers: JDevlieghere, aprantl. Normally, LLDB is creating a high-fidelity representation of a live process, including a list of modules and sections, with the associated

[Lldb-commits] [lldb] r330149 - [lldb-private] Mark a function as inline to prevent multiple def errors.

2018-04-16 Thread Davide Italiano via lldb-commits
Author: davide Date: Mon Apr 16 12:07:14 2018 New Revision: 330149 URL: http://llvm.org/viewvc/llvm-project?rev=330149=rev Log: [lldb-private] Mark a function as inline to prevent multiple def errors. Modified: lldb/trunk/include/lldb/lldb-private-enumerations.h Modified:

[Lldb-commits] [PATCH] D45554: Make sure deleting all breakpoints clears their sites first

2018-04-16 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Sure. https://reviews.llvm.org/D45554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D45554: Make sure deleting all breakpoints clears their sites first

2018-04-16 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene added a comment. If nobody minds, I'd appreciate if somebody would accept this patch. https://reviews.llvm.org/D45554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r330147 - [Statistics] Move GetStatDescription to an header file.

2018-04-16 Thread Zachary Turner via lldb-commits
I think you need to mark this inline otherwise you're going to get multiple definitions no? On Mon, Apr 16, 2018 at 11:29 AM Davide Italiano via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: davide > Date: Mon Apr 16 11:25:57 2018 > New Revision: 330147 > > URL:

[Lldb-commits] [lldb] r330147 - [Statistics] Move GetStatDescription to an header file.

2018-04-16 Thread Davide Italiano via lldb-commits
Author: davide Date: Mon Apr 16 11:25:57 2018 New Revision: 330147 URL: http://llvm.org/viewvc/llvm-project?rev=330147=rev Log: [Statistics] Move GetStatDescription to an header file. In preparation for using it in the API. Modified: lldb/trunk/include/lldb/lldb-private-enumerations.h

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

2018-04-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thank you for the patch. For testing I'd recommend taking a look at r320813 https://reviews.llvm.org/D40616, which implemented the SHF_COMPRESSED part of the compressed section support. It looks like we should add a new field to the "lldb-test module-sections" output,