Re: [Lldb-commits] [lldb] r330314 - Attempt to fix TestMiniDump on windows

2018-04-20 Thread Pavel Labath via lldb-commits
On Thu, 19 Apr 2018 at 18:11, Leonard Mosescu wrote: > The mix of backward and forward slashes doesn't impact my current project but it would be nice to have a consistent path syntax (both within a single path and also cross platforms). >> Leonard, is it reasonable to assume that all paths in t

[Lldb-commits] [lldb] r330405 - Move FileSpecTest to Utility

2018-04-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Apr 20 01:27:27 2018 New Revision: 330405 URL: http://llvm.org/viewvc/llvm-project?rev=330405&view=rev Log: Move FileSpecTest to Utility FileSpec class was moved to the Utility module a while ago, but the test file was left behind. This corrects that. Added: lldb/tru

[Lldb-commits] [PATCH] D45333: WIP: [LIT] Have lit run the lldb test suite

2018-04-20 Thread Alberto Magni via Phabricator via lldb-commits
alberto_magni added a comment. Hi Jonas, This change is causing a cmake generation-time error on Windows when using Visual Studio as generator: -G "Visual Studio 15 2017 Win64" -Thost=x64 The error is: CMake Error in tools/lldb/test/CMakeLists.txt: Evaluation file to be written multiple

[Lldb-commits] [PATCH] D45333: WIP: [LIT] Have lit run the lldb test suite

2018-04-20 Thread Ted Woodward via Phabricator via lldb-commits
ted added a comment. @JDevlieghere I'm seeing the same issue as @alberto_magni . The Visual Studio cmake generator gives errors. We're reverting it internally, but it needs to be fixed or reverted ASAP. The issue could be this set of code from test/CMakeLists.txt: configure_file( ${CMAK

[Lldb-commits] [lldb] r330450 - Fix a crash when resolving overloads of C++ virtual methods.

2018-04-20 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Fri Apr 20 10:14:05 2018 New Revision: 330450 URL: http://llvm.org/viewvc/llvm-project?rev=330450&view=rev Log: Fix a crash when resolving overloads of C++ virtual methods. The isOverload() method needs to account for situations where the two methods being compared don't have

[Lldb-commits] [PATCH] D45333: WIP: [LIT] Have lit run the lldb test suite

2018-04-20 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. Since Visual Studio as a Generator supports multiple build configurations, each of the CMakeLists.txt that correspond to lit tests also need to include handling of the build mode unless you can guarantee that all the properties are set correctly before test/CMa

[Lldb-commits] [lldb] r330460 - Fix the Xcode gtest target for the move of FileSpecTest.cpp.

2018-04-20 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Apr 20 11:30:31 2018 New Revision: 330460 URL: http://llvm.org/viewvc/llvm-project?rev=330460&view=rev Log: Fix the Xcode gtest target for the move of FileSpecTest.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.p