labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks fine to me. Normalization, at least as it is implemented now in
`remove_dots`, is a fairly heavy operation, so it makes sense to avoid it when
possible. And the extra speedup is great.
clayborg created this revision.
clayborg added reviewers: jingham, davide, aprantl, labath, lldb-commits.
This patch fixes an issue where we weren't looking for exact matches in the
expression parser and also fixed the type lookup logic in the Module.cpp. Tests
added to make sure we don't regres
labath added a comment.
Could you add a "section type" line in the `dumpModules` in lldb-test.cpp. Then
we can write a test for this. (not that this is a extremely dangerous change,
but it seems a shame not to test it when it is so easy).
https://reviews.llvm.org/D40468
jankratochvil updated this revision to Diff 144177.
jankratochvil added a comment.
Implemented that `section type` line in the `dumpModules` in lldb-test.cpp.
https://reviews.llvm.org/D40468
Files:
include/lldb/Core/Section.h
include/lldb/lldb-enumerations.h
lit/Modules/build-id-case.yaml
labath added a comment.
Thanks, that's great, but I don't see you using that functionality to test the
debug-alt-link classification (I guess I wasn't clear about that, but that is
the reason why I asked you to add it). Could you add a test with the new
section as well?
https://reviews.llvm.o
aprantl created this revision.
aprantl added reviewers: clayborg, jingham, jasonmolenda, labath.
Herald added subscribers: mgrang, JDevlieghere, kbarton, arichardson, nemanjai,
kubamracek, emaste, srhines.
Herald added a reviewer: javed.absar.
Herald added a reviewer: espindola.
This is intended
jankratochvil updated this revision to Diff 144210.
jankratochvil added a comment.
Added `lit/Modules/dwarf-gnu-debugaltlink.yaml`. I do not see its test success
anywhere but when I make it fail I see its failure in `make check-lldb`
stdout/stderr. Curiously its simulated failure does not appear
Author: friss
Date: Thu Apr 26 17:09:04 2018
New Revision: 331004
URL: http://llvm.org/viewvc/llvm-project?rev=331004&view=rev
Log:
[debugserver] Fix handling of the 'g' packet
LLDB doesn't use this packet so we never hit this, but it looks like
some other projects talk to debugserver and are hit
Author: jingham
Date: Thu Apr 26 18:57:40 2018
New Revision: 331012
URL: http://llvm.org/viewvc/llvm-project?rev=331012&view=rev
Log:
Fix a thinko in the iteration over StructuredDataPlugin Create functions.
The code was grabbing the first plugin, and then never getting
another one.
Modified:
On Thu, Apr 26, 2018 at 6:57 PM, Jim Ingham via lldb-commits
wrote:
> Author: jingham
> Date: Thu Apr 26 18:57:40 2018
> New Revision: 331012
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331012&view=rev
> Log:
> Fix a thinko in the iteration over StructuredDataPlugin Create functions.
>
> The
10 matches
Mail list logo