[Lldb-commits] [PATCH] D46548: Really test type lookup in TestCppTypeLookup.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL331719: Really test type lookup in TestCppTypeLookup.py (authored by friss, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46548 Files: lldb/

[Lldb-commits] [lldb] r331719 - Really test type lookup in TestCppTypeLookup.py

Author: friss Date: Mon May 7 20:08:46 2018 New Revision: 331719 URL: http://llvm.org/viewvc/llvm-project?rev=331719&view=rev Log: Really test type lookup in TestCppTypeLookup.py Summary: ... and fix one bug found this way. Currently, the test works not because types are looked up correctly, but

[Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

jingham accepted this revision. jingham added a comment. I'm still a little sad we can't get this to happen correctly in clang's lookup, but this is a clever way to get the benefit of this workaround without paying all the cost, and is a fine temporary solution. The implementation looks okay to

[Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. I forgot to increment from before continuing in my example. No need to update code if you don't feel it is clearer https://reviews.llvm.org/D46551 _

[Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

clayborg added inline comments. Comment at: source/Expression/ExpressionSourceCode.cpp:174-179 +if ((from != 0 && clang::isIdentifierBody(body[from-1])) || +(from + var.size() != body.size() && + clang::isIdentifierBody(body[from+var.size()]))) { + ++from

[Lldb-commits] [lldb] r331686 - [lit, lldbsuite] Fixes for several tests LLDB tests for Python 3 or Windows

Author: stella.stamenova Date: Mon May 7 14:57:00 2018 New Revision: 331686 URL: http://llvm.org/viewvc/llvm-project?rev=331686&view=rev Log: [lit, lldbsuite] Fixes for several tests LLDB tests for Python 3 or Windows Summary: In decorators.py, when opening streams, open them in text mode. In Py

[Lldb-commits] [PATCH] D46551: Inject only relevant local variables in the expression evaluation context

friss created this revision. friss added reviewers: jingham, clayborg. In r259902, LLDB started injecting all the locals in every expression evaluation. This fixed a bunch of issues, but also caused others, mostly performance regressions on some codebases. The regressions were bad enough that we a

[Lldb-commits] [lldb] r331679 - Test Commit: fix a comment to be grammatically correct

Author: stella.stamenova Date: Mon May 7 14:19:14 2018 New Revision: 331679 URL: http://llvm.org/viewvc/llvm-project?rev=331679&view=rev Log: Test Commit: fix a comment to be grammatically correct Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py Modified: lldb/trunk/packages/Py

[Lldb-commits] [RFC] Type lookup for template types is broken...

(...At least when using accelerator tables) If you apply the following patch, TestClassTemplateParameterPack.py will start failing: diff --git a/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/main.cpp b/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pac

[Lldb-commits] [PATCH] D46548: Really test type lookup in TestCppTypeLookup.py

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. main problem with this approach is if the client tries to lookup "reference_type" as an example... It will end up pulling in and completing every STL type and returning the typedef only fo

[Lldb-commits] [PATCH] D46548: Really test type lookup in TestCppTypeLookup.py

friss created this revision. friss added reviewers: clayborg, jingham. ... and fix one bug found this way. Currently, the test works not because types are looked up correctly, but because by injecting local variables we also materialize the types for Clang. If we disable the local variable injecti

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. In https://reviews.llvm.org/D32167#1087627, @labath wrote: > Maybe we could start by splitting of the ObjectFile recognition code for the > debug_types section into a separate patch. That should be sufficiently > non-controversial and it would reduce the number of file

[Lldb-commits] [PATCH] D46529: Add support to object files for accessing the .debug_types section

clayborg created this revision. clayborg added reviewers: labath, aprantl. Herald added subscribers: JDevlieghere, arichardson, emaste. Herald added a reviewer: espindola. In an effort to make the .debug_types patch smaller, breaking out the part that reads the .debug_types from object files into

Re: [Lldb-commits] [lldb] r331082 - Fix build bots after r331049 broke them.

Fixed with: svn commit source/Target/TargetList.cpp Sendingsource/Target/TargetList.cpp Transmitting file data .done Committing transaction... Committed revision 331637. Test coming soon. > On May 4, 2018, at 10:55 AM, Davide Italiano wrote: > > On Fri, May 4, 2018 at 10:54 AM, Greg Cl

[Lldb-commits] [lldb] r331637 - Fix "file ./a.out" and file "../a.out" so that is works after recent FileSpec normalization path changes.

Author: gclayton Date: Mon May 7 07:21:04 2018 New Revision: 331637 URL: http://llvm.org/viewvc/llvm-project?rev=331637&view=rev Log: Fix "file ./a.out" and file "../a.out" so that is works after recent FileSpec normalization path changes. Test coming soon, but I want to unbreak people. Modif